Skip to content

Commit 8345c4d

Browse files
authored
Minor cmake changes (#21)
* Normalize CMakeLists spacing * Suppress version output
1 parent c2a138a commit 8345c4d

File tree

3 files changed

+35
-36
lines changed

3 files changed

+35
-36
lines changed

CMakeLists.txt

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ cmake_minimum_required(VERSION 3.8)
1010
# Determine version number from git metadata
1111
include("${CMAKE_CURRENT_LIST_DIR}/cmake/FlibcppVersion.cmake")
1212
flibcpp_find_version(Flibcpp "${CMAKE_CURRENT_LIST_DIR}/cmake/git-version.txt")
13-
message(STATUS "Flibcpp version: ${Flibcpp_VERSION}")
1413

1514
project(Flibcpp VERSION "${Flibcpp_VERSION}" LANGUAGES CXX Fortran)
1615

@@ -22,17 +21,17 @@ option(FLIBCPP_DEV "Default to using development-centered options" OFF)
2221
option(FLIBCPP_BUILD_DOCS "Build documentation with Sphinx" ${FLIBCPP_DEV})
2322
option(FLIBCPP_USE_SWIG "Regenerate source files using SWIG" ${FLIBCPP_DEV})
2423

25-
if (CMAKE_PROJECT_NAME STREQUAL PROJECT_NAME)
24+
if(CMAKE_PROJECT_NAME STREQUAL PROJECT_NAME)
2625
set(_DEFAULT_BUILD_EXAMPLES ON)
2726
endif()
2827
option(FLIBCPP_BUILD_EXAMPLES "Build examples" ${_DEFAULT_BUILD_EXAMPLES})
2928

30-
if (FLIBCPP_DEV)
29+
if(FLIBCPP_DEV)
3130
set(_DEFAULT_BUILD_TESTS ON)
3231
endif()
3332
option(FLIBCPP_BUILD_TESTS "Build Flibcpp tests" ${_DEFAULT_BUILD_TESTS})
3433

35-
if (FLIBCPP_BUILD_TESTS OR FLIBCPP_BUILD_EXAMPLES)
34+
if(FLIBCPP_BUILD_TESTS OR FLIBCPP_BUILD_EXAMPLES)
3635
set(_DEFAULT_BUILD_TESTING ON)
3736
endif()
3837
option(BUILD_TESTING "Enable CTest" ${_DEFAULT_BUILD_TESTING})
@@ -44,10 +43,10 @@ option(BUILD_TESTING "Enable CTest" ${_DEFAULT_BUILD_TESTING})
4443
# Fortran standard
4544
set(FLIBCPP_FORTRAN_STD "03" CACHE STRING
4645
"Fortran standard for compiling generated code (options: 03/08/15/18/none)")
47-
if (FLIBCPP_FORTRAN_STD AND NOT FLIBCPP_FORTRAN_STD STREQUAL "none")
48-
if (CMAKE_Fortran_COMPILER_ID STREQUAL "GNU")
46+
if(FLIBCPP_FORTRAN_STD AND NOT FLIBCPP_FORTRAN_STD STREQUAL "none")
47+
if(CMAKE_Fortran_COMPILER_ID STREQUAL "GNU")
4948
set(_FLIBCPP_STD_FLAGS "-std=f20${FLIBCPP_FORTRAN_STD}")
50-
elseif (CMAKE_Fortran_COMPILER_ID STREQUAL "Intel")
49+
elseif(CMAKE_Fortran_COMPILER_ID STREQUAL "Intel")
5150
set(_FLIBCPP_STD_FLAGS "-std${FLIBCPP_FORTRAN_STD}")
5251
else()
5352
message(WARNING "Fortran standard flags are not known for "
@@ -60,8 +59,8 @@ if (FLIBCPP_FORTRAN_STD AND NOT FLIBCPP_FORTRAN_STD STREQUAL "none")
6059
endif()
6160

6261
# Build type
63-
if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
64-
if (FLIBCPP_DEV)
62+
if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
63+
if(FLIBCPP_DEV)
6564
set(_CMAKE_BUILD_TYPE "Debug")
6665
else ()
6766
set(_CMAKE_BUILD_TYPE "RelWithDebInfo")
@@ -75,25 +74,25 @@ endif()
7574
#---------------------------------------------------------------------------#
7675

7776
list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake")
78-
if (CMAKE_VERSION VERSION_LESS 3.18)
77+
if(CMAKE_VERSION VERSION_LESS 3.18)
7978
list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake/backport-cmake-318")
8079
endif()
8180

82-
if (FLIBCPP_USE_SWIG)
81+
if(FLIBCPP_USE_SWIG)
8382
find_package(SWIG COMPONENTS fortran REQUIRED)
8483

85-
if (CMAKE_VERSION VERSION_LESS 3.12)
84+
if(CMAKE_VERSION VERSION_LESS 3.12)
8685
message(FATAL_ERROR "CMake 3.12 or higher is required to regenerate the "
8786
"Fortran bindings using SWIG. Set FLIBCPP_USE_SWIG to OFF "
8887
"and reconfigure.")
8988
endif()
9089

91-
if (CMAKE_VERSION GREATER_EQUAL 3.13)
90+
if(CMAKE_VERSION GREATER_EQUAL 3.13)
9291
cmake_policy(SET CMP0078 "NEW")
9392
else()
9493
set(FLIBCPP_CMP0078 "NEW")
9594
endif()
96-
if (CMAKE_VERSION GREATER_EQUAL 3.14)
95+
if(CMAKE_VERSION GREATER_EQUAL 3.14)
9796
cmake_policy(SET CMP0086 "NEW")
9897
else()
9998
set(FLIBCPP_CMP0086 "NEW")
@@ -121,7 +120,7 @@ set(FLIBCPP_NAMESPACE "Flibcpp::")
121120
set(FLIBCPP_LIBRARIES)
122121

123122
function(flibcpp_add_module name)
124-
if (FLIBCPP_USE_SWIG)
123+
if(FLIBCPP_USE_SWIG)
125124
# SWIG is available; actually generate the library dynamically.
126125

127126
set(src_file "${FLIBCPP_INTERFACE_DIR}/${name}.i")
@@ -173,7 +172,7 @@ function(flibcpp_add_module name)
173172
# Compile with e.g. std=c++11 instead of =gnu++11
174173
set_property(TARGET ${name} PROPERTY CXX_EXTENSIONS OFF)
175174

176-
if (_FLIBCPP_STD_FLAGS)
175+
if(_FLIBCPP_STD_FLAGS)
177176
# Compile Fortran code with a particular standard
178177
target_compile_options(${name}
179178
PUBLIC $<$<COMPILE_LANGUAGE:Fortran>:${_FLIBCPP_STD_FLAGS}>
@@ -207,7 +206,7 @@ configure_file("${CMAKE_CURRENT_LIST_DIR}/cmake/flibcpp_version.cpp.in"
207206
flibcpp_add_module(flc "${FLIBCPP_VERSION_CPP}")
208207

209208
# Also install 'import_flc' if using SWIG
210-
if (FLIBCPP_USE_SWIG)
209+
if(FLIBCPP_USE_SWIG)
211210
install(FILES
212211
"${CMAKE_CURRENT_SOURCE_DIR}/include/import_flc.i"
213212
DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"
@@ -273,15 +272,15 @@ install(FILES
273272
# TESTING AND DOCS
274273
#---------------------------------------------------------------------------#
275274

276-
if (FLIBCPP_BUILD_TESTS)
275+
if(FLIBCPP_BUILD_TESTS)
277276
add_subdirectory(test)
278277
endif()
279278

280-
if (FLIBCPP_BUILD_EXAMPLES)
279+
if(FLIBCPP_BUILD_EXAMPLES)
281280
add_subdirectory(example)
282281
endif()
283282

284-
if (FLIBCPP_BUILD_DOCS)
283+
if(FLIBCPP_BUILD_DOCS)
285284
add_subdirectory(doc)
286285
endif()
287286

cmake/FlibcppConfig.cmake.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ include(CMakeFindDependencyMacro)
33

44
list(APPEND CMAKE_MODULE_PATH ${Flibcpp_CMAKE_DIR})
55

6-
if (NOT TARGET @FLIBCPP_NAMESPACE@flc)
6+
if(NOT TARGET @FLIBCPP_NAMESPACE@flc)
77
include("${Flibcpp_CMAKE_DIR}/FlibcppTargets.cmake")
88
endif()
99

@@ -15,7 +15,7 @@ set(FLIBCPP_FORTRAN_STD @FLIBCPP_FORTRAN_STD@)
1515
set(FLIBCPP_SWIG_EXECUTABLE @FLIBCPP_SWIG_EXECUTABLE@)
1616
set(FLIBCPP_SWIG_DIR @FLIBCPP_SWIG_DIR@)
1717

18-
if (NOT FLIBCPP_BUILD_SHARED_LIBS)
18+
if(NOT FLIBCPP_BUILD_SHARED_LIBS)
1919
# Downstream libraries must find and link to the C++ runtimes themselves since
2020
# they can't use the shared library dependencies
2121
enable_language(CXX)

cmake/FlibcppVersion.cmake

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ FlibcppVersion
3131
3232
#]=======================================================================]
3333

34-
if (CMAKE_SCRIPT_MODE_FILE)
34+
if(CMAKE_SCRIPT_MODE_FILE)
3535
cmake_minimum_required(VERSION 3.8)
3636
endif()
3737

@@ -40,11 +40,11 @@ function(flibcpp_find_version PROJNAME GIT_VERSION_FILE)
4040
# .gitattributes file)
4141
file(STRINGS "${GIT_VERSION_FILE}" _TEXTFILE)
4242

43-
if (_TEXTFILE MATCHES "\\$Format:")
43+
if(_TEXTFILE MATCHES "\\$Format:")
4444
# Not a "git archive": use live git information
4545
set(_CACHE_VAR "${PROJNAME}_GIT_DESCRIBE")
4646
set(_CACHED_VERSION "${${_CACHE_VAR}}")
47-
if (NOT _CACHED_VERSION)
47+
if(NOT _CACHED_VERSION)
4848
# Building from a git checkout rather than a distribution
4949
find_package(Git QUIET REQUIRED)
5050
execute_process(
@@ -55,26 +55,26 @@ function(flibcpp_find_version PROJNAME GIT_VERSION_FILE)
5555
RESULT_VARIABLE _GIT_RESULT
5656
OUTPUT_STRIP_TRAILING_WHITESPACE
5757
)
58-
if (NOT _GIT_RESULT EQUAL "0")
58+
if(NOT _GIT_RESULT EQUAL "0")
5959
message(WARNING "Failed to get ${PROJNAME} version from git: "
6060
"${_GIT_ERR}")
61-
elseif (NOT _VERSION_STRING)
61+
elseif(NOT _VERSION_STRING)
6262
message(WARNING "Failed to get ${PROJNAME} version from git: "
6363
"git describe returned an empty string")
6464
else()
6565
# Process description tag: e.g. v0.4.0-2-gc4af497 or v0.4.0
6666
string(REGEX MATCH "v([0-9.]+)(-[0-9]+-g([0-9a-f]+))?" _MATCH
6767
"${_VERSION_STRING}"
6868
)
69-
if (_MATCH)
69+
if(_MATCH)
7070
set(_VERSION_STRING "${CMAKE_MATCH_1}")
71-
if (CMAKE_MATCH_2)
71+
if(CMAKE_MATCH_2)
7272
# *not* a tagged release
7373
set(_VERSION_HASH "${CMAKE_MATCH_3}")
7474
endif()
7575
endif()
7676
endif()
77-
if (NOT _VERSION_STRING)
77+
if(NOT _VERSION_STRING)
7878
execute_process(
7979
COMMAND "${GIT_EXECUTABLE}" "log" "-1" "--format=%h" "HEAD"
8080
WORKING_DIRECTORY "${CMAKE_CURRENT_LIST_DIR}"
@@ -92,25 +92,25 @@ function(flibcpp_find_version PROJNAME GIT_VERSION_FILE)
9292
# First line are decorators, second is hash.
9393
list(GET _TEXTFILE 0 _TAG)
9494
string(REGEX MATCH "tag: *v([0-9.]+)" _MATCH "${_TAG}")
95-
if (_MATCH)
95+
if(_MATCH)
9696
set(_VERSION_STRING "${CMAKE_MATCH_1}")
9797
else()
9898
# *not* a tagged release
9999
list(GET _TEXTFILE 1 _HASH)
100100
string(REGEX MATCH " *([0-9a-f]+)" _MATCH "${_HASH}")
101-
if (_MATCH)
101+
if(_MATCH)
102102
set(_VERSION_HASH "${CMAKE_MATCH_1}")
103103
endif()
104104
endif()
105105
endif()
106106

107-
if (NOT _VERSION_STRING)
107+
if(NOT _VERSION_STRING)
108108
message(WARNING "Could not determine version number for ${PROJNAME}: "
109109
"perhaps a non-release archive?")
110110
set(_VERSION_STRING "0.0.0")
111111
endif()
112112

113-
if (_VERSION_HASH)
113+
if(_VERSION_HASH)
114114
set(_FULL_VERSION_STRING "v${_VERSION_STRING}+${_VERSION_HASH}")
115115
else()
116116
set(_FULL_VERSION_STRING "v${_VERSION_STRING}")
@@ -120,9 +120,9 @@ function(flibcpp_find_version PROJNAME GIT_VERSION_FILE)
120120
set(${PROJNAME}_VERSION_STRING "${_FULL_VERSION_STRING}" PARENT_SCOPE)
121121
endfunction()
122122

123-
if (CMAKE_SCRIPT_MODE_FILE)
123+
if(CMAKE_SCRIPT_MODE_FILE)
124124
# This script is being run from the command line. Useful for debugging.
125-
if (NOT DEFINED GIT_VERSION_FILE)
125+
if(NOT DEFINED GIT_VERSION_FILE)
126126
message(FATAL_ERROR "Run this script with "
127127
"cmake -D GIT_VERSION_FILE=git-version.txt -P FlibcppVersion.cmake")
128128
endif()

0 commit comments

Comments
 (0)