Ruby - catch exceptions by const reference

wsfulton · wsfulton · commit 4ce77ffb772e · 2020-02-18T22:06:20.000Z
diff --git a/Lib/ruby/rubycontainer.swg b/Lib/ruby/rubycontainer.swg
@@ -628,7 +628,7 @@ namespace swig
       try {
 	r = swig::from< const Sequence* >( swig::getslice(self, i, j) );
       }
-      catch( std::out_of_range& ) {
+      catch( const std::out_of_range& ) {
       }
       return r;
     }
@@ -687,9 +687,8 @@ namespace swig
 	r = swig::from< Sequence::value_type >( *(at) );
 	$self->erase(at); 
       }
-      catch (std::out_of_range&)
-	{
-	}
+      catch (const std::out_of_range&) {
+      }
       return r;
     }
   }
@@ -757,7 +756,7 @@ namespace swig
       try {
 	r = swig::from< Sequence::value_type >( *(swig::cgetpos(self, i)) );
       }
-      catch( std::out_of_range& ) {
+      catch( const std::out_of_range& ) {
       }
       return r;
     }
@@ -780,7 +779,7 @@ namespace swig
       try {
 	r = swig::from< const Sequence* >( swig::getslice(self, i, j) );
       }
-      catch( std::out_of_range& ) {
+      catch( const std::out_of_range& ) {
       }
       return r;
     }
@@ -790,7 +789,7 @@ namespace swig
       try {
 	r = swig::from< Sequence::value_type >( *(swig::cgetpos(self, i)) );
       }
-      catch( std::out_of_range& ) {
+      catch( const std::out_of_range& ) {
       }
       return r;
     }
@@ -1017,7 +1016,7 @@ namespace swig {
 	  } else {
 	    return rubyseq.check() ? SWIG_OK : SWIG_ERROR;
 	  }
-	} catch (std::exception& e) {
+	} catch (const std::exception& e) {
 	  if (seq) {
 	    VALUE lastErr = rb_gv_get("$!");
 	    if (lastErr == Qnil) {
@@ -1057,7 +1056,7 @@ namespace swig {
 	  } else {
 	    return true;
 	  }
-	} catch (std::exception& e) {
+	} catch (const std::exception& e) {
 	  if (seq) {
 	    VALUE lastErr = rb_gv_get("$!");
 	    if (lastErr == Qnil) {

Original file line number	Diff line number	Diff line change
`@@ -628,7 +628,7 @@ namespace swig`
`628`	`628`	`try {`
`629`	`629`	`r = swig::from< const Sequence* >( swig::getslice(self, i, j) );`
`630`	`630`	`}`
`631`		`- catch( std::out_of_range& ) {`
	`631`	`+ catch( const std::out_of_range& ) {`
`632`	`632`	`}`
`633`	`633`	`return r;`
`634`	`634`	`}`
`@@ -687,9 +687,8 @@ namespace swig`
`687`	`687`	`r = swig::from< Sequence::value_type >( *(at) );`
`688`	`688`	`$self->erase(at);`
`689`	`689`	`}`
`690`		`- catch (std::out_of_range&)`
`691`		`- {`
`692`		`- }`
	`690`	`+ catch (const std::out_of_range&) {`
	`691`	`+ }`
`693`	`692`	`return r;`
`694`	`693`	`}`
`695`	`694`	`}`
`@@ -757,7 +756,7 @@ namespace swig`
`757`	`756`	`try {`
`758`	`757`	`r = swig::from< Sequence::value_type >( *(swig::cgetpos(self, i)) );`
`759`	`758`	`}`
`760`		`- catch( std::out_of_range& ) {`
	`759`	`+ catch( const std::out_of_range& ) {`
`761`	`760`	`}`
`762`	`761`	`return r;`
`763`	`762`	`}`
`@@ -780,7 +779,7 @@ namespace swig`
`780`	`779`	`try {`
`781`	`780`	`r = swig::from< const Sequence* >( swig::getslice(self, i, j) );`
`782`	`781`	`}`
`783`		`- catch( std::out_of_range& ) {`
	`782`	`+ catch( const std::out_of_range& ) {`
`784`	`783`	`}`
`785`	`784`	`return r;`
`786`	`785`	`}`
`@@ -790,7 +789,7 @@ namespace swig`
`790`	`789`	`try {`
`791`	`790`	`r = swig::from< Sequence::value_type >( *(swig::cgetpos(self, i)) );`
`792`	`791`	`}`
`793`		`- catch( std::out_of_range& ) {`
	`792`	`+ catch( const std::out_of_range& ) {`
`794`	`793`	`}`
`795`	`794`	`return r;`
`796`	`795`	`}`
`@@ -1017,7 +1016,7 @@ namespace swig {`
`1017`	`1016`	`} else {`
`1018`	`1017`	`return rubyseq.check() ? SWIG_OK : SWIG_ERROR;`
`1019`	`1018`	`}`
`1020`		`- } catch (std::exception& e) {`
	`1019`	`+ } catch (const std::exception& e) {`
`1021`	`1020`	`if (seq) {`
`1022`	`1021`	`VALUE lastErr = rb_gv_get("$!");`
`1023`	`1022`	`if (lastErr == Qnil) {`
`@@ -1057,7 +1056,7 @@ namespace swig {`
`1057`	`1056`	`} else {`
`1058`	`1057`	`return true;`
`1059`	`1058`	`}`
`1060`		`- } catch (std::exception& e) {`
	`1059`	`+ } catch (const std::exception& e) {`
`1061`	`1060`	`if (seq) {`
`1062`	`1061`	`VALUE lastErr = rb_gv_get("$!");`
`1063`	`1062`	`if (lastErr == Qnil) {`