Add some comments about shared_ptr upcast code

Author: wsfulton

Source/Modules/csharp.cxx

@@ -1762,6 +1762,7 @@ class CSHARP:public Language {
       String *smartnamestr = SwigType_namestr(smart);
       String *bsmartnamestr = SwigType_namestr(smart);
 
+      // TODO: SwigType_typedef_resolve_all on a String instead of SwigType is incorrect for templates
       SwigType *rclassname = SwigType_typedef_resolve_all(classname);
       SwigType *rbaseclassname = SwigType_typedef_resolve_all(baseclassname);
       Replaceall(bsmartnamestr, rclassname, rbaseclassname);

Source/Modules/d.cxx

@@ -3381,6 +3381,7 @@ class D : public Language {
       String *smartnamestr = SwigType_namestr(smart);
       String *bsmartnamestr = SwigType_namestr(smart);
 
+      // TODO: SwigType_typedef_resolve_all on a String instead of SwigType is incorrect for templates
       SwigType *rclassname = SwigType_typedef_resolve_all(classname);
       SwigType *rbaseclassname = SwigType_typedef_resolve_all(baseclassname);
       Replaceall(bsmartnamestr, rclassname, rbaseclassname);

Source/Modules/java.cxx

@@ -1904,6 +1904,7 @@ class JAVA:public Language {
       String *smartnamestr = SwigType_namestr(smart);
       String *bsmartnamestr = SwigType_namestr(smart);
 
+      // TODO: SwigType_typedef_resolve_all on a String instead of SwigType is incorrect for templates
       SwigType *rclassname = SwigType_typedef_resolve_all(classname);
       SwigType *rbaseclassname = SwigType_typedef_resolve_all(baseclassname);
       Replaceall(bsmartnamestr, rclassname, rbaseclassname);

Source/Modules/typepass.cxx

@@ -267,6 +267,8 @@ class TypePass:private Dispatcher {
 	       and smart pointer to base class, so that smart pointer upcasts
 	       are automatically generated. */
 	    SwigType *bsmart = Copy(smart);
+
+	    // TODO: SwigType_typedef_resolve_all on a String instead of SwigType is incorrect for templates
 	    SwigType *rclsname = SwigType_typedef_resolve_all(clsname);
 	    SwigType *rbname = SwigType_typedef_resolve_all(bname);
 	    int replace_count = Replaceall(bsmart, rclsname, rbname);
@@ -276,6 +278,12 @@ class TypePass:private Dispatcher {
 	      String *firstname = Getattr(first, "name");
 	      Replaceall(bsmart, firstname, rbname);
 	    }
+	    // The code above currently creates a smartptr of the base class by substitution, replacing Derived
+	    // with Base resulting in something like: 'smartptr< Derived >' from 'smartptr< Base >'. Instead
+	    // the feature:smartptr should be used as it also contains 'smartptr< Base >' as specified by the user.
+	    // A similar fix should also be done in upcastsCode in java.cxx, csharp.cxx and writeClassUpcast in d.cxx.
+	    // Printf(stdout, "smartcomparison %s <=> %s\n", SwigType_namestr(bsmart), Getattr(bclass, "feature:smartptr"));
+
 	    Delete(rclsname);
 	    Delete(rbname);
 	    String *smartnamestr = SwigType_namestr(smart);