filepath Warning/Error when generating inputs from "add reserve info" & "add extreme day"

[TMBrindle]

When generating inputs for s4x1 in 2030 the add reserve info and add extreme day scripts fail to run. From my debugging and with help from Gemini. it appears as though the way the file path to the input folders where the files that the scripts need to edit is constructed in a way that is not compatible with Windows. I assume the scripts work fine in Linux/mac.

This code change (starting in line 1478 of pg_to_switch) seems to fix the errors but I don't know if it works on Linux/mac.

for desc, options in script_info:
    if (options or {}).get("script") is None:
        continue
    
    # 1. Prepare the arguments list
    script_args = [
        sys.executable,
        # drop ../., etc. from path but don't resolve symlinks
        os.path.normpath(base_dir / options["script"]),
    ]
    
    # 2. Handle the output folder argument
    output_folder_arg = str(short_fn(out_folder)).replace("\\", "/") 
    script_args.append(output_folder_arg)
    
    # 3. Conditional Command Construction
    if sys.platform.startswith('win'):
        # Use the Windows-native tool for quoting (uses double quotes)
        cmd = subprocess.list2cmdline(script_args)
    else:
        # Use the POSIX tool for quoting (uses single quotes)
        cmd = shlex.join(script_args)
        
    if options.get("args"):
        cmd += options["args"]
    
    # ... (rest of the code for printing and running remains the same)
    # exit_status = subprocess.run(cmd, shell=True).returncode 
    # ...

Curious if other have the same error / if this fix works...

[mfripp]

Probably too late to check, but can you say what errors are reported when those scripts try to run, and also what command line is shown at the top before running them? The code seems like it should be cross-platform, so I want to focus in on which part needs changing. I can also check on Windows myself a little later if needed.

[TMBrindle]

Ollie ran into the same issue, these were the errors:

Running 'Add reserve info' script:
'C:\Users\ochapman\miniconda3\envs\switch-pg-reeds\python.exe' add_reserve_info.py 'switch\in\2030\s4x1'

The filename, directory name, or volume label syntax is incorrect.

pg_to_switch:
WARNING: The previous script exited with error status 1

Running 'Add extreme day' script:
'C:\Users\ochapman\miniconda3\envs\switch-pg-reeds\python.exe' add_extreme_days.py 'switch\in\2030\s4x1'

The filename, directory name, or volume label syntax is incorrect.

pg_to_switch:
WARNING: The previous script exited with error status 1

[mfripp]

Thanks. As you saw, the problem was that I was using shlex.join(), which does the wrong kind of quoting for Windows. I've implemented a cross-platform fix, which sends the command and arguments directly to the OS without using shell parsing. That should be more robust. It will also switch between shlex.join() and subprocess.list2cmdline() depending on the platform, but only use them for display purposes. The new code is in pg_to_switch.py now, so it should work after you run git pull.