Optimize code && fix tests

Author: matyhtf

thirdparty/php/streams/plain_wrapper.c

@@ -182,7 +182,8 @@ typedef struct {
     unsigned no_forced_fstat:1;                 /* Use fstat cache even if forced */
     unsigned is_seekable:1;		        /* don't try and seek, if not set */
     unsigned can_poll:1;
-    unsigned _reserved:25;
+    unsigned seekable_detected:1;
+    unsigned _reserved:24;
 
     int lock_flag;			        /* stores the lock state */
     zend_string *temp_name;	                /* if non-null, this is the path to a temporary file that
@@ -252,6 +253,7 @@ static void _sw_detect_is_seekable(php_stdio_stream_data *self) {
         self->is_seekable = !(S_ISFIFO(self->sb.st_mode) || S_ISCHR(self->sb.st_mode));
         self->is_pipe = S_ISFIFO(self->sb.st_mode);
         self->can_poll = S_ISFIFO(self->sb.st_mode) || S_ISSOCK(self->sb.st_mode) || S_ISCHR(self->sb.st_mode);
+        self->seekable_detected = 1;
         if (self->can_poll) {
             swoole_coroutine_socket_create(self->fd);
         }
@@ -287,7 +289,7 @@ static php_stream *_sw_php_stream_fopen_from_fd(int fd, const char *mode, const
     php_stream *stream = sw_php_stream_fopen_from_fd_int_rel(fd, mode, persistent_id);
 
     if (stream) {
-        php_stdio_stream_data *self = (php_stdio_stream_data*)stream->abstract;
+        php_stdio_stream_data *self = (php_stdio_stream_data *) stream->abstract;
 
         _sw_detect_is_seekable(self);
         if (!self->is_seekable) {
@@ -328,10 +330,11 @@ static php_stream_size_t sw_php_stdiop_write(php_stream *stream, const char *buf
         }
         bytes_written = _write(data->fd, buf, (unsigned int)count);
 #else
-        php_stdio_stream_data *self = (php_stdio_stream_data*) stream->abstract;
-        ssize_t bytes_written = self->can_poll ?
-                        swoole_coroutine_write(data->fd, buf, PLAIN_WRAP_BUF_SIZE(count)) :
-                        write(data->fd, buf, count);
+        php_stdio_stream_data *self = (php_stdio_stream_data *) stream->abstract;
+        if (!self->seekable_detected) {
+            _sw_detect_is_seekable(self);
+        }
+        ssize_t bytes_written = write(data->fd, buf, count);
 #endif
         if (bytes_written < 0) {
             if (PHP_IS_TRANSIENT_ERROR(errno)) {
@@ -393,18 +396,17 @@ static php_stream_size_t sw_php_stdiop_read(php_stream *stream, char *buf, size_
             }
         }
 #endif
-        php_stdio_stream_data *self = (php_stdio_stream_data*) stream->abstract;
-        ret = self->can_poll ?
-                swoole_coroutine_read(data->fd, buf, PLAIN_WRAP_BUF_SIZE(count)) :
-                read(data->fd, buf, PLAIN_WRAP_BUF_SIZE(count));
+        php_stdio_stream_data *self = (php_stdio_stream_data *) stream->abstract;
+        if (!self->seekable_detected) {
+            _sw_detect_is_seekable(self);
+        }
+        ret = read(data->fd, buf, PLAIN_WRAP_BUF_SIZE(count));
 
         if (ret == (ssize_t) -1 && errno == EINTR) {
             /* Read was interrupted, retry once,
              If read still fails, giveup with feof==0
              so script can retry if desired */
-            ret = self->can_poll ?
-                    swoole_coroutine_read(data->fd, buf, PLAIN_WRAP_BUF_SIZE(count)) :
-                    read(data->fd, buf, PLAIN_WRAP_BUF_SIZE(count));
+            ret = read(data->fd, buf, PLAIN_WRAP_BUF_SIZE(count));
         }
 
         if (ret < 0) {