Fix Ultrathink Triumph and Despair Calculation in Dice Results with Extensive Rule Tests (#18)

* fix(dice): correct counting of triumphs and despairs in dice results

The summing logic for dice results was updated to include triumphs in successes and despairs in failures. Additionally, dice face definitions for proficiency and challenge dice were corrected to not double count successes and failures with triumphs and despairs respectively. Corresponding tests were updated to reflect these changes.

Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>

* test(triumph-despair-rules): add comprehensive tests for triumphs and despairs counting

Add a new test suite verifying the Star Wars RPG rule that triumphs count as successes and despairs count as failures. The tests cover rolled and automatic triumphs/despairs, their combination with regular successes/failures, net success/failure calculations, and ensure no double-counting occurs.

Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>

---------

Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>

Author: jziggas

src/dice.ts

@@ -216,8 +216,8 @@ const sumResults = (
 ): DiceResult => {
   const sums = results.reduce(
     (acc, curr) => ({
-      successes: acc.successes + curr.successes,
-      failures: acc.failures + curr.failures,
+      successes: acc.successes + curr.successes + curr.triumphs,
+      failures: acc.failures + curr.failures + curr.despair,
       advantages: acc.advantages + curr.advantages,
       threats: acc.threats + curr.threats,
       triumphs: acc.triumphs + curr.triumphs,

src/diceFaces.ts

@@ -52,7 +52,7 @@ export const PROFICIENCY_DIE_FACES: Record<number, DieFaceSymbols> = {
   9: { successes: 1, advantages: 1 }, // (S)(A)
   10: { advantages: 2 }, // (A)(A)
   11: { advantages: 2 }, // (A)(A)
-  12: { triumphs: 1, successes: 1 }, // (TR) - Triumph also counts as Success
+  12: { triumphs: 1 }, // (TR) - Triumph also counts as Success
 };
 
 export const CHALLENGE_DIE_FACES: Record<number, DieFaceSymbols> = {
@@ -67,7 +67,7 @@ export const CHALLENGE_DIE_FACES: Record<number, DieFaceSymbols> = {
   9: { failures: 1, threats: 1 }, // (F)(TH)
   10: { threats: 2 }, // (TH)(TH)
   11: { threats: 2 }, // (TH)(TH)
-  12: { despairs: 1, failures: 1 }, // (D) - Despair also counts as Failure
+  12: { despairs: 1 }, // (D) - Despair also counts as Failure
 };
 
 export const FORCE_DIE_FACES: Record<number, DieFaceSymbols> = {

tests/diceFaces.test.ts

@@ -71,7 +71,7 @@ describe("Dice Face Configurations", () => {
       expect(PROFICIENCY_DIE_FACES[9]).toEqual({ successes: 1, advantages: 1 }); // (S)(A)
       expect(PROFICIENCY_DIE_FACES[10]).toEqual({ advantages: 2 }); // (A)(A)
       expect(PROFICIENCY_DIE_FACES[11]).toEqual({ advantages: 2 }); // (A)(A)
-      expect(PROFICIENCY_DIE_FACES[12]).toEqual({ triumphs: 1, successes: 1 }); // (TR) - Triumph also counts as Success
+      expect(PROFICIENCY_DIE_FACES[12]).toEqual({ triumphs: 1 }); // (TR) - Triumph also counts as Success
     });
   });
 
@@ -88,7 +88,7 @@ describe("Dice Face Configurations", () => {
       expect(CHALLENGE_DIE_FACES[9]).toEqual({ failures: 1, threats: 1 }); // (F)(TH)
       expect(CHALLENGE_DIE_FACES[10]).toEqual({ threats: 2 }); // (TH)(TH)
       expect(CHALLENGE_DIE_FACES[11]).toEqual({ threats: 2 }); // (TH)(TH)
-      expect(CHALLENGE_DIE_FACES[12]).toEqual({ despairs: 1, failures: 1 }); // (D) - Despair also counts as Failure
+      expect(CHALLENGE_DIE_FACES[12]).toEqual({ despairs: 1 }); // (D) - Despair also counts as Failure
     });
   });