fix(diceFaces): correct die face values to include success/failure counts (#16)

The 12th face of the proficiency die now correctly counts triumph as a success as well. Similarly, the 12th face of the challenge die counts despair as a failure. Corresponding tests were updated to reflect these changes.

Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>

Author: jziggas

src/diceFaces.ts

@@ -52,7 +52,7 @@ export const PROFICIENCY_DIE_FACES: Record<number, DieFaceSymbols> = {
   9: { successes: 1, advantages: 1 }, // (S)(A)
   10: { advantages: 2 }, // (A)(A)
   11: { advantages: 2 }, // (A)(A)
-  12: { triumphs: 1 }, // (TR)
+  12: { triumphs: 1, successes: 1 }, // (TR) - Triumph also counts as Success
 };
 
 export const CHALLENGE_DIE_FACES: Record<number, DieFaceSymbols> = {
@@ -67,7 +67,7 @@ export const CHALLENGE_DIE_FACES: Record<number, DieFaceSymbols> = {
   9: { failures: 1, threats: 1 }, // (F)(TH)
   10: { threats: 2 }, // (TH)(TH)
   11: { threats: 2 }, // (TH)(TH)
-  12: { despairs: 1 }, // (D)
+  12: { despairs: 1, failures: 1 }, // (D) - Despair also counts as Failure
 };
 
 export const FORCE_DIE_FACES: Record<number, DieFaceSymbols> = {

tests/dice.test.ts

@@ -422,7 +422,7 @@ describe("SWRPG Dice Rolling", () => {
         [
           12,
           {
-            successes: 0,
+            successes: 1,
             failures: 0,
             advantages: 0,
             threats: 0,
@@ -791,7 +791,7 @@ describe("SWRPG Dice Rolling", () => {
           12,
           {
             successes: 0,
-            failures: 0,
+            failures: 1,
             advantages: 0,
             threats: 0,
             triumphs: 0,

tests/diceFaces.test.ts

@@ -71,7 +71,7 @@ describe("Dice Face Configurations", () => {
       expect(PROFICIENCY_DIE_FACES[9]).toEqual({ successes: 1, advantages: 1 }); // (S)(A)
       expect(PROFICIENCY_DIE_FACES[10]).toEqual({ advantages: 2 }); // (A)(A)
       expect(PROFICIENCY_DIE_FACES[11]).toEqual({ advantages: 2 }); // (A)(A)
-      expect(PROFICIENCY_DIE_FACES[12]).toEqual({ triumphs: 1 }); // (TR)
+      expect(PROFICIENCY_DIE_FACES[12]).toEqual({ triumphs: 1, successes: 1 }); // (TR) - Triumph also counts as Success
     });
   });
 
@@ -88,7 +88,7 @@ describe("Dice Face Configurations", () => {
       expect(CHALLENGE_DIE_FACES[9]).toEqual({ failures: 1, threats: 1 }); // (F)(TH)
       expect(CHALLENGE_DIE_FACES[10]).toEqual({ threats: 2 }); // (TH)(TH)
       expect(CHALLENGE_DIE_FACES[11]).toEqual({ threats: 2 }); // (TH)(TH)
-      expect(CHALLENGE_DIE_FACES[12]).toEqual({ despairs: 1 }); // (D)
+      expect(CHALLENGE_DIE_FACES[12]).toEqual({ despairs: 1, failures: 1 }); // (D) - Despair also counts as Failure
     });
   });