Let's find out the bug and resolve it!

[jyeok]

problem / the importance of problem 1~3 (in my opinion)

1. Image load problem (3):

• [ We didn't implement properly the image handling part of frontend.]

2. Main view problem (3):

• [On location, It uses the outdated reviewList UI design.]
• [It doesn't filter the reviews by its distance from user.]

3. Location view problem (3)

• [On reviewDetail, the location of restaurant doesn't appear.]
• [On main/location, the marker for restaurants of reviews don't appear.]
• [On reviewDetail, marker doesn't appear in the middle of maps; sometimes the marker is out of the initial map range.]

4. ReviewDetail UI problem (2)

• [On reviewDetail, It uses the outdated reviewList tag design.]
• [Better Layout is required; smaller maps, smaller pictuers, bigger and readable title, author, etc information. Don't use textarea when the user cannot edit its content.]

5. Upload Problem (3):

• [Backend problem; It appears the backend cannot handle some specific input.
  For input 'Good Good I love sour pizza. I like lemon.', the backend returns error:
  /pytorch/aten/src/ATen/native/LegacyDefinitions.cpp:19: UserWarning: masked_fill_ received a mask with dtype torch.uint8, this behavior is now deprecated,please use a mask with dtype torch.bool instead. Good Good I love sour pizza. I like lemon. Internal Server Error: /api/review/ Traceback (most recent call last): File "/home/jyeok/proj/team10/swpp2019-team10/backend/env/lib/python3.6/site-packages/django/core/handlers/exception.py", line 35, in inner response = get_response(request) File "/home/jyeok/proj/team10/swpp2019-team10/backend/env/lib/python3.6/site-packages/django/core/handlers/base.py", line 128, in _get_response response = self.process_exception_by_middleware(e, request) File "/home/jyeok/proj/team10/swpp2019-team10/backend/env/lib/python3.6/site-packages/django/core/handlers/base.py", line 126, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/usr/lib/python3.6/contextlib.py", line 52, in inner return func(*args, **kwds) File "/home/jyeok/proj/team10/swpp2019-team10/backend/foodbook/foodbook_api/views/review_views.py", line 98, in review_list tags = Tagging(request.user.profile, menu, rating).tagging(content) File "/home/jyeok/proj/team10/swpp2019-team10/backend/foodbook/foodbook_api/algorithms/tagging.py", line 147, in tagging list_of_tags = self.tagging_for_recommend(text) File "/home/jyeok/proj/team10/swpp2019-team10/backend/foodbook/foodbook_api/algorithms/tagging.py", line 185, in tagging_for_recommend if adj == tag: File "/home/jyeok/proj/team10/swpp2019-team10/backend/foodbook/foodbook_api/algorithms/tagging.py", line 211, in __eq__ return self.name.lemma == value.name.lemma and self.advmod.lemma == value.advmod.lemma AttributeError: 'NoneType' object has no attribute 'lemma']

• [When user select the place which is not a restaurant from the googleMap, execption below is thrown: Cannot read property 'includes' of undefined]

6. Recommendation view problem (3)

• [When we get reviews from recommendation, we can't see the reviewDetail of suggested restaurants.]
• [Recommendation by Location seems to broken; It doesn't show the list of restaurants.]
• [3. About taste, I cannot find the 'spicy' related keyword.]

7. Edit problem (3):

• [Edit don't works. It returns 400 Bad Request instead.]
  Fixed by @th-snu Fixed ReviewDetail Marker issue (issue #106) #108 but another problem occurs
• [After editing a review, new content is not updated until the page is refreshed.]
• [After closing the reviewDetail modal, the tag of reviewPreview in main component changes temporarily (until refresh) to default value.]

8. Main problem (3):

• [on friend's main page, the location, calendar, and category view shows the user's reviews, not the friend's reviews.]

[jaehonam]

6-2 : our recommendation by loc is within 1km, so if you have no reviews in 1km then nothing is shown. 1km is somewhat short..!
8 : I will check it

[jaehonam]

7 : At FormReview, frontend should put 'placeid' too.

[tho-kn]

fixed 3 and 7 (followed Jaeho's note)
#108

[jaehonam]

Bug

9. when Edit -> Submit -> Back, tagging is shown as default

[tho-kn]

6-1: Recommendation components don't import reviewdetail at all, I think it isn't just added