Skip to content

Commit 564f9be

Browse files
committed
Remove -Wweak-template-vtables
as it was planned for removal in clang 15 and we're now past the branch point See llvm/llvm-project#19107 Differential revision: https://reviews.llvm.org/D118762
1 parent 575a6f8 commit 564f9be

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ Modified Compiler Flags
6767
Removed Compiler Flags
6868
-------------------------
6969

70+
- -Wweak-template-vtables, which was deprecated in the previous release and no
71+
longer had any effect, has been removed.
72+
7073
New Pragmas in Clang
7174
--------------------
7275

clang/include/clang/Basic/DiagnosticSemaKinds.td

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1651,9 +1651,6 @@ def warn_weak_vtable : Warning<
16511651
"%0 has no out-of-line virtual method definitions; its vtable will be "
16521652
"emitted in every translation unit">,
16531653
InGroup<DiagGroup<"weak-vtables">>, DefaultIgnore;
1654-
def warn_weak_template_vtable : Warning<
1655-
"this warning is no longer in use and will be removed in the next release">,
1656-
InGroup<DiagGroup<"weak-template-vtables">>, DefaultIgnore;
16571654

16581655
def ext_using_undefined_std : ExtWarn<
16591656
"using directive refers to implicitly-defined namespace 'std'">;

clang/test/SemaCXX/warn-weak-vtables.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
// Check that this warning is disabled on MS ABI targets which don't have key
44
// functions.
55
// RUN: %clang_cc1 %s -fsyntax-only -triple %ms_abi_triple -Werror -Wweak-vtables
6-
//
7-
// -Wweak-template-vtables is deprecated but we still parse it.
8-
// RUN: %clang_cc1 %s -fsyntax-only -Werror -Wweak-template-vtables
96

107
struct A { // expected-warning {{'A' has no out-of-line virtual method definitions; its vtable will be emitted in every translation unit}}
118
virtual void f() { }

0 commit comments

Comments
 (0)