Skip to content

Commit 9e69959

Browse files
committed
[lldb] Adjust windows xfails for D119167
A couple of additional tests pass with that patch. One new test fails (because it's not testing a slightly different thing). I'll update it later to restore the original meaning (I don't want to revert as the net effect is still very positive), but for now this gets the bot green.
1 parent 5257efd commit 9e69959

File tree

3 files changed

+1
-12
lines changed

3 files changed

+1
-12
lines changed

lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,6 @@ def test_QListThreadsInStopReply_supported(self):
125125
context = self.expect_gdbremote_sequence()
126126
self.assertIsNotNone(context)
127127

128-
# In current implementation of llgs on Windows, as a response to '\x03' packet, the debugger
129-
# of the native process will trigger a call to DebugBreakProcess that will create a new thread
130-
# to handle the exception debug event. So one more stop thread will be notified to the
131-
# delegate, e.g. llgs. So tests below to assert the stop threads number will all fail.
132-
@expectedFailureAll(oslist=["windows"])
133128
@skipIfNetBSD
134129
def test_stop_reply_reports_multiple_threads(self):
135130
self.build()
@@ -141,7 +136,6 @@ def test_stop_reply_reports_multiple_threads(self):
141136
stop_reply_threads = self.gather_stop_reply_threads(5)
142137
self.assertEqual(len(stop_reply_threads), 5)
143138

144-
@expectedFailureAll(oslist=["windows"])
145139
@skipIfNetBSD
146140
def test_no_QListThreadsInStopReply_supplies_no_threads(self):
147141
self.build()
@@ -151,7 +145,6 @@ def test_no_QListThreadsInStopReply_supplies_no_threads(self):
151145
stop_reply_threads = self.gather_stop_reply_threads(5)
152146
self.assertEqual(len(stop_reply_threads), 0)
153147

154-
@expectedFailureAll(oslist=["windows"])
155148
@skipIfNetBSD
156149
def test_stop_reply_reports_correct_threads(self):
157150
self.build()
@@ -178,7 +171,6 @@ def test_stop_reply_reports_correct_threads(self):
178171
for tid in threads:
179172
self.assertIn(tid, stop_reply_threads)
180173

181-
@expectedFailureAll(oslist=["windows"])
182174
@skipIfNetBSD
183175
def test_stop_reply_contains_thread_pcs(self):
184176
self.build()

lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ def test_qThreadStopInfo_works_for_multiple_threads(self):
7878

7979
@expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48418")
8080
@expectedFailureNetBSD
81+
@expectedFailureAll(oslist=["windows"])
8182
def test_qThreadStopInfo_only_reports_one_thread_stop_reason_during_interrupt(self):
8283
self.build()
8384
self.set_inferior_startup_launch()

lldb/test/API/tools/lldb-server/TestLldbGdbServer.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,6 @@ def Hg_switches_to_3_threads(self, pass_pid=False):
379379
self.assertIsNotNone(context.get("thread_id"))
380380
self.assertEqual(int(context.get("thread_id"), 16), thread)
381381

382-
@expectedFailureAll(oslist=["windows"]) # expect 4 threads
383382
@skipIf(compiler="clang", compiler_version=['<', '11.0'])
384383
def test_Hg_switches_to_3_threads_launch(self):
385384
self.build()
@@ -402,21 +401,18 @@ def Hg_fails_on_pid(self, pass_pid):
402401

403402
self.expect_gdbremote_sequence()
404403

405-
@expectedFailureAll(oslist=["windows"])
406404
@add_test_categories(["llgs"])
407405
def test_Hg_fails_on_another_pid(self):
408406
self.build()
409407
self.set_inferior_startup_launch()
410408
self.Hg_fails_on_pid(1)
411409

412-
@expectedFailureAll(oslist=["windows"])
413410
@add_test_categories(["llgs"])
414411
def test_Hg_fails_on_zero_pid(self):
415412
self.build()
416413
self.set_inferior_startup_launch()
417414
self.Hg_fails_on_pid(0)
418415

419-
@expectedFailureAll(oslist=["windows"])
420416
@add_test_categories(["llgs"])
421417
def test_Hg_fails_on_minus_one_pid(self):
422418
self.build()

0 commit comments

Comments
 (0)