fix: delete will now delete the key-value (412 fix)

The 412 Precondition Failed condition `header` filter now
allows client to delete the object irrespective of the conditional
delete.

Author: sydrawat01

.eslintrc.js

@@ -19,6 +19,6 @@ module.exports = {
     'consistent-return': 'off',
     'max-classes-per-file': 'off',
     'default-param-last': 'off',
-    camelcase: 'off',
+    // camelcase: 'off',
   },
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "api",
-  "version": "1.2.0",
+  "version": "1.2.2",
   "description": "RESTful API",
   "main": "src/server.js",
   "author": "Siddharth Rawat <rawat.sid@northeastern.edu>",

src/api/controllers/plan.controller.js

@@ -102,23 +102,31 @@ const deletePlan = async (req, res, next) => {
       throw new BadRequestError(`Invalid planId`)
     }
     const value = await findPlan(planId)
-    if (value.objectId === planId) {
+    if (value !== false && value.objectId === planId) {
       // conditional delete based on `if-match` header
-      if (req.headers['if-match'] && value.ETag === req.headers['if-match']) {
-        const data = {
-          plan: JSON.parse(value.plan),
-        }
-        logger.info(`Item found`, JSON.parse(value.plan))
-        if (deleteByPlanId(planId)) {
-          logger.info(`Item deleted`, JSON.parse(value.plan))
-          noContentHandler(res, data)
+      const data = {
+        plan: JSON.parse(value.plan),
+      }
+      if (req.headers['if-match']) {
+        // if ETag matches on conditional delete
+        if (value.ETag === req.headers['if-match']) {
+          logger.info(`Item found`, JSON.parse(value.plan))
+          if (deleteByPlanId(planId)) {
+            logger.info(`Item deleted`, JSON.parse(value.plan))
+            noContentHandler(res, data)
+          } else {
+            throw new InternalServerError(`Item not deleted`)
+          }
         } else {
-          throw new InternalServerError(`Item not deleted`)
+          throw new PreConditionFailedError(
+            `ETag provided in header is not valid`
+          )
         }
+      } else if (deleteByPlanId(planId)) {
+        logger.info(`Item deleted`, JSON.parse(value.plan))
+        noContentHandler(res, data)
       } else {
-        throw new PreConditionFailedError(
-          `ETag provided in header is not valid`
-        )
+        throw new InternalServerError(`Item not deleted`)
       }
     } else {
       throw new ResourceNotFoundError(`Plan not found`)