Merge pull request #13 from sylac/develop

Develop

Author: sylac

Sylac.Mvvm.Core/Abstraction/IViewModel.cs

@@ -0,0 +1,34 @@
+namespace Sylac.Mvvm.Abstraction;
+
+public interface IViewModel
+{
+    /// <summary>
+    /// Called when the navigation to the view model is initiated.
+    /// </summary>
+    void OnNavigatingTo();
+
+    /// <summary>
+    /// Called when the navigation from the view model is initiated.
+    /// </summary>
+    void OnNavigatingFrom();
+
+    /// <summary>
+    /// Called when the navigation to the view model is completed.
+    /// </summary>
+    void OnNavigatedTo();
+
+    /// <summary>
+    /// Called when the navigation from the view model is completed.
+    /// </summary>
+    void OnNavigatedFrom();
+}
+
+public interface IViewModel<out TParam> : IViewModel
+    where TParam : IViewModelParameters
+{
+    /// <summary>
+    /// Initializes the view model with the provided parameters.
+    /// </summary>
+    /// <param name="parameter"> The parameters to initialize the view model with. </param>
+    void Initialize(IViewModelParameters parameter);
+}

Sylac.Mvvm.Core/IViewModelParameters.cs …Core/Abstraction/IViewModelParameters.csSylac.Mvvm.Core/IViewModelParameters.cs renamed to Sylac.Mvvm.Core/Abstraction/IViewModelParameters.cs Sylac.Mvvm.Core/IViewModelParameters.cs renamed to Sylac.Mvvm.Core/Abstraction/IViewModelParameters.cs

@@ -1,3 +1,3 @@
-namespace Sylac.Mvvm;
+namespace Sylac.Mvvm.Abstraction;
 
 public interface IViewModelParameters;

Sylac.Mvvm.Core/IViewModel.cs

@@ -1,4 +1,5 @@
-using System.Reactive;
+using Sylac.Mvvm.Abstraction;
+using System.Reactive;
 
 namespace Sylac.Mvvm.Navigation.Abstractions;
 

Sylac.Mvvm.Core/Navigation/Abstractions/INavigationService.cs

@@ -1,9 +1,10 @@
-namespace Sylac.Mvvm.Navigation
-{
-    [AttributeUsage(AttributeTargets.Class, Inherited = false, AllowMultiple = false)]
-    public sealed class ConnectWithViewModelAttribute<TViewModel, TParams>() : Attribute
+using Sylac.Mvvm.Abstraction;
+
+namespace Sylac.Mvvm.Navigation;
+
+[AttributeUsage(AttributeTargets.Class, Inherited = false, AllowMultiple = false)]
+public sealed class ConnectWithViewModelAttribute<TViewModel, TParams>() : Attribute
         where TViewModel : IViewModel<TParams>
         where TParams : IViewModelParameters
-    {
-    }
+{
 }

Sylac.Mvvm.Core/Navigation/ConnectWithViewModelAttribute.cs

@@ -1,10 +1,11 @@
-using Sylac.Mvvm.Navigation.Abstractions;
+using Sylac.Mvvm.Abstraction;
+using Sylac.Mvvm.Navigation.Abstractions;
 using System.Reactive;
 using System.Reactive.Linq;
 
 namespace Sylac.Mvvm.Navigation;
 
-public class NavigationService(IPlatformNavigation platformNavigation) : INavigationService
+public sealed class NavigationService(IPlatformNavigation platformNavigation) : INavigationService
 {
     private readonly IPlatformNavigation _platformNavigation = platformNavigation;
     internal static Dictionary<Type, (string Page, Type ParametersType)> ViewModelsRegistry { get; } = [];
@@ -41,33 +42,18 @@ public IObservable<Unit> NavigateTo<TViewModel, TParams>(TParams parameters)
         where TParams : IViewModelParameters
     {
         return Observable.Return(ViewModelsRegistry.GetValueOrDefault(typeof(TViewModel)))
-            .Where(result =>
-                result.Page != default &&
-                result.ParametersType != default)
+            .Where(result => result != default)
             .SelectMany(result =>
-            {
                 // is type check needed? Is it possible to pass a different type?
-                if (parameters.GetType() != result.ParametersType)
-                {
-                    return Observable.Throw<Unit>(new ArgumentException("Invalid parameters type"));
-                }
-
-                return _platformNavigation.GoTo(result.Page, new Dictionary<string, object>() { { INavigationablePage.ParametersKey, parameters } });
-            })
+                parameters.GetType() != result.ParametersType
+                    ? Observable.Throw<Unit>(new ArgumentException("Invalid parameters type"))
+                    : _platformNavigation.GoTo(result.Page, new Dictionary<string, object>() { { INavigationablePage.ParametersKey, parameters } }))
             .IsEmpty()
-            .SelectMany(isEmpty =>
-            {
-                if (isEmpty)
-                {
-                    return Observable.Throw<Unit>(new ArgumentException("Error navigating to page"));
-                }
-                return Observable.Return(Unit.Default);
-            });
+            .SelectMany(isEmpty => isEmpty
+                ? Observable.Throw<Unit>(new ArgumentException("Error navigating to page"))
+                : Observable.Return(Unit.Default));
     }
 
-    public IObservable<Unit> NavigateBack()
-    {
-        return _platformNavigation.GoTo("..");
-    }
+    public IObservable<Unit> NavigateBack() => _platformNavigation.GoTo("..");
 }
 

Sylac.Mvvm.Core/Navigation/NavigationService.cs

@@ -1,4 +1,5 @@
 using Microsoft.Extensions.DependencyInjection;
+using Sylac.Mvvm.Abstraction;
 using Sylac.Mvvm.Navigation.Abstractions;
 
 namespace Sylac.Mvvm;
@@ -14,10 +15,9 @@ public static IServiceCollection RegisterMvvmPage<TPage, TViewModel>(
     {
         services.Add(new(typeof(TPage), null, typeof(TPage), pageLifetime));
         services.Add(new(typeof(TViewModel), null, typeof(TViewModel), viewModelLifetime));
-
-        using var serviceProvider = services.BuildServiceProvider();
-        var navigetionService = serviceProvider.GetRequiredService<INavigationService>();
-        navigetionService.RegisterNavigationView<TPage, TViewModel>();
+        services.BuildServiceProvider()
+            .GetRequiredService<INavigationService>()
+            .RegisterNavigationView<TPage, TViewModel>();
 
         return services;
     }

Sylac.Mvvm.Core/RegisterMvvmPageExtensions.cs

@@ -1,27 +1,33 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
 
 		<IsPackable>true</IsPackable>
 		<PackageId>Sylac.Mvvm.Core</PackageId>
     <RootNamespace>Sylac.Mvvm</RootNamespace>
-		<Version>0.2.0</Version>
+		<Version>0.3.0</Version>
 		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <Authors>Sylwester Łach</Authors>
     <RepositoryUrl>https://github.com/sylac/Sylac.Mvvm</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
+    <PackageReadmeFile>README.md</PackageReadmeFile>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageTags>nuget, packaging, generator, example</PackageTags>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" />
+    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.0" />
     <PackageReference Include="System.Reactive" Version="6.0.1" />
   </ItemGroup>
-  
+
+  <ItemGroup>
+    <None Include="..\README.md" Pack="true" PackagePath="\"/>
+  </ItemGroup>
+
   <ItemGroup>
     <InternalsVisibleTo Include="Sylac.Mvvm.UnitTests" />
   </ItemGroup>

Sylac.Mvvm.Core/Sylac.Mvvm.Core.csproj

@@ -19,7 +19,7 @@ insert_final_newline = false
 
 # Organize usings
 dotnet_separate_import_directive_groups = false
-dotnet_sort_system_directives_first = false
+dotnet_sort_system_directives_first = true
 file_header_template = unset
 
 # this. and Me. preferences

Sylac.Mvvm.Example/.editorconfig

@@ -5,8 +5,11 @@ public partial class App : Application
         public App()
         {
             InitializeComponent();
+        }
 
-            MainPage = new AppShell();
+        protected override Window CreateWindow(IActivationState? activationState)
+        {
+            return new(new AppShell());
         }
     }
 }