Skip to content

Commit 205a31a

Browse files
committed
Sync encoding code
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
1 parent 3f565ea commit 205a31a

File tree

3 files changed

+22
-17
lines changed

3 files changed

+22
-17
lines changed

cmd/decrypt/decrypt.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -193,21 +193,23 @@ func DecryptYAML(keys []string, in io.Reader, out io.Writer, stdinInUse, noTag b
193193
decoder := yaml.NewDecoder(in)
194194
encoder := yaml.NewEncoder(out)
195195
encoder.SetIndent(2)
196-
defer encoder.Close()
196+
encoder.CompactSeqIndent()
197197

198198
for {
199-
err := decoder.Decode(&w)
200-
if err == io.EOF {
199+
if err := decoder.Decode(&w); err == io.EOF {
201200
break
202201
} else if err != nil {
203-
return err
202+
return fmt.Errorf("yaml decoding failed: %w", err)
204203
}
205204

206-
err = encoder.Encode(&node)
207-
if err != nil {
208-
return err
205+
if err := encoder.Encode(&w); err != nil {
206+
return fmt.Errorf("yaml encoding failed: %w", err)
209207
}
210208
}
211209

210+
if err := encoder.Close(); err != nil {
211+
return fmt.Errorf("yaml encoding close failed: %w", err)
212+
}
213+
212214
return nil
213215
}

cmd/encrypt/encrypt.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -289,21 +289,22 @@ func EncryptYAML(recipients []age.Recipient, in io.Reader, out io.Writer) error
289289
encoder := yaml.NewEncoder(out)
290290
encoder.SetIndent(2)
291291
encoder.CompactSeqIndent()
292-
defer encoder.Close()
293292

294293
for {
295-
err := decoder.Decode(&w)
296-
if err == io.EOF {
294+
if err := decoder.Decode(&w); err == io.EOF {
297295
break
298296
} else if err != nil {
299297
return fmt.Errorf("yaml decoding failed: %w", err)
300298
}
301299

302-
err = encoder.Encode(&w)
303-
if err != nil {
300+
if err := encoder.Encode(&w); err != nil {
304301
return fmt.Errorf("yaml encoding failed: %w", err)
305302
}
306303
}
307304

305+
if err := encoder.Close(); err != nil {
306+
return fmt.Errorf("yaml encoding close failed: %w", err)
307+
}
308+
308309
return nil
309310
}

cmd/rekey/rekey.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -300,21 +300,23 @@ func EncryptYAML(recipients []age.Recipient, in io.Reader, out io.Writer) error
300300
decoder := yaml.NewDecoder(in)
301301
encoder := yaml.NewEncoder(out)
302302
encoder.SetIndent(2)
303-
defer encoder.Close()
303+
encoder.CompactSeqIndent()
304304

305305
for {
306-
err := decoder.Decode(&w)
307-
if err == io.EOF {
306+
if err := decoder.Decode(&w); err == io.EOF {
308307
break
309308
} else if err != nil {
310309
return fmt.Errorf("yaml decoding failed: %w", err)
311310
}
312311

313-
err = encoder.Encode(&w)
314-
if err != nil {
312+
if err := encoder.Encode(&w); err != nil {
315313
return fmt.Errorf("yaml encoding failed: %w", err)
316314
}
317315
}
318316

317+
if err := encoder.Close(); err != nil {
318+
return fmt.Errorf("yaml encoding close failed: %w", err)
319+
}
320+
319321
return nil
320322
}

0 commit comments

Comments
 (0)