typos; init constant

Author: jverzani

src/mathfuns.jl

@@ -101,8 +101,8 @@ for (meth, libnm, modu) in [
     IMPLEMENT_TWO_ARG_FUNC(modu, meth, libnm)
 end
 
-const TWO = Basic(2)
 function abs2!(a::Basic, x::Basic)
+    TWO = Basic(2) # put in init
     a = abs!(a, x)
     a = pow!(a, x, TWO)
     a

src/mathops.jl

@@ -47,7 +47,7 @@ function sum!(a::Basic, v::CVecBasic)
 end
 function sum(v::CVecBasic)
     a = Basic()
-    sum!(a, b)
+    sum!(a, v)
 end
 
 +(b1::Basic, b2::Basic, b3::Basic, bs...) = sum(convert(CVecBasic, [b1, b2, b3, bs...]))
@@ -67,7 +67,7 @@ function prod!(a::Basic, v::CVecBasic)
 end
 function prod(v::CVecBasic)
     a = Basic()
-    prod!(a, b)
+    prod!(a, v)
 end
 
 *(b1::Basic, b2::Basic, b3::Basic, bs::Vararg{Number, N}) where {N} = prod(convert(CVecBasic, [b1, b2, b3, bs...]))

test/runtests.jl

@@ -356,20 +356,19 @@ end
 end
 
 @vars a x y
-@testset "non-allocating methods" begin
+@testset "non-allocating(ish) methods" begin
     SymEngine.sin!(a,x); SymEngine.cos!(a,x); SymEngine.abs!(a,x)
     SymEngine.pow!(a,x,x);
     SymEngine.add!(a,x,x);SymEngine.mul!(a,x,x)
     SymEngine.sub!(a,x,x);SymEngine.div!(a,x,x)
     @test (@allocations SymEngine.sin!(a,x)) == 0
     @test (@allocations SymEngine.cos!(a,x)) == 0
-    @test (@allocations SymEngine.abs2!(a,x)) == 0
     @test (@allocations SymEngine.pow!(a,x,x)) == 0
 
     # still allocates 1 (or 2)
     @test (@allocations SymEngine.add!(a,x,y)) < (@allocations x+y)
     @test (@allocations SymEngine.sub!(a,x,y)) < (@allocations x-y)
     @test (@allocations SymEngine.mul!(a,x,y)) < (@allocations x*y)
     @test (@allocations SymEngine.div!(a,x,y)) < (@allocations x/y)
-
+    @test (@allocations SymEngine.abs2!(a,x)) < (@allocations abs2(x))
 end