Skip to content

Commit 0e2f8a3

Browse files
authored
Merge pull request #358 from isuruf/LU
Throw if matrix is non-square
2 parents db5ea46 + 4dce246 commit 0e2f8a3

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

symengine/lib/symengine_wrapper.pyx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3679,6 +3679,8 @@ cdef class DenseMatrixBase(MatrixBase):
36793679
return L, U
36803680

36813681
def LUdecomposition(self):
3682+
if self.rows != self.cols:
3683+
raise NotImplementedError("LU decomposition not implemented for non-square matrices yet.")
36823684
cdef DenseMatrixBase L = self.__class__(self.nrows(), self.ncols())
36833685
cdef DenseMatrixBase U = self.__class__(self.nrows(), self.ncols())
36843686
cdef vector[pair[int, int]] perm

0 commit comments

Comments
 (0)