Add is_positive_definite and is_negative_definite

Author: rikardn

symengine/lib/symengine.pxd

@@ -827,6 +827,8 @@ cdef extern from "<symengine/matrix.h>" namespace "SymEngine":
         int is_hermitian() nogil
         int is_weakly_diagonally_dominant() nogil
         int is_strictly_diagonally_dominant() nogil
+        int is_positive_definite() nogil
+        int is_negative_definite() nogil
 
     bool is_a_DenseMatrix "SymEngine::is_a<SymEngine::DenseMatrix>"(const MatrixBase &b) nogil
     DenseMatrix* static_cast_DenseMatrix "static_cast<SymEngine::DenseMatrix*>"(const MatrixBase *a)

symengine/lib/symengine_wrapper.pyx

@@ -3627,6 +3627,14 @@ cdef class DenseMatrixBase(MatrixBase):
     def is_strongly_diagonally_dominant(self):
         return tribool(deref(symengine.static_cast_DenseMatrix(self.thisptr)).is_strictly_diagonally_dominant())
 
+    @property
+    def is_positive_definite(self):
+        return tribool(deref(symengine.static_cast_DenseMatrix(self.thisptr)).is_positive_definite())
+
+    @property
+    def is_negative_definite(self):
+        return tribool(deref(symengine.static_cast_DenseMatrix(self.thisptr)).is_negative_definite())
+
     @property
     def T(self):
         return self.transpose()

symengine/tests/test_matrices.py

@@ -385,6 +385,20 @@ def test_is_strongly_diagonally_dominant():
     assert C.is_strongly_diagonally_dominant is None
 
 
+def test_is_positive_definite():
+    A = DenseMatrix(2, 2, [2, 1, 1, 2])
+    assert A.is_positive_definite
+    C = DenseMatrix(3, 3, [Symbol('x'), 2, 0, 0, 4, 0, 0, 0, 4])
+    assert C.is_positive_definite is None
+
+
+def test_is_negative_definite():
+    A = DenseMatrix(2, 2, [-2, -1, -1, -2])
+    assert A.is_negative_definite
+    C = DenseMatrix(3, 3, [Symbol('x'), -2, 0, 0, -4, 0, 0, 0, -4])
+    assert C.is_negative_definite is None
+
+
 def test_LU():
     A = DenseMatrix(3, 3, [1, 3, 5, 2, 5, 6, 8, 3, 1])
     L, U = A.LU()

symengine_version.txt

@@ -1 +1 @@
-44eb47e3bbfa7e06718f2f65f3f41a0a9d133b70
+41e9689c9ee4d383d09dcd0e352b46185d18c4f4