Skip to content

Commit e05581d

Browse files
authored
Merge pull request #277 from isuruf/sets
Use sympy.S.EmptySet as sympy.EmptySet will change
2 parents d004a12 + 4a96a01 commit e05581d

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

symengine/lib/symengine_wrapper.pyx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,8 +427,10 @@ def sympy2symengine(a, raise_error=False):
427427
return piecewise(*(a.args))
428428
elif isinstance(a, sympy.Interval):
429429
return interval(*(a.args))
430-
elif isinstance(a, sympy.EmptySet):
430+
elif a == sympy.S.EmptySet:
431431
return emptyset()
432+
elif a == sympy.S.UniversalSet:
433+
return universalset()
432434
elif isinstance(a, sympy.FiniteSet):
433435
return finiteset(*(a.args))
434436
elif isinstance(a, sympy.Contains):
@@ -2923,7 +2925,7 @@ class EmptySet(Set):
29232925

29242926
def _sympy_(self):
29252927
import sympy
2926-
return sympy.EmptySet()
2928+
return sympy.S.EmptySet
29272929

29282930
@property
29292931
def func(self):

symengine/tests/test_sympy_conv.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
KroneckerDelta, LeviCivita, erf, erfc, lowergamma, uppergamma,
1010
loggamma, beta, polygamma, sign, floor, ceiling, conjugate, And,
1111
Or, Not, Xor, Piecewise, Interval, EmptySet, FiniteSet, Contains,
12-
Union, Complement)
12+
Union, Complement, UniversalSet)
1313
import unittest
1414

1515
# Note: We test _sympy_() for SymEngine -> SymPy conversion, as those are
@@ -703,8 +703,11 @@ def test_sets():
703703
assert Interval(x, y)._sympy_() == sympy.Interval(x1, y1)
704704
assert sympify(sympy.Interval(x1, y1)) == Interval(x, y)
705705

706-
assert sympify(sympy.EmptySet()) == EmptySet()
707-
assert sympy.EmptySet() == EmptySet()._sympy_()
706+
assert sympify(sympy.S.EmptySet) == EmptySet()
707+
assert sympy.S.EmptySet == EmptySet()._sympy_()
708+
709+
assert sympify(sympy.S.UniversalSet) == UniversalSet()
710+
assert sympy.S.UniversalSet == UniversalSet()._sympy_()
708711

709712
assert FiniteSet(x, y) == FiniteSet(x1, y1)
710713
assert FiniteSet(x1, y) == FiniteSet(x1, y1)

0 commit comments

Comments
 (0)