Skip to content

Commit e9aec56

Browse files
committed
Address first round comments.
1 parent c608ea2 commit e9aec56

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

symengine/lib/symengine_wrapper.pyx

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ def get_dict(*args):
387387
return D
388388

389389

390-
cdef tuple vec_basic_to_tuple(symengine.vec_basic vec):
390+
cdef tuple vec_basic_to_tuple(symengine.vec_basic& vec):
391391
result = []
392392
for i in range(vec.size()):
393393
result.append(c2py(<RCP[const symengine.Basic]>(vec[i])))
@@ -1321,7 +1321,8 @@ cdef class Derivative(Basic):
13211321

13221322
@property
13231323
def expr(self):
1324-
return self.args[0]
1324+
cdef RCP[const symengine.Derivative] X = symengine.rcp_static_cast_Derivative(self.thisptr)
1325+
return c2py(deref(X).get_arg())
13251326

13261327
@property
13271328
def variables(self):
@@ -1376,17 +1377,20 @@ cdef class Subs(Basic):
13761377

13771378
@property
13781379
def expr(self):
1379-
return self.args[0]
1380+
cdef RCP[const symengine.Subs] me = symengine.rcp_static_cast_Subs(self.thisptr)
1381+
return c2py(deref(me).get_arg())
13801382

13811383
@property
13821384
def variables(self):
13831385
cdef RCP[const symengine.Subs] me = symengine.rcp_static_cast_Subs(self.thisptr)
1384-
return vec_basic_to_tuple(deref(me).get_variables())
1386+
cdef symengine.vec_basic variables = deref(me).get_variables()
1387+
return vec_basic_to_tuple(variables)
13851388

13861389
@property
13871390
def point(self):
13881391
cdef RCP[const symengine.Subs] me = symengine.rcp_static_cast_Subs(self.thisptr)
1389-
return vec_basic_to_tuple(deref(me).get_point())
1392+
cdef symengine.vec_basic point = deref(me).get_point()
1393+
return vec_basic_to_tuple(point)
13901394

13911395
def _sympy_(self):
13921396
cdef RCP[const symengine.Subs] X = symengine.rcp_static_cast_Subs(self.thisptr)

0 commit comments

Comments
 (0)