Skip to content

Commit ea1b771

Browse files
authored
Merge pull request #350 from rikardn/fix347
Properly handle sympy matrix for Matrix constructor
2 parents 64ddd71 + 803d00b commit ea1b771

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

symengine/lib/symengine_wrapper.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3170,7 +3170,7 @@ cdef class DenseMatrixBase(MatrixBase):
31703170
self.thisptr = new symengine.DenseMatrix(row, col)
31713171
return
31723172
if col is None:
3173-
v = row
3173+
v = sympify(row)
31743174
row = 0
31753175
cdef symengine.vec_basic v_
31763176
cdef DenseMatrixBase A

symengine/tests/test_sympy_conv.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -783,3 +783,12 @@ def test_pynumber():
783783

784784
b = b / x
785785
assert isinstance(b, PyNumber)
786+
787+
788+
@unittest.skipIf(not have_sympy, "SymPy not installed")
789+
def test_construct_dense_matrix():
790+
# Test for issue #347
791+
A = sympy.Matrix([[1, 2], [3, 5]])
792+
B = DenseMatrix(A)
793+
assert B.shape == (2, 2)
794+
assert list(B) == [1, 2, 3, 5]

0 commit comments

Comments
 (0)