refactor, Move code for retrieving a test template from Symflower into a helper

Author: ahumenberger

evaluate/task/write-test.go

@@ -120,28 +120,17 @@ func (t *WriteTests) Run(ctx evaltask.Context) (repositoryAssessment map[string]
 			ctx.Logger.Panicf("ERROR: unable to reset temporary repository path: %s", err)
 		}
 
-		_, err = symflowerTemplate(taskLogger.Logger, dataPath, ctx.Language, filePath) // TODO Incorporate template processing time. https://github.com/symflower/eval-dev-quality/issues/350
+		testTemplate, err := symflowerTemplateAsString(ctx, taskLogger, dataPath, filePath)
 		if err != nil {
-			problems = append(problems, pkgerrors.WithMessage(err, "generating Symflower template"))
+			problems = append(problems, err)
 
 			withSymflowerTemplateAssessment.Add(modelAssessmentFile)
 			withSymflowerTemplateAndFixAssessment.Add(withSymflowerFixAssessmentFile)
 
 			continue
 		}
 
-		testTemplateFilePath := filepath.Join(dataPath, ctx.Language.TestFilePath(dataPath, filePath))
-		testTemplate, err := os.ReadFile(testTemplateFilePath)
-		if err != nil {
-			problems = append(problems, pkgerrors.WithMessagef(err, "reading Symflower template from %q", testTemplateFilePath))
-
-			withSymflowerTemplateAssessment.Add(modelAssessmentFile)
-			withSymflowerTemplateAndFixAssessment.Add(withSymflowerFixAssessmentFile)
-
-			continue
-		}
-
-		arguments.Template = string(testTemplate)
+		arguments.Template = testTemplate
 		modelTemplateAssessmentFile, templateWithSymflowerFixAssessmentFile, ps, err := runModelAndSymflowerFix(ctx, modelContext, modelCapability.WriteTests)
 		problems = append(problems, ps...)
 		if err != nil {
@@ -155,6 +144,20 @@ func (t *WriteTests) Run(ctx evaltask.Context) (repositoryAssessment map[string]
 	return repositoryAssessment, problems, nil
 }
 
+func symflowerTemplateAsString(ctx evaltask.Context, taskLogger *taskLogger, dataPath string, filePath string) (testTemplate string, err error) {
+	_, err = symflowerTemplate(taskLogger.Logger, dataPath, ctx.Language, filePath) // TODO Incorporate template processing time. https://github.com/symflower/eval-dev-quality/issues/350
+	if err != nil {
+		return "", pkgerrors.WithMessage(err, "generating Symflower template")
+	}
+	testTemplateFilePath := filepath.Join(dataPath, ctx.Language.TestFilePath(dataPath, filePath))
+	testTemplateData, err := os.ReadFile(testTemplateFilePath)
+	if err != nil {
+		return "", pkgerrors.WithMessagef(err, "reading Symflower template from %q", testTemplateFilePath)
+	}
+
+	return string(testTemplateData), nil
+}
+
 // validateWriteTestsRepository checks if the repository for the "write-tests" task is well-formed.
 func validateWriteTestsRepository(logger *log.Logger, repositoryPath string, language language.Language) (err error) {
 	logger.Info("validating repository", "path", repositoryPath)