fix, Do not allow total tests to be negative for Go

Seems that Go 1.23 has different behavior for test execution reporting.

Author: zimmski

evaluate/task/symflower.go

@@ -59,7 +59,7 @@ func symflowerTemplate(logger *log.Logger, repositoryPath string, language langu
 // ExecuteWithSymflowerFix runs the "symflower fix" command and calculates the new assessments.
 func ExecuteWithSymflowerFix(ctx evaltask.Context, logger *log.Logger, packagePath string) (testResult *language.TestResult, processingTime uint64, problems []error, err error) {
 	// Run "symflower fix"  if the model response fails to execute.
-	logger.Info("model response alone failed execution, attempting to fix with \"symflower fix \"")
+	logger.Info("model response alone failed execution, attempting to fix with \"symflower fix\"")
 
 	duration, err := symflowerFix(logger, packagePath, ctx.Language)
 	if err != nil {

language/golang/language.go

@@ -140,6 +140,9 @@ func parseSymflowerTestOutput(data string) (testsTotal int, testsPass int, err e
 		}
 	}
 	testsPass = testsTotal - testsFail
+	if testsPass < 0 { // Go does not count tests on syntax errors, but marks it as a failing test. This results in total tests 0 minus failing tess 1, hence, -1. Passing tests should be always >=0.
+		testsPass = 0
+	}
 
 	return testsTotal, testsPass, nil
 }

language/golang/language_test.go

@@ -305,4 +305,27 @@ func TestParseSymflowerTestOutput(t *testing.T) {
 		ExpectedTestsTotal: 6,
 		ExpectedTestsPass:  4,
 	})
+	validate(t, &testCase{
+		Name: "Tests with syntax error in implementation (Go >=1.23)",
+
+		Data: `
+			# cascadingIfElse [cascadingIfElse.test]
+			./cascadingIfElse.go:3:8: "strings" imported and not used
+			FAIL    cascadingIfElse [build failed]
+
+			=== Failed
+			=== FAIL: .  (0.00s)
+			FAIL    cascadingIfElse [build failed]
+
+			=== Errors
+			./cascadingIfElse.go:3:8: "strings" imported and not used
+
+			DONE 0 tests, 1 failure, 1 error in 0.117s
+			Give us your feedback and let us know how we can improve Symflower at [email protected] or https://github.com/symflower/symflower. Thanks so much for your help!
+			ERROR: execution failed: exit status 1
+		`,
+
+		ExpectedTestsTotal: 0,
+		ExpectedTestsPass:  0,
+	})
 }