Merge pull request #416 from symflower/415-svg-renderer

Replace "Inkscape" with "svgexport"

Author: ahumenberger

.github/workflows/job-container-image-build.yml

@@ -42,3 +42,22 @@ jobs:
           push: true
           cache-from: type=gha
           cache-to: type=gha,mode=max
+
+  test:
+    runs-on: ubuntu-latest
+    needs: docker
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Run tests from Docker image
+        run: |
+          output=$(docker run -v ./docs:/app/svg --user $(id -u):1000 --rm ghcr.io/symflower/eval-dev-quality:${GITHUB_SHA::7} svgexport /app/svg/cta.svg /app/svg/cta.png)
+
+          expected="/app/svg/cta.svg /app/svg/cta.png png 100% 1x 0:0:1920:400 1920:400"
+          if [ "$output" == "$expected" ]; then
+            exit 0
+          else
+            exit 1
+          fi

Dockerfile

@@ -12,18 +12,44 @@ RUN CGO_ENABLED=0 go build -o eval-dev-quality ./cmd/eval-dev-quality
 FROM ubuntu:noble
 RUN apt-get update && \
 	apt-get install -y \
+	--no-install-recommends \
 	ca-certificates \
 	gcc \
 	git \
+	imagemagick \
+	libappindicator3-1 \
+	libasound2-data \
+	libasound2-plugins \
+	libatk-bridge2.0-0 \
+	libatk1.0-0 \
+	libdrm2 \
+	libgbm1 \
+	libgtk-3-0 \
+	libnss3 \
 	libssl-dev \
 	libtool \
+	libx11-6 \
+	libx11-xcb1 \
+	libxcb-dri3-0 \
+	libxss1 \
+	libxtst6 \
 	libyaml-dev \
 	make \
+	nodejs \
+	npm \
+	pngcrush \
 	unzip \
 	wget \
 	zlib1g-dev \
 	&& update-ca-certificates
 
+# Install "Chrome for testing" as puppeteer requirement.
+RUN wget https://storage.googleapis.com/chrome-for-testing-public/133.0.6943.53/linux64/chrome-linux64.zip -O /tmp/chrome-linux64.zip && \
+	mkdir -p /opt/chrome && \
+	unzip /tmp/chrome-linux64.zip -d /opt/chrome && \
+	rm /tmp/chrome-linux64.zip
+ENV PATH="${PATH}:/opt/chrome/chrome-linux64"
+
 # Switch to the ubuntu user as we want it to run as non-root.
 USER ubuntu
 WORKDIR /app
@@ -32,7 +58,7 @@ COPY --chown=ubuntu:ubuntu ./Makefile ./Makefile
 RUN mkdir -p .eval-dev-quality
 RUN mkdir -p /app/evaluation
 
-# Install Ruby
+# Install Ruby.
 RUN mkdir -p /tmp/compile
 RUN wget https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz && \
 	tar -xf ruby-3.3.4.tar.gz -C /tmp/compile/ && \
@@ -44,34 +70,42 @@ WORKDIR /app
 RUN rm -rf /tmp/compile
 ENV PATH="${PATH}:/app/.eval-dev-quality/ruby-3.3.4/bin"
 
-# Install Maven
+# Install Maven.
 RUN wget https://archive.apache.org/dist/maven/maven-3/3.9.1/binaries/apache-maven-3.9.1-bin.tar.gz && \
 	tar -xf apache-maven-3.9.1-bin.tar.gz -C /app/.eval-dev-quality/ && \
 	rm apache-maven-3.9.1-bin.tar.gz
 ENV PATH="${PATH}:/app/.eval-dev-quality/apache-maven-3.9.1/bin"
 
-# Install Gradle
+# Install Gradle.
 RUN wget https://services.gradle.org/distributions/gradle-8.0.2-bin.zip && \
 	unzip gradle-8.0.2-bin.zip -d /app/.eval-dev-quality/ && \
 	rm gradle-8.0.2-bin.zip
 ENV PATH="${PATH}:/app/.eval-dev-quality/gradle-8.0.2/bin"
 
-# Install Java
+# Install Java.
 RUN wget https://corretto.aws/downloads/resources/11.0.24.8.1/amazon-corretto-11.0.24.8.1-linux-x64.tar.gz && \
 	tar -xf amazon-corretto-11.0.24.8.1-linux-x64.tar.gz -C /app/.eval-dev-quality/ && \
 	rm amazon-corretto-11.0.24.8.1-linux-x64.tar.gz
 ENV JAVA_HOME="/app/.eval-dev-quality/amazon-corretto-11.0.24.8.1-linux-x64"
 ENV PATH="${PATH}:${JAVA_HOME}/bin"
 
-# Install Go
+# Install Go.
 RUN wget https://go.dev/dl/go1.23.6.linux-amd64.tar.gz && \
 	tar -xf go1.23.6.linux-amd64.tar.gz -C /app/.eval-dev-quality/ && \
 	rm go1.23.6.linux-amd64.tar.gz
 ENV PATH="${PATH}:/app/.eval-dev-quality/go/bin"
 ENV GOROOT="/app/.eval-dev-quality/go"
 ENV PATH="${PATH}:/home/ubuntu/go/bin"
 
-# Install the binary
+# Setup NPM global store in User space and install NPM packages.
+ENV NPM_CONFIG_PREFIX=/home/ubuntu/.npm-global
+ENV PATH="${PATH}:/home/ubuntu/.npm-global/bin"
+RUN npm install svgexport -g
+
+# Only use a single process for the puppeteer chrome instance to avoid memory issues in containerized environments.
+RUN sed -i "s/args: \[\(.*\)\]/args: [\1, '--single-process']/" /home/ubuntu/.npm-global/lib/node_modules/svgexport/render.js
+
+# Install the binary.
 COPY --from=builder --chown=ubuntu:ubuntu /app/eval-dev-quality /app/.eval-dev-quality/bin/
 ENV PATH="${PATH}:/app/.eval-dev-quality/bin"
 RUN make install-tools-testing