Add generator param type check

Author: acrobat

src/ChainRouter.php

@@ -217,6 +217,10 @@ private function doMatch($pathinfo, Request $request = null)
      */
     public function generate($name, $parameters = [], $absolute = UrlGeneratorInterface::ABSOLUTE_PATH): string
     {
+        if (!is_string($name)) {
+            throw new \InvalidArgumentException('The "$name" parameter should of type string.');
+        }
+
         $debug = [];
 
         foreach ($this->all() as $router) {

src/ContentAwareGenerator.php

@@ -65,6 +65,10 @@ public function setContentRepository(ContentRepositoryInterface $contentReposito
      */
     public function generate($name, $parameters = [], $absolute = UrlGeneratorInterface::ABSOLUTE_PATH): string
     {
+        if (!is_string($name)) {
+            throw new \InvalidArgumentException('The "$name" parameter should of type string.');
+        }
+
         if (RouteObjectInterface::OBJECT_BASED_ROUTE_NAME === $name) {
             if (array_key_exists(RouteObjectInterface::ROUTE_OBJECT, $parameters)
                 && $parameters[RouteObjectInterface::ROUTE_OBJECT] instanceof SymfonyRoute

src/DynamicRouter.php

@@ -165,6 +165,10 @@ public function getGenerator()
      */
     public function generate($name, $parameters = [], $referenceType = UrlGeneratorInterface::ABSOLUTE_PATH): string
     {
+        if (!is_string($name)) {
+            throw new \InvalidArgumentException('The "$name" parameter should of type string.');
+        }
+
         if ($this->eventDispatcher) {
             $event = new RouterGenerateEvent($name, $parameters, $referenceType);
             $this->eventDispatcher->dispatch($event, Events::PRE_DYNAMIC_GENERATE);

src/ProviderBasedGenerator.php

@@ -46,6 +46,10 @@ public function __construct(RouteProviderInterface $provider, LoggerInterface $l
      */
     public function generate($name, $parameters = [], $referenceType = self::ABSOLUTE_PATH): string
     {
+        if (!is_string($name)) {
+            throw new \InvalidArgumentException('The "$name" parameter should of type string.');
+        }
+
         if (RouteObjectInterface::OBJECT_BASED_ROUTE_NAME === $name
             && array_key_exists(RouteObjectInterface::ROUTE_OBJECT, $parameters)
             && $parameters[RouteObjectInterface::ROUTE_OBJECT] instanceof SymfonyRoute

tests/Unit/Routing/ChainRouterTest.php

@@ -709,6 +709,23 @@ public function testRouteCollection()
         $this->assertEquals(['high', 'low'], $names);
     }
 
+    public function testGenerateWithNameParameterObject()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $parameters = ['test' => 'value'];
+        $defaultRouter = $this->createMock(RouterInterface::class);
+
+        $defaultRouter
+            ->expects($this->never())
+            ->method('generate')
+        ;
+
+        $this->router->add($defaultRouter, 200);
+
+        $this->router->generate(new \stdClass(), $parameters);
+    }
+
     /**
      * @group legacy
      */

tests/Unit/Routing/ContentAwareGeneratorTest.php

@@ -507,6 +507,13 @@ public function testGetRouteDebugMessageLegacy(): void
         $this->assertStringContainsString('Route aware content Symfony\Cmf\Component\Routing\Tests\Routing\RouteAware', $this->generator->getRouteDebugMessage(new RouteAware()));
         $this->assertStringContainsString('/some/content', $this->generator->getRouteDebugMessage('/some/content'));
     }
+
+    public function testGenerateWithNameParameterObject(): void
+    {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->generator->generate(new \stdClass());
+    }
 }
 
 /**

tests/Unit/Routing/ProviderBasedGeneratorTest.php

@@ -155,6 +155,13 @@ public function testGenerateByRoute(): void
             'number' => 'string',
         ]);
     }
+
+    public function testGenerateWithNameParameterObject(): void
+    {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->generator->generate(new \stdClass());
+    }
 }
 
 /**