cleanup error handling in generate

Author: dbu

ChainRouter.php

@@ -201,12 +201,6 @@ public function generate($name, $parameters = array(), $absolute = false)
     {
         $debug = array();
 
-        if (is_object($name)) {
-            $displayName = get_class($name);
-        } else {
-            $displayName = $name;
-        }
-
         foreach ($this->all() as $router) {
             // if $router does not implement ChainedRouterInterface and $name is not a string, continue
             if ($name && !$router instanceof ChainedRouterInterface) {
@@ -223,9 +217,7 @@ public function generate($name, $parameters = array(), $absolute = false)
             try {
                 return $router->generate($name, $parameters, $absolute);
             } catch (RouteNotFoundException $e) {
-                $hint = ($router instanceof VersatileGeneratorInterface)
-                    ? $router->getRouteDebugMessage($name, $parameters)
-                    : "Route '$displayName' not found";
+                $hint = $this->getErrorMessage($name, $router, $parameters);
                 $debug[] = $hint;
                 if ($this->logger) {
                     $this->logger->info('Router '.get_class($router)." was unable to generate route. Reason: '$hint': ".$e->getMessage());
@@ -237,12 +229,28 @@ public function generate($name, $parameters = array(), $absolute = false)
             $debug = array_unique($debug);
             $info = implode(', ', $debug);
         } else {
-            $info = "No route '$displayName' found";
+            $info = $this->getErrorMessage($name);
         }
 
         throw new RouteNotFoundException(sprintf('None of the chained routers were able to generate route: %s', $info));
     }
 
+    private function getErrorMessage($name, $router = null, $parameters = null)
+    {
+        if ($router instanceof VersatileGeneratorInterface) {
+            $displayName = $router->getRouteDebugMessage($name, $parameters);
+        } elseif (is_object($name)) {
+            $displayName = method_exists($name, '__toString')
+                ? (string) $name
+                : get_class($name)
+            ;
+        } else {
+            $displayName = (string) $name;
+        }
+
+        return "Route '$displayName' not found";
+    }
+
     /**
      * {@inheritdoc}
      */