Create content_on_method enhancer

[ElectricMaxxx]

To map REST routes (and other use cases) we need an enhancer for to map on controller methods based on the HTTP method.

The related discussion can be found: here There is also an example implementation mentioned or can be found here

The enhancer should be available in the bundle too.

[dbu]

we need to find a better name. `content_on_method` would suggest that you add different content based on the request method. but what you want to do, if i get it correctly, is an enhancer that selects the controller based on the content class and the method. this sounds like being able to have more than one controllers_by_class, limited to methods. the normal controllers_by_class is handled by [FieldByClassEnhancer](https://github.com/symfony-cmf/Routing/blob/master/Enhancer/FieldByClassEnhancer.php). we could create a MethodConditionalEnhancer that wraps another enhancer and only triggers that if the request method is in the list of methods that was specified. for the bundle configuration, we would have to think of a way to add methods to controller_by_class and have several controller_by_class.

[ElectricMaxxx]

That sounds like a plan. In general this enhancer would easily add the [method]Action to a given controller as a a service key. The _content isn't touched and should be set on the usual way. So controller_by_class mapping sounds right. Would have one problem: doing it they way described above i would expect to have controllers implementing all methods - a kind of a CRUD (Rest) all in one solution. But i think it would he better to expect a controller implementing the methods the user whants to serve. Means implement Interfaces devided by methods (RestPostAwareController, RestDeleteAwareController, ...). implenting the Controller Class and checking the interface in the enhancer is to expensive for the routing - i think. You have got any idea for that?

[dbu]

i would not do any magic. if people want magic method names, they hopefully use FOSRestBundle which does that nicely. i would simply add that mapper, and allow explicit configuration of controller_by_class that is limited by method. then people can map however they need to.

[ElectricMaxxx]

Doing so i would add some configuration options combined with Service definitions based on field_by_class enhancer in the bundle only? I would lose the the http method Information. But that would mean to configure each http method i whant to Support for each content Class i what to support.

[ElectricMaxxx]

I could add a list of controller:[method]Action pairs per content class.

[dbu]

i would make the configuration something like

controller_by_class:
    My\Class:
        -
            methods: [put, post]
            controller: service:method
        -
            controller: service:readMethod
    Other\Class: service:method

so if the value of Other\Class is not a string but an array, it needs to be a list of subsets, the last of them can omit the methods filter to match everything that remains.

if you want complete automatic naming, you can use FOSRestBundle instead (and also customize methods and what not). or am i missing something that FOSRestBundle can not do that we would need with the CMF?

[ElectricMaxxx]

That looks cool and sounds right. I just need to get the configuration to that point. BundleExtension and enhancer should be no problem. I don't think we need FosRest for the routing. But we will do when building the Controller in the ContentBundle to get the REST support there.

[dbu]

the rest bundle is just my argument why we should not try to do a lot of automatic model + method to controller action mapping ;-)

[ElectricMaxxx]

So is there a chance to create an Enhancer, which would use FosRest Magic for that mapping? The only Routing i usualy do by FosRest is the Anotation one.

[dbu]

i have no complete overview of what FOSRest can do, but afaik its a lot about annotations. there is quite some doc in the symfony docs: http://symfony.com/doc/current/bundles/FOSRestBundle/index.html i am not sure what an enhancer could do with fos rest. fos rest is generating "static" route definitions based on naming schemes. the cmf is mapping paths from a database and objects. for a rest api you can either use what we discussed above with controller_by_class per method (if you want to edit content at the seo friendly paths) or use the FOSRest approach with resource name patterns. how would you imagine mixing those two?

[ElectricMaxxx]

I currently have no idea how to merge those both behaviors. So i will implement it our way. I will start on it on my "empty" RestBundle, where i implemented the Former content_by_method too. I will separate the code on routing component and bundle afterwards, when it works. It is easier to work on component and bundle parts together for me.

[wouterj]

I can help with the configuration btw :)

[ElectricMaxxx]

Uhh nice. That sounds even better. @wouterj You have an example for me? But i think yours should be closer to the original one.