BC BREAK: remove deprecated method legacy support, use getFrameworkBundleClient instead

Author: dbu

CHANGELOG.md

@@ -4,6 +4,7 @@ Changelog
 3.0.0 (unreleased)
 ------------------
 
+* **2019-07-26**: [BC-BREAK] Remove deprecated `BaseTestCase::getClient`, use `BaseTestCase::getFrameworkBundleClient` instead.
 * **2019-02-28**: [BC-BREAK] Remove `DatabaseTestListener`, use scripts in `bin/make/` to ramp up your testing environment for several test suites
 * **2019-02-28**: [BC-BREAK] Introduce PHPUnit 6 Support, Remove PHPUnit 5.7.
 * **2019-02-28**: Add testing scenarios for Symfony 4.2 and 4.3 (allowed to fail for now)

src/Functional/BaseTestCase.php

@@ -54,20 +54,6 @@ protected function getKernelConfiguration()
         return [];
     }
 
-    public function __call($name, $arguments)
-    {
-        if ('getClient' === $name) {
-            @trigger_error(sprintf(
-                '"%s::getClient()" is deprecated in favor of getFrameworkBundleClient() since symfony-cmf/testing 2.1 and will no longer be callable in 3.0',
-                __CLASS__
-            ), E_USER_DEPRECATED);
-
-            return $this->getFrameworkBundleClient();
-        }
-
-        return parent::$name(...$arguments);
-    }
-
     /**
      * Gets the Client.
      *
@@ -76,7 +62,7 @@ public function __call($name, $arguments)
     public function getFrameworkBundleClient()
     {
         if (null === $this->client) {
-            $this->client = $this->createClient($this->getKernelConfiguration());
+            $this->client = self::createClient($this->getKernelConfiguration());
         }
 
         return $this->client;

tests/Functional/BaseTestCaseTest.php

@@ -77,15 +77,6 @@ public function provideTestDb()
         ];
     }
 
-    /**
-     * @group legacy
-     * @expectedDeprecation "Symfony\Cmf\Component\Testing\Functional\BaseTestCase::getClient()" is deprecated in favor of getFrameworkBundleClient() since symfony-cmf/testing 2.1 and will no longer be callable in 3.0
-     */
-    public function testItTriggersADeprecationErrorWhenCallingGetClient()
-    {
-        $this->assertInstanceOf(Client::class, $this->testCase->getClient());
-    }
-
     public function testItCanProvideAFrameworkBundleClient()
     {
         $this->assertInstanceOf(Client::class, $this->testCase->getFrameworkBundleClient());