Start version 3.0 (#191)

Author: ElectricMaxxx

.gitignore

@@ -1,2 +1,3 @@
 composer.lock
 /vendor/
+build/

.travis.yml

@@ -17,7 +17,8 @@ language: php
 
 php:
   - 7.1
-
+  - 7.2
+  - 7.3
 sudo: false
 
 cache:
@@ -26,25 +27,28 @@ cache:
     - $HOME/.composer/cache/files
 
 env:
-  matrix: SYMFONY_VERSION=4.0.*
+  matrix: SYMFONY_VERSION=4.2.*
   global:
     - SYMFONY_DEPRECATIONS_HELPER="/.*each.*/"
     - SYMFONY_PHPUNIT_DIR=.phpunit SYMFONY_PHPUNIT_REMOVE="symfony/yaml"
-    - SYMFONY_PHPUNIT_VERSION=7.3
-    - TEST_INSTALLATION=false
+    - SYMFONY_PHPUNIT_VERSION=7
+    - PHPUNIT_VERSION=7
+    - TARGET=test
 
 matrix:
   include:
-    - php: 7.2
-      env: STABILITY=dev SYMFONY_VERSION=4.0.*
-    - php: 7.1
-      env: COMPOSER_FLAGS="--prefer-lowest" SYMFONY_VERSION=2.8.* SYMFONY_DEPRECATIONS_HELPER=weak
+    - php: 7.3
+      env: STABILITY="dev" SYMFONY_VERSION=4.3.*
+    - php: 7.3
+      env: SYMFONY_VERSION=4.2.*
     - php: 7.1
-      env: STABILITY=dev SYMFONY_VERSION=3.3.*
-    - php: 7.1
-      env: STABILITY=dev SYMFONY_VERSION=3.4.*
+      env: COMPOSER_FLAGS="--prefer-lowest" SYMFONY_VERSION=3.4.* SYMFONY_DEPRECATIONS_HELPER="/.*each.*/"
+    - php: 7.2
+      env: SYMFONY_VERSION=4.1.*
   fast_finish: true
   allow_failures:
+    - php: 7.3
+      env: STABILITY="dev" SYMFONY_VERSION=4.3.*
 
 before_install:
   - phpenv config-rm xdebug.ini || true
@@ -55,6 +59,7 @@ before_install:
   - export BRANCH=$(if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then echo $TRAVIS_BRANCH; else echo $TRAVIS_PULL_REQUEST_BRANCH; fi)
 
 install: travis_wait composer update --prefer-dist $COMPOSER_FLAGS
+
 script:
   - if [ "${TEST_INSTALLATION}" == true ]; then make test_installation; else make test; fi
 

CHANGELOG.md

@@ -1,8 +1,14 @@
 Changelog
 =========
 
-2.1.0 (unreleased)
+3.0.0 (unreleased)
 ------------------
+* **2019-02-28**: [BC-BREAK] Remove `DatabaseTestListener`, use scripts in `bin/make/` to ramp up your testing environment for several test suites
+* **2019-02-28**: [BC-BREAK] Introduce PHPUnit 6 Support, Remove PHPUnit 5.7.
+* **2019-02-28**: Add testing scenarios for Symfony 4.2 and 4.3 (allowed to fail for now)
+
+2.1.0
+-----
 
 * **2017-01-18**: Introduce a `TestCompilePass` to make services public, which are needed 
 in i.e. a WebTest.

Makefile

@@ -20,13 +20,39 @@ ifdef BRANCH
 	VERSION=dev-${BRANCH}
 endif
 PACKAGE=symfony-cmf/testing
+HAS_XDEBUG=$(shell php --modules|grep --quiet xdebug;echo $$?)
+
 list:
 	@echo 'test:                    will run all tests'
 	@echo 'unit_tests:               will run unit tests only'
 
 
-
 include ${TESTING_SCRIPTS_DIR}/make/unit_tests.mk
 
 .PHONY: test
-test: unit_tests
+test: build/xdebug-filter.php unit_tests
+lint-php:
+	php-cs-fixer fix --ansi --verbose --diff --dry-run
+.PHONY: lint-php
+
+int: lint-composer lint-php
+.PHONY: lint
+
+lint-composer:
+	composer validate
+.PHONY: lint-composer
+
+cs-fix: cs-fix-php
+.PHONY: cs-fix
+
+cs-fix-php:
+	php-cs-fixer fix --verbose
+.PHONY: cs-fix-php
+
+build:
+	mkdir $@
+
+build/xdebug-filter.php: phpunit.xml.dist build
+ifeq ($(HAS_XDEBUG), 0)
+	phpunit --dump-xdebug-filter $@
+endif

README.md

@@ -8,11 +8,13 @@
 [![Monthly Downloads](https://poser.pugx.org/symfony-cmf/testing/d/monthly)](https://packagist.org/packages/symfony-cmf/testing)
 [![Daily Downloads](https://poser.pugx.org/symfony-cmf/testing/d/daily)](https://packagist.org/packages/symfony-cmf/testing)
 
-Branch | Travis | Coveralls |
------- | ------ | --------- |
-master | [![Build Status][travis_unstable_badge]][travis_link] | [![Coverage Status][coveralls_unstable_badge]][coveralls_unstable_link] |
+Branch | Travis | Coveralls | Scrutinizer |
+------ | ------ | --------- | ----------- |
+2.1   | [![Build Status][travis_stable_badge]][travis_stable_link]     | [![Coverage Status][coveralls_stable_badge]][coveralls_stable_link]     | [![Scrutinizer Status][scrutinizer_stable_badge]][scrutinizer_stable_link] |
+dev-master | [![Build Status][travis_unstable_badge]][travis_unstable_link] | [![Coverage Status][coveralls_unstable_badge]][coveralls_unstable_link] | [![Scrutinizer Status][scrutinizer_unstable_badge]][scrutinizer_unstable_link] |
 
-This package is part of the [Symfony Content Management Framework (CMF)](http://cmf.symfony.com/) and licensed
+
+This package is part of the [Symfony Content Management Framework (CMF)](https://cmf.symfony.com/) and licensed
 under the [MIT License](LICENSE).
 
 **NOTE**: This is an internal tool and is not intended to be used outside of
@@ -21,24 +23,24 @@ the context of the CMF.
 
 ## Requirements
 
-* PHP 5.6 / 7.0 / 7.1 / 7.2
-* Symfony 2.8 / 3.3 / 3.4 / 4.0
+* PHP 7.1 / 7.2 / 7.3
+* Symfony 3.4 / 4.0 / 4.1 / 4.2
 * See also the `require` section of [composer.json](composer.json)
 
 ## Documentation
 
 For the install guide and reference, see:
 
-* [symfony-cmf/testing Documentation](http://symfony.com/doc/master/cmf/components/testing/index.html)
+* [symfony-cmf/testing Documentation](https://symfony.com/doc/master/cmf/components/testing/index.html)
 
 See also:
 
-* [All Symfony CMF documentation](http://symfony.com/doc/master/cmf/index.html) - complete Symfony CMF reference
-* [Symfony CMF Website](http://cmf.symfony.com/) - introduction, live demo, support and community links
+* [All Symfony CMF documentation](https://symfony.com/doc/master/cmf/index.html) - complete Symfony CMF reference
+* [Symfony CMF Website](https://cmf.symfony.com/) - introduction, live demo, support and community links
 
 ## Support
 
-For general support and questions, please use [StackOverflow](http://stackoverflow.com/questions/tagged/symfony-cmf).
+For general support and questions, please use [StackOverflow](https://stackoverflow.com/questions/tagged/symfony-cmf).
 
 ## Contributing
 
@@ -47,7 +49,7 @@ Pull requests are welcome. Please see our
 guide.
 
 Unit and/or functional tests exist for this package. See the
-[Testing documentation](http://symfony.com/doc/master/cmf/components/testing.html)
+[Testing documentation](https://symfony.com/doc/master/cmf/components/testing.html)
 for a guide to running the tests.
 
 Thanks to
@@ -57,14 +59,17 @@ Thanks to
 
 This package is available under the [MIT license](src/Resources/meta/LICENSE).
 
-[travis_legacy_badge]: https://travis-ci.org/symfony-cmf/testing.svg?branch=master
-[travis_stable_badge]: https://travis-ci.org/symfony-cmf/testing.svg?branch=master
-[travis_unstable_badge]: https://travis-ci.org/symfony-cmf/testing.svg?branch=master
-[travis_link]: https://travis-ci.org/symfony-cmf/testing
-
-[coveralls_legacy_badge]: https://coveralls.io/repos/github/symfony-cmf/testing/badge.svg?branch=master
-[coveralls_legacy_link]: https://coveralls.io/github/symfony-cmf/testing?branch=master
-[coveralls_stable_badge]: https://coveralls.io/repos/github/symfony-cmf/testing/badge.svg?branch=master
-[coveralls_stable_link]: https://coveralls.io/github/symfony-cmf/testing?branch=master
-[coveralls_unstable_badge]: https://coveralls.io/repos/github/symfony-cmf/testing/badge.svg?branch=master
-[coveralls_unstable_link]: https://coveralls.io/github/symfony-cmf/testing?branch=master
+[travis_stable_badge]: https://travis-ci.org/symfony-cmf/Testing.svg?branch=2.1
+[travis_stable_link]: https://travis-ci.org/symfony-cmf/Testing
+[travis_unstable_badge]: https://travis-ci.org/symfony-cmf/Testing.svg?branch=dev-master
+[travis_unstable_link]: https://travis-ci.org/symfony-cmf/Testing
+
+[coveralls_stable_badge]: https://coveralls.io/repos/github/symfony-cmf/Testing/badge.svg?branch=2.1
+[coveralls_stable_link]: https://coveralls.io/github/symfony-cmf/Testing?branch=2.1
+[coveralls_unstable_badge]: https://coveralls.io/repos/github/symfony-cmf/Testing/badge.svg?branch=dev-master
+[coveralls_unstable_link]: https://coveralls.io/github/symfony-cmf/Testing?branch=dev-master
+
+[scrutinizer_stable_badge]: https://scrutinizer-ci.com/g/symfony-cmf/Testing/badges/quality-score.png?b=2.1
+[scrutinizer_stable_link]: https://scrutinizer-ci.com/g/symfony-cmf/Testing/?branch=2.1
+[scrutinizer_unstable_badge]: https://scrutinizer-ci.com/g/symfony-cmf/Testing/badges/quality-score.png?b=dev-master
+[scrutinizer_unstable_link]: https://scrutinizer-ci.com/g/symfony-cmf/Testing/?branch=dev-master

bin/make/functional_tests_orm.mk

@@ -7,5 +7,9 @@ functional_tests_orm:
 	@${CONSOLE} doctrine:database:create --env=orm
 	@${CONSOLE} doctrine:schema:create --env=orm
 	@echo '+++ run ORM functional tests +++'
-	@vendor/bin/simple-phpunit --testsuite "functional tests with orm"
+ifeq ($(HAS_XDEBUG), 0)
+	@vendor/bin/simple-phpunit --prepend build/xdebug-filter.php -c phpunit.xml.dist --coverage-clover build/logs/clover.xml --testsuite "functional tests with orm"
+else
+	@vendor/bin/simple-phpunit -c phpunit.xml.dist --testsuite "functional tests with orm"
+endif
 	@${CONSOLE} doctrine:database:drop --force

bin/make/functional_tests_phpcr.mk

@@ -6,5 +6,9 @@ functional_tests_phpcr:
 	@${CONSOLE} doctrine:phpcr:init:dbal --drop --force
 	@${CONSOLE} doctrine:phpcr:repository:init
 	@echo '+++ run PHPCR functional tests +++'
-	@vendor/bin/simple-phpunit --testsuite "functional tests with phpcr"
+ifeq ($(HAS_XDEBUG), 0)
+	@vendor/bin/simple-phpunit --prepend build/xdebug-filter.php -c phpunit.xml.dist --coverage-clover build/logs/clover.xml --testsuite "functional tests with phpcr"
+else
+	@vendor/bin/simple-phpunit -c phpunit.xml.dist --testsuite "functional tests with phpcr"
+endif
 	@${CONSOLE} doctrine:database:drop --force

bin/make/unit_tests.mk

@@ -2,4 +2,8 @@
 unit_tests:
 	@echo
 	@echo '+++ run unit tests +++'
-	@vendor/bin/simple-phpunit --testsuite "unit tests"
+ifeq ($(HAS_XDEBUG), 0)
+	@vendor/bin/simple-phpunit --prepend build/xdebug-filter.php -c phpunit.xml.dist --coverage-clover build/logs/clover.xml --testsuite "unit tests"
+else
+	@vendor/bin/simple-phpunit -c phpunit.xml.dist --testsuite "unit tests"
+endif

composer.json

@@ -18,22 +18,20 @@
         "friendsofsymfony/jsrouting-bundle": "^1.1 || ^2.1",
         "jackalope/jackalope": "^1.3",
         "jackalope/jackalope-doctrine-dbal": "^1.3",
-        "symfony/browser-kit": "^2.8 || ^3.3 || ^4.0",
-        "symfony/console": "^2.8 || ^3.3 || ^4.0",
-        "symfony/css-selector": "^2.8 || ^3.3 || ^4.0",
-        "symfony/debug": "^2.8 || ^3.3 || ^4.0",
-        "symfony/dependency-injection": "^2.8 || ^3.3 || ^4.0",
-        "symfony/doctrine-bridge": "^2.8 || ^3.3 || ^4.0",
-        "symfony/framework-bundle": "^2.8.18 || ^3.3 || ^4.0",
-        "symfony/http-foundation": "^2.8 || ^3.3 || ^4.0",
-        "symfony/http-kernel": "^2.8 || ^3.3 || ^4.0",
+        "symfony/browser-kit": "^3.4.22 || ^4.1",
+        "symfony/console": "^3.4.22 || ^4.1",
+        "symfony/css-selector": "^3.4.22 || ^4.1",
+        "symfony/debug": "^3.4.22 || ^4.1",
+        "symfony/dependency-injection": "^3.4.22 || ^4.1",
+        "symfony/doctrine-bridge": "^3.4.22 || ^4.1",
+        "symfony/framework-bundle": "^3.4.22 || ^4.1",
+        "symfony/http-foundation": "^3.4.22 || ^4.1",
+        "symfony/http-kernel": "^3.4.22 || ^4.1",
         "symfony/monolog-bundle": "~3.1",
-        "symfony/process": "^2.8 || ^3.3 || ^4.0",
-        "symfony/security-bundle": "^2.8 || ^3.3 || ^4.0",
-        "symfony/twig-bundle": "^2.8 || ^3.3 || ^4.0"
-    },
-    "require-dev": {
-        "symfony/phpunit-bridge": "^4.1"
+        "symfony/process": "^3.4.22 || ^4.1",
+        "symfony/security-bundle": "^3.4.22 || ^4.1",
+        "symfony/twig-bundle": "^3.4.22 || ^4.1",
+        "symfony/phpunit-bridge": "^4.2.2"
     },
     "autoload": {
         "psr-4": {

php_cs.dist

@@ -0,0 +1,67 @@
+<?php
+
+/**
+ * DO NOT EDIT THIS FILE!
+ *
+ * It's auto-generated by sonata-project/dev-kit package.
+ */
+
+$header = <<<'HEADER'
+############################################################################
+# This file is part of the Symfony CMF package.                            #
+#                                                                          #
+# (c) 2011-2017 Symfony CMF                                                #
+#                                                                          #
+# For the full copyright and license information, please view the LICENSE  #
+# file that was distributed with this source code.                         #
+############################################################################
+HEADER;
+
+$rules = [
+    '@Symfony' => true,
+    '@Symfony:risky' => true,
+    'array_syntax' => [
+        'syntax' => 'short',
+    ],
+    'combine_consecutive_issets' => true,
+    'combine_consecutive_unsets' => true,
+    'header_comment' => [
+        'header' => $header,
+    ],
+    'no_extra_blank_lines' => true,
+    'no_php4_constructor' => true,
+    'no_useless_else' => true,
+    'no_useless_return' => true,
+    'ordered_class_elements' => true,
+    'ordered_imports' => true,
+    'phpdoc_order' => true,
+    '@PHP56Migration' => true,
+    '@PHP56Migration:risky' => true,
+    '@PHPUnit57Migration:risky' => true,
+    '@PHP70Migration' => true,
+    '@PHP70Migration:risky' => true,
+    '@PHPUnit60Migration:risky' => true,
+    '@PHP71Migration' => true,
+    '@PHP71Migration:risky' => true,
+    'compact_nullable_typehint' => true,
+    'void_return' => null,
+    'strict_comparison' => true,
+    'strict_param' => true,
+    'php_unit_strict' => true,
+];
+
+
+$finder = PhpCsFixer\Finder::create()
+    ->in(__DIR__)
+    ->exclude('Tests/Fixtures')
+    ->exclude('tests/Fixtures')
+    ->exclude('Resources/skeleton')
+    ->exclude('Resources/public/vendor')
+;
+
+return PhpCsFixer\Config::create()
+    ->setFinder($finder)
+    ->setRiskyAllowed(true)
+    ->setRules($rules)
+    ->setUsingCache(true)
+;