Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Commit 5490b5b

Browse files
committed
Merge pull request #245 from symfony-cmf/prepare-1.3
prepare 1.3 release
2 parents 49c7b2e + f2abe11 commit 5490b5b

File tree

6 files changed

+16
-11
lines changed

6 files changed

+16
-11
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ env:
2121
matrix:
2222
include:
2323
- php: 5.6
24-
env: DEPS=dev
24+
env: DEPS=dev SYMFONY_VERSION=2.8.*
2525
- php: 5.3
2626
env: COMPOSER_FLAGS="--prefer-lowest"
2727
- php: 5.6

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
Changelog
22
=========
33

4+
1.3.0
5+
-----
6+
7+
* Support Symfony 2.8
8+
* Support PHP 7
9+
10+
1.2.0
11+
-----
12+
413
1.2.0-RC1
514
---------
615

Cache/BlockJsCache.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ protected function getSync(array $keys)
109109
{
110110
$dashifiedId = $this->dashify($keys['block_id']);
111111

112-
return sprintf(<<<CONTENT
112+
return sprintf(<<<'CONTENT'
113113
<div id="block%s" >
114114
<script type="text/javascript">
115115
/*<![CDATA[*/
@@ -157,7 +157,7 @@ protected function getSync(array $keys)
157157
*/
158158
protected function getAsync(array $keys)
159159
{
160-
return sprintf(<<<CONTENT
160+
return sprintf(<<<'CONTENT'
161161
<div id="block%s" >
162162
<script type="text/javascript">
163163
/*<![CDATA[*/
@@ -219,7 +219,7 @@ public function cacheAction(Request $request)
219219
return $response;
220220
}
221221

222-
$response->setContent(sprintf(<<<JS
222+
$response->setContent(sprintf(<<<'JS'
223223
(function () {
224224
var block = document.getElementById('block%s'),
225225
div = document.createElement("div"),

Cache/BlockVarnishCache.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public function __construct(
6868
BlockLoaderInterface $blockLoader,
6969
BlockContextManagerInterface $blockContextManager,
7070
FragmentHandler $fragmentHandler,
71-
array $servers = array(),
71+
array $servers,
7272
$purgeInstruction
7373
) {
7474
parent::__construct($token, $servers, $router, $purgeInstruction, null);

Tests/Unit/Cache/BlockJsCacheTest.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
use Symfony\Cmf\Bundle\BlockBundle\Cache\BlockJsCache;
1515
use Symfony\Component\HttpFoundation\Response;
1616

17-
/**
18-
*
19-
*/
2017
class BlockJsCacheTest extends \PHPUnit_Framework_TestCase
2118
{
2219
/**
@@ -78,7 +75,7 @@ public function testInitCache()
7875

7976
$this->assertInstanceOf('Sonata\Cache\CacheElement', $cacheElement);
8077

81-
$expected = <<<EXPECTED
78+
$expected = <<<'EXPECTED'
8279
<div id="block-cms-content-home-additionalInfoBlock" >
8380
<script type="text/javascript">
8481
/*<![CDATA[*/

composer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@
2323
"symfony/framework-bundle": ">=2.3.0,<2.3.2"
2424
},
2525
"require-dev": {
26-
"symfony-cmf/testing": "^1.3@RC",
26+
"symfony-cmf/testing": "^1.3",
2727
"symfony-cmf/menu-bundle": "^1.1|^2.0",
2828
"sonata-project/doctrine-phpcr-admin-bundle": "^1.1",
29-
"symfony-cmf/tree-browser-bundle": "^1.0.0-RC1",
3029
"sonata-project/cache-bundle": ">=2.1.3,<2.1.6",
3130
"twig/twig": "^1.14.2|^2.0"
3231
},

0 commit comments

Comments
 (0)