Merge pull request #286 from symfony-cmf/analysis-maYxQ7

Apply fixes from StyleCI

Author: dbu

src/DependencyInjection/CmfCoreExtension.php

@@ -300,8 +300,6 @@ public function setupFormTypes(ContainerBuilder $container, LoaderInterface $loa
     /**
      * Load and configure the publish workflow services.
      *
-     * @param $config
-     *
      * @throws InvalidConfigurationException
      */
     private function loadPublishWorkflow($config, XmlFileLoader $loader, ContainerBuilder $container)

src/PublishWorkflow/Voter/PublishTimePeriodVoter.php

@@ -11,11 +11,11 @@
 
 namespace Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\Voter;
 
-use function is_subclass_of;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishTimePeriodReadInterface;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishWorkflowChecker;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Authorization\Voter\Voter;
+use function is_subclass_of;
 
 /**
  * Workflow voter for the PublishTimePeriodReadInterface.

src/PublishWorkflow/Voter/PublishableVoter.php

@@ -11,11 +11,11 @@
 
 namespace Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\Voter;
 
-use function is_subclass_of;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishableReadInterface;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishWorkflowChecker;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Authorization\Voter\Voter;
+use function is_subclass_of;
 
 /**
  * Workflow voter for the PublishableReadInterface.

src/Security/Authorization/Voter/PublishedVoter.php

@@ -11,12 +11,12 @@
 
 namespace Symfony\Cmf\Bundle\CoreBundle\Security\Authorization\Voter;
 
-use function is_subclass_of;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishableReadInterface;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishTimePeriodReadInterface;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishWorkflowChecker;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Authorization\Voter\Voter;
+use function is_subclass_of;
 
 /**
  * This is a security voter registered with the Symfony security system that

src/Templating/Helper/Cmf.php

@@ -50,9 +50,6 @@ class Cmf
      */
     private $publishWorkflowChecker;
 
-    /**
-     * @param AuthorizationCheckerInterface $publishWorkflowChecker
-     */
     public function __construct(AuthorizationCheckerInterface $publishWorkflowChecker = null)
     {
         $this->publishWorkflowChecker = $publishWorkflowChecker;
@@ -133,8 +130,6 @@ public function getPath($document)
     /**
      * Finds a document by path.
      *
-     * @param $path
-     *
      * @return object|null
      */
     public function find($path)
@@ -474,8 +469,6 @@ public function getDescendants($parent, ?int $depth = null): array
     /**
      * Check children for a possible following document.
      *
-     * @param bool $ignoreRole
-     *
      * @return object|null
      */
     private function checkChildren(array $childNames, string $path, ?bool $ignoreRole = false, ?string $class = null)

src/Templating/Helper/CmfHelper.php

@@ -73,8 +73,6 @@ public function getPath($document)
     /**
      * Finds a document by path.
      *
-     * @param $path
-     *
      * @return object|null
      */
     public function find($path)

tests/Functional/Form/CheckboxUrlLabelFormTypeTest.php

@@ -74,7 +74,7 @@ private function getFormRenderer()
 
     protected function assertMatchesXpath($html, $expression, $count = 1)
     {
-        $dom = new \DomDocument('UTF-8');
+        $dom = new \DOMDocument('UTF-8');
 
         try {
             // Wrap in <root> node so we can load HTML with multiple tags at

tests/Unit/PublishWorkflow/Voter/PublishTimePeriodVoterTest.php

@@ -11,7 +11,6 @@
 
 namespace Symfony\Cmf\Bundle\CoreBundle\Tests\Unit\PublishWorkflow\Voter;
 
-use function is_subclass_of;
 use PHPUnit\Framework\TestCase;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishTimePeriodReadInterface;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishWorkflowChecker;
@@ -21,6 +20,7 @@
 use Symfony\Component\Security\Core\Authorization\Voter\CacheableVoterInterface;
 use Symfony\Component\Security\Core\Authorization\Voter\Voter;
 use Symfony\Component\Security\Core\Authorization\Voter\VoterInterface;
+use function is_subclass_of;
 
 class PublishTimePeriodVoterTest extends TestCase
 {

tests/Unit/PublishWorkflow/Voter/PublishableVoterTest.php

@@ -11,7 +11,6 @@
 
 namespace Symfony\Cmf\Bundle\CoreBundle\Tests\Unit\PublishWorkflow\Voter;
 
-use function is_subclass_of;
 use PHPUnit\Framework\TestCase;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishableReadInterface;
 use Symfony\Cmf\Bundle\CoreBundle\PublishWorkflow\PublishWorkflowChecker;
@@ -21,6 +20,7 @@
 use Symfony\Component\Security\Core\Authorization\Voter\CacheableVoterInterface;
 use Symfony\Component\Security\Core\Authorization\Voter\Voter;
 use Symfony\Component\Security\Core\Authorization\Voter\VoterInterface;
+use function is_subclass_of;
 
 class PublishableVoterTest extends TestCase
 {