Improve exception logging

Author: wouterj

QuietFactory.php

@@ -20,7 +20,7 @@ class QuietFactory implements FactoryInterface
     private $innerFactory;
 
     /**
-     * @var LoggerInterface
+     * @var LoggerInterface|null
      */
     private $logger;
 
@@ -33,7 +33,7 @@ class QuietFactory implements FactoryInterface
      */
     private $allowEmptyItems;
 
-    public function __construct(FactoryInterface $innerFactory, LoggerInterface $logger, $allowEmptyItems = false)
+    public function __construct(FactoryInterface $innerFactory, LoggerInterface $logger = null, $allowEmptyItems = false)
     {
         $this->innerFactory = $innerFactory;
         $this->logger = $logger;
@@ -48,7 +48,12 @@ public function createItem($name, array $options = array())
         try {
             return $this->innerFactory->createItem($name, $options);
         } catch (RouteNotFoundException $e) {
-            $this->logger->error(sprintf('%s : %s', $name, $e->getMessage()));
+            if (null !== $this->logger) {
+                $this->logger->error(
+                    sprintf('An exception was thrown while creating a menu item called "%s"', $name),
+                    array('exception' => $e)
+                );
+            }
 
             if (!$this->allowEmptyItems) {
                 return null;

Resources/config/menu.xml

@@ -10,7 +10,7 @@
 
         <service id="cmf_menu.factory.quiet" class="Symfony\Cmf\Bundle\MenuBundle\QuietFactory" public="false">
             <argument type="service" id="cmf_menu.factory.quiet.inner" />
-            <argument type="service" id="logger"/>
+            <argument type="service" id="logger" on-invalid="ignore" />
             <argument>%cmf_menu.allow_empty_items%</argument>
         </service>