Better debug functional tests

Author: wouterj

Tests/WebTest/Admin/Extension/MenuNodeReferrersExtensionTest.php

@@ -27,7 +27,7 @@ public function testEdit()
     {
         $crawler = $this->client->request('GET', '/admin/cmf/menu-test/content/test/content-1/edit');
         $res = $this->client->getResponse();
-        $this->assertEquals(200, $res->getStatusCode());
+        $this->assertResponseSuccess($res);
 
         $button = $crawler->selectButton('Update');
         $form = $button->form();

Tests/WebTest/Admin/MenuAdminTest.php

@@ -28,31 +28,31 @@ public function testMenuList()
     {
         $crawler = $this->client->request('GET', '/admin/cmf/menu/menu/list');
         $res = $this->client->getResponse();
-        $this->assertEquals(200, $res->getStatusCode(), $res->getContent());
+        $this->assertResponseSuccess($res);
         $this->assertCount(1, $crawler->filter('html:contains("test-menu")'), $res->getContent());
     }
 
     public function testMenuEdit()
     {
         $crawler = $this->client->request('GET', '/admin/cmf/menu/menu/test/menus/test-menu/edit');
         $res = $this->client->getResponse();
-        $this->assertEquals(200, $res->getStatusCode(), $res->getContent());
+        $this->assertResponseSuccess($res);
         $this->assertCount(1, $crawler->filter('input[value="test-menu"]'), $res->getContent());
     }
 
     public function testMenuShow()
     {
         $crawler = $this->client->request('GET', '/admin/cmf/menu/menu/test/menus/test-menu/show');
         $res = $this->client->getResponse();
-        $this->assertEquals(200, $res->getStatusCode(), $res->getContent());
+        $this->assertResponseSuccess($res);
         $this->assertCount(2, $crawler->filter('td:contains("test-menu")'), $res->getContent());
     }
 
     public function testMenuCreate()
     {
         $crawler = $this->client->request('GET', '/admin/cmf/menu/menu/create');
         $res = $this->client->getResponse();
-        $this->assertEquals(200, $res->getStatusCode(), $res->getContent());
+        $this->assertResponseSuccess($res);
 
         $button = $crawler->selectButton('Create');
         $form = $button->form();
@@ -74,7 +74,7 @@ public function testMenuDelete()
     {
         $crawler = $this->client->request('GET', '/admin/cmf/menu/menu/test/menus/test-menu/delete');
         $res = $this->client->getResponse();
-        $this->assertEquals(200, $res->getStatusCode());
+        $this->assertResponseSuccess($res);
 
         $button = $crawler->selectButton('Yes, delete');
         $form = $button->form();

Tests/WebTest/Admin/MenuNodeAdminTest.php

@@ -26,15 +26,14 @@ public function setUp()
     public function testEdit()
     {
         $this->client->request('GET', '/admin/cmf/menu/menunode/test/menus/test-menu/item-1/edit');
-        $res = $this->client->getResponse();
-        $this->assertEquals(200, $res->getStatusCode());
+
+        $this->assertResponseSuccess($this->client->getResponse());
     }
 
     public function testDelete()
     {
         $crawler = $this->client->request('GET', '/admin/cmf/menu/menunode/test/menus/test-menu/item-2/delete');
-        $res = $this->client->getResponse();
-        $this->assertEquals(200, $res->getStatusCode());
+        $this->assertResponseSuccess($this->client->getResponse());
 
         $button = $crawler->selectButton('Yes, delete');
         $form = $button->form();

Tests/WebTest/Render/TwigTest.php

@@ -27,9 +27,8 @@ public function testTwig()
     {
         $client = $this->createClient();
         $crawler = $client->request('GET', '/render-test');
-        $res = $client->getResponse();
 
-        $this->assertEquals(200, $res->getStatusCode());
+        $this->assertResponseSuccess($client->getResponse());
         $this->assertMenuHasItems($crawler->filter('#content ul')->eq(0), array(
             'This node has a URI',
             '@todo this node should have content',

Tests/WebTest/Voter/RequestContentIdentityVoterTest.php

@@ -19,9 +19,9 @@ public function testRequestContentIdentityVoterNoOp()
         // the URL of the content is the same as the URL for the menu item anyway
         // so it works by default
         $crawler = $this->client->request('GET', '/contents/content-1');
-        $res = $this->client->getResponse();
+
+        $this->assertResponseSuccess($this->client->getResponse());
         $this->assertCurrentItem($crawler, 'Request Content Identity Voter');
-        $this->assertEquals(200, $res->getStatusCode());
     }
 
     public function testRequestContentIdentityVoter()
@@ -30,8 +30,8 @@ public function testRequestContentIdentityVoter()
         // the URL is different from that of the content, so if the menu item
         // is highlighted, it is because the voter is working.
         $crawler = $this->client->request('GET', '/cmi/request_content_identity');
-        $res = $this->client->getResponse();
+
+        $this->assertResponseSuccess($this->client->getResponse());
         $this->assertCurrentItem($crawler, 'Request Content Identity Voter');
-        $this->assertEquals(200, $res->getStatusCode());
     }
 }

Tests/WebTest/Voter/RequestParentContentIdentityVoterTest.php

@@ -19,17 +19,17 @@ public function testRequestContentParentIdentityNoOp()
         // to the "Request Content PArent Identity" menu item and so DOES NOT invoke
         // the voter.
         $crawler = $this->client->request('GET', '/blog');
+
+        $this->assertResponseSuccess($this->client->getResponse());
         $this->assertCurrentItem($crawler, 'Request Parent Content Identity Voter');
-        $res = $this->client->getResponse();
-        $this->assertEquals(200, $res->getStatusCode());
     }
 
     public function testRequestContentParentIdentity()
     {
         // this test shows an post whose parent is the blog content referenced in the menu item
         $crawler = $this->client->request('GET', '/blog/my-post');
-        $res = $this->client->getResponse();
+
+        $this->assertResponseSuccess($this->client->getResponse());
         $this->assertCurrentItem($crawler, 'Request Parent Content Identity Voter');
-        $this->assertEquals(200, $res->getStatusCode());
     }
 }

Tests/WebTest/Voter/UriPrefixVoterTest.php

@@ -19,18 +19,18 @@ public function testUriPrefixArticlesHomepage()
         // to the "URI Prefix Voter" menu item and so DOES NOT invoke
         // the voter.
         $crawler = $this->client->request('GET', '/articles');
-        $res = $this->client->getResponse();
+
+        $this->assertResponseSuccess($this->client->getResponse());
         $this->assertCurrentItem($crawler, 'URI Prefix Voter');
-        $this->assertEquals(200, $res->getStatusCode());
     }
 
     public function testUriPrefixArticle()
     {
         // this test shows an article which contains the prefix in the "/articles" route
         // as currentUriPrefix, and so the Voter IS used and the item should be selected.
         $crawler = $this->client->request('GET', '/articles/some-category/article-1');
-        $res = $this->client->getResponse();
+
+        $this->assertResponseSuccess($this->client->getResponse());
         $this->assertCurrentItem($crawler, 'URI Prefix Voter');
-        $this->assertEquals(200, $res->getStatusCode());
     }
 }