Merge pull request #71 from symfony-cmf/fix-cs

fix cs config

Author: dbu

.styleci.yml

@@ -15,11 +15,10 @@
 
 
 preset: symfony
+risky: true
 
 enabled:
   - combine_consecutive_unsets
-  - short_array_syntax
-  - newline_after_open_tag
   - no_php4_constructor
   - no_useless_else
   - ordered_use

src/Controller/ResourceController.php

@@ -48,10 +48,6 @@ class ResourceController
      */
     private $authorizationChecker;
 
-    /**
-     * @param SerializerInterface         $serializer
-     * @param RepositoryRegistryInterface $registry
-     */
     public function __construct(SerializerInterface $serializer, RepositoryRegistryInterface $registry, ResourceHandler $resourceHandler, AuthorizationCheckerInterface $authorizationChecker = null)
     {
         $this->serializer = $serializer;
@@ -84,10 +80,7 @@ public function getResourceAction(Request $request, $repositoryName, $path)
 
             return $this->createResponse($resource);
         } catch (ResourceNotFoundException $e) {
-            throw new NotFoundHttpException(
-                sprintf('No resource found at path "%s" for repository "%s"', $path, $repositoryName),
-                $e
-            );
+            throw new NotFoundHttpException(sprintf('No resource found at path "%s" for repository "%s"', $path, $repositoryName), $e);
         }
     }
 
@@ -105,9 +98,8 @@ public function getResourceAction(Request $request, $repositoryName, $path)
      *
      * changing payload properties isn't supported yet.
      *
-     * @param string  $repositoryName
-     * @param string  $path
-     * @param Request $request
+     * @param string $repositoryName
+     * @param string $path
      *
      * @return Response
      */

src/DependencyInjection/CmfResourceRestExtension.php

@@ -30,7 +30,7 @@ public function load(array $configs, ContainerBuilder $container)
         $config = $processor->processConfiguration($configuration, $configs);
 
         $bundles = $container->getParameter('kernel.bundles');
-        if (!array_key_exists('JMSSerializerBundle', $bundles)) {
+        if (!\array_key_exists('JMSSerializerBundle', $bundles)) {
             throw new \LogicException('The JMSSerializerBundle must be registered in order to use the CmfResourceRestBundle.');
         }
 

src/Registry/PayloadAliasRegistry.php

@@ -32,10 +32,6 @@ class PayloadAliasRegistry
      */
     private $repositoryRegistry;
 
-    /**
-     * @param RepositoryRegistryInterface $repositoryRegistry
-     * @param array                       $aliases
-     */
     public function __construct(RepositoryRegistryInterface $repositoryRegistry, array $aliases = [])
     {
         $this->repositoryRegistry = $repositoryRegistry;
@@ -52,8 +48,6 @@ public function __construct(RepositoryRegistryInterface $repositoryRegistry, arr
     /**
      * Return the alias for the given PHPCR resource.
      *
-     * @param PuliResource $resource
-     *
      * @return string
      */
     public function getPayloadAlias(PuliResource $resource)

src/Security/ResourcePathVoter.php

@@ -36,8 +36,8 @@ public function __construct(AccessDecisionManagerInterface $accessDecisionManage
      */
     protected function supports($attribute, $subject)
     {
-        return in_array($attribute, [ResourceController::ROLE_RESOURCE_READ, ResourceController::ROLE_RESOURCE_WRITE])
-            && is_array($subject) && isset($subject['repository_name']) && isset($subject['path']);
+        return \in_array($attribute, [ResourceController::ROLE_RESOURCE_READ, ResourceController::ROLE_RESOURCE_WRITE])
+            && \is_array($subject) && isset($subject['repository_name']) && isset($subject['path']);
     }
 
     /**
@@ -60,7 +60,7 @@ protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
 
     private function ruleMatches($rule, $attribute, $subject)
     {
-        if (!in_array($attribute, $rule['attributes'])) {
+        if (!\in_array($attribute, $rule['attributes'])) {
             return false;
         }
 

src/Serializer/Jms/EventSubscriber/PhpcrNodeSubscriber.php

@@ -33,9 +33,6 @@ public static function getSubscribedEvents()
         ];
     }
 
-    /**
-     * @param PreSerializeEvent $event
-     */
     public function onPreSerialize(PreSerializeEvent $event)
     {
         $object = $event->getObject();

src/Serializer/Jms/EventSubscriber/ResourceSubscriber.php

@@ -33,9 +33,6 @@ public static function getSubscribedEvents()
         ];
     }
 
-    /**
-     * @param PreSerializeEvent $event
-     */
     public function onPreSerialize(PreSerializeEvent $event)
     {
         $object = $event->getObject();

src/Serializer/Jms/Handler/PhpcrNodeHandler.php

@@ -37,10 +37,7 @@ public static function getSubscribingMethods()
     }
 
     /**
-     * @param JsonSerializationVisitor $visitor
-     * @param NodeInterface            $nodeInterface
-     * @param array                    $type
-     * @param Context                  $context
+     * @param NodeInterface $nodeInterface
      */
     public function serializePhpcrNode(
         JsonSerializationVisitor $visitor,

src/Serializer/Jms/Handler/ResourceHandler.php

@@ -67,10 +67,7 @@ public static function getSubscribingMethods()
     }
 
     /**
-     * @param JsonSerializationVisitor $visitor
-     * @param NodeInterface            $resourceInterface
-     * @param array                    $type
-     * @param Context                  $context
+     * @param NodeInterface $resourceInterface
      */
     public function serializeResource(
         JsonSerializationVisitor $visitor,

tests/Features/Context/ResourceContext.php

@@ -100,7 +100,7 @@ public function createFile($filename, PyStringNode $content)
     {
         $filesytem = new Filesystem();
         $file = str_replace('%kernel.root_dir%', $this->kernel->getRootDir(), $filename);
-        $filesytem->mkdir(dirname($file));
+        $filesytem->mkdir(\dirname($file));
 
         file_put_contents($file, (string) $content);
     }
@@ -120,10 +120,7 @@ public function createDocument($class, $path, TableNode $fields)
         }
 
         if (!class_exists($class)) {
-            throw new \InvalidArgumentException(sprintf(
-                'Class "%s" does not exist',
-                $class
-            ));
+            throw new \InvalidArgumentException(sprintf('Class "%s" does not exist', $class));
         }
 
         $document = new $class();
@@ -148,10 +145,7 @@ public function thereIsADocumentAt($class, $path, TableNode $fields = null)
         $path = '/tests'.$path;
 
         if (!class_exists($class)) {
-            throw new \InvalidArgumentException(sprintf(
-                'Class "%s" does not exist',
-                $class
-            ));
+            throw new \InvalidArgumentException(sprintf('Class "%s" does not exist', $class));
         }
 
         $document = $this->manager->find($class, $path);
@@ -176,10 +170,7 @@ public function thereIsNoDocumentAt($class, $path)
         $path = '/tests'.$path;
 
         if (!class_exists($class)) {
-            throw new \InvalidArgumentException(sprintf(
-                'Class "%s" does not exist',
-                $class
-            ));
+            throw new \InvalidArgumentException(sprintf('Class "%s" does not exist', $class));
         }
 
         $this->session->refresh(true);