Fixed getRoutesByNames so that if the $idPrefix is not set, it bypasses the foreach loop.

 Removed the .idea file from .gitignore
 Added Back the missing getRoutesByNames skipped test.

Author: Chirs Warner

.gitignore

@@ -3,4 +3,3 @@ composer.lock
 vendor
 Tests/Resources/app/cache
 Tests/Resources/app/logs
-.idea

Doctrine/Phpcr/RouteProvider.php

@@ -60,7 +60,7 @@ public function setPrefix($prefix)
      */
     public function getRouteCollectionForRequest(Request $request)
     {
-        $url = $request->getPathInfo();
+        $url        = $request->getPathInfo();
         $candidates = $this->getCandidates($url);
 
         $collection = new RouteCollection();
@@ -77,7 +77,8 @@ public function getRouteCollectionForRequest(Request $request)
                     $collection->add($key, $route);
                 }
             }
-        } catch (RepositoryException $e) {
+        }
+        catch (RepositoryException $e) {
             // TODO: how to determine whether this is a relevant exception or not?
             // https://github.com/symfony-cmf/RoutingBundle/issues/143
             // for example, getting /my//test (note the double /) is just an invalid path
@@ -95,17 +96,17 @@ public function getRouteCollectionForRequest(Request $request)
      */
     protected function getCandidates($url)
     {
-        $candidates = array();
+        $candidates = array ();
         if ('/' !== $url) {
             if (preg_match('/(.+)\.[a-z]+$/i', $url, $matches)) {
                 $candidates[] = $this->idPrefix . $url;
-                $url = $matches[1];
+                $url          = $matches[1];
             }
 
             $part = $url;
             while (false !== ($pos = strrpos($part, '/'))) {
                 $candidates[] = $this->idPrefix . $part;
-                $part = substr($url, 0, $pos);
+                $part         = substr($url, 0, $pos);
             }
         }
 
@@ -117,15 +118,15 @@ protected function getCandidates($url)
     /**
      * {@inheritDoc}
      */
-    public function getRouteByName($name, $parameters = array())
+    public function getRouteByName($name, $parameters = array ())
     {
 
         // $name is the route document path
-        if ( '' === $this->idPrefix || 0 === strpos($name, $this->idPrefix) ) {
+        if ('' === $this->idPrefix || 0 === strpos($name, $this->idPrefix)) {
             $route = $this->getObjectManager()->find($this->className, $name);
         }
 
-        if (!$route) {
+        if (empty($route)) {
             throw new RouteNotFoundException(sprintf('No route found for path "%s"', $name));
         }
 
@@ -139,15 +140,20 @@ public function getRouteByName($name, $parameters = array())
     /**
      * {@inheritDoc}
      */
-    public function getRoutesByNames($names, $parameters = array())
+    public function getRoutesByNames($names, $parameters = array ())
     {
-        $routes = array();
-        foreach ($names as $name) {
-            if ('' === $this->idPrefix || 0 === strpos($name, $this->idPrefix)) {
-                $routes[] = $name;
+        $routes = array ();
+        if ('' === $this->idPrefix) {
+            foreach ($names as $name) {
+                if (0 === strpos($name, $this->idPrefix)) {
+                    $routes[] = $name;
+                }
             }
+        } else {
+            $routes = $names;
         }
 
+
         $collection = $this->getObjectManager()->findMany($this->className, $routes);
         foreach ($collection as $key => $document) {
             if (!$document instanceof SymfonyRoute) {
@@ -158,5 +164,4 @@ public function getRoutesByNames($names, $parameters = array())
 
         return $collection;
     }
-
 }

Tests/Unit/Doctrine/Phpcr/RouteProviderTest.php

@@ -230,6 +230,10 @@ public function testGetRouteByNameNoRoutePrefixEmptyString()
         $routeProvider->getRouteByName('/cms/routes/test-route');
     }
 
+    public function testGetRoutesByNames()
+    {
+        $this->markTestIncomplete();
+    }
 
     /**
      * Use getRouteByName() with two different document managers.