Skip to content

Commit 11152d3

Browse files
committed
Merge remote-tracking branch 'origin/master' into create-models
Conflicts: CHANGELOG.md DependencyInjection/CmfRoutingExtension.php Tests/Functional/Doctrine/Phpcr/RedirectRouteTest.php Tests/Functional/Doctrine/Phpcr/RouteTest.php
2 parents 3a8cebc + f3dda5c commit 11152d3

20 files changed

+80
-236
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ env:
1010
- SYMFONY_VERSION=dev-master
1111

1212
before_script:
13-
- composer require symfony/routing:${SYMFONY_VERSION} --no-update
14-
- composer install --dev
13+
- composer require symfony/framework-bundle:${SYMFONY_VERSION} --no-update
14+
- composer update
1515
- cp ./Tests/Functional/config/parameters.yml.dist ./Tests/Functional/config/parameters.yml
1616
- php Tests/Functional/console doctrine:phpcr:init:dbal
1717
- php Tests/Functional/console doctrine:phpcr:repository:init

CHANGELOG.md

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,11 @@
11
Changelog
22
=========
33

4-
* **2013-06-15**: [Model] Separated database agnostic, doctrine generic and
5-
PHPCR-ODM specific code to prepare for Doctrine ORM support. Deprecated
6-
RoutingBundle\Document\Route and RedirectRoute in favor of
7-
RoutingBundle\Doctrine\Phpcr\Route resp. RedirectRoute and also moved the
8-
PHPCR-ODM specific listeners and repository implementations to Doctrine\Phpcr
9-
Configuration was cleaned up as well. PHPCR specific configurations moved
10-
into dynamic.phpcr_provider: use_sonata_admin, 'manager_registry,
11-
manager_name, route_basepath, content_basepath.
12-
In preparation of other route provider support, you need to at least set
13-
`phpcr_provider: ~` to have the PHPCR provider loaded.
14-
Dropped redundant routing_repositoryroot.
4+
* **2013-07-19**: [Model] Separated database agnostic, doctrine generic and
5+
PHPCR-ODM specific code to prepare for Doctrine ORM support.
6+
* **2013-07-17**: [FormType] Moved TermsFormType to CoreBundle and renamed it to CheckboxUrlLableFormType
157

16-
1.1.0-beta1
17-
-----------
8+
1.1.0-beta2
189

1910
* **2013-05-28**: [Bundle] Only include Doctrine PHPCR compiler pass if PHPCR-ODM is present
2011
* **2013-05-25**: [Bundle] Drop symfony_ from symfony_cmf prefix

CONTRIBUTING.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
Contributing
2+
------------
3+
4+
Symfony2 CMF is an open source, community-driven project. We follow the same
5+
guidelines as core Symfony2. If you'd like to contribute, please read the
6+
[Contributing Code][1] part of the documentation. If you're submitting a pull
7+
request, please follow the guidelines in the [Submitting a Patch][2] section
8+
and use the [Pull Request Template][3].
9+
10+
[1]: http://symfony.com/doc/current/contributing/code/index.html
11+
[2]: http://symfony.com/doc/current/contributing/code/patches.html#check-list
12+
[3]: http://symfony.com/doc/current/contributing/code/patches.html#make-a-pull-request

CmfRoutingBundle.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
use Symfony\Component\DependencyInjection\Definition;
77
use Symfony\Component\HttpKernel\Bundle\Bundle;
88
use Symfony\Component\DependencyInjection\ContainerBuilder;
9-
use Symfony\Cmf\Bundle\RoutingBundle\DependencyInjection\Compiler\ChainRouterPass;
10-
use Symfony\Cmf\Bundle\RoutingBundle\DependencyInjection\Compiler\RouteEnhancerPass;
9+
use Symfony\Cmf\Component\Routing\DependencyInjection\Compiler\RegisterRoutersPass;
10+
use Symfony\Cmf\Component\Routing\DependencyInjection\Compiler\RegisterRouteEnhancersPass;
1111
use Symfony\Cmf\Bundle\RoutingBundle\DependencyInjection\Compiler\SetRouterPass;
1212

1313
/**
@@ -21,8 +21,8 @@ class CmfRoutingBundle extends Bundle
2121
public function build(ContainerBuilder $container)
2222
{
2323
parent::build($container);
24-
$container->addCompilerPass(new ChainRouterPass());
25-
$container->addCompilerPass(new RouteEnhancerPass());
24+
$container->addCompilerPass(new RegisterRoutersPass());
25+
$container->addCompilerPass(new RegisterRouteEnhancersPass());
2626
$container->addCompilerPass(new SetRouterPass());
2727

2828
if (class_exists('Doctrine\Bundle\PHPCRBundle\DependencyInjection\Compiler\DoctrinePhpcrMappingsPass')) {

DependencyInjection/CmfRoutingExtension.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,6 @@ public function load(array $configs, ContainerBuilder $container)
4343
}
4444

4545
$this->setupFormTypes($config, $container, $loader);
46-
47-
// if there is twig, register our form type with twig
48-
if ($container->hasParameter('twig.form.resources')) {
49-
$resources = $container->getParameter('twig.form.resources');
50-
$container->setParameter('twig.form.resources', array_merge($resources, array('CmfRoutingBundle:Form:terms_form_type.html.twig')));
51-
}
5246
}
5347

5448
public function setupFormTypes(array $config, ContainerBuilder $container, LoaderInterface $loader)

DependencyInjection/Compiler/ChainRouterPass.php

Lines changed: 0 additions & 37 deletions
This file was deleted.

DependencyInjection/Compiler/RouteEnhancerPass.php

Lines changed: 0 additions & 29 deletions
This file was deleted.

Form/Type/TermsFormType.php

Lines changed: 0 additions & 68 deletions
This file was deleted.

Resources/config/dynamic_routing.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161

6262
<service id="cmf_routing.nested_matcher" class="%cmf_routing.nested_matcher_class%">
6363
<argument type="service" id="cmf_routing.route_provider" />
64-
<call method="setFinalMatcher"><argument type="service" id="cmf_routing.final_matcher"/></call>
64+
<argument type="service" id="cmf_routing.final_matcher"/>
6565
</service>
6666

6767
<service id="cmf_routing.matcher.dummy_collection" class="Symfony\Component\Routing\RouteCollection" public="false"/>

Resources/config/form_type.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,9 @@
55

66
<parameters>
77
<parameter key="cmf_routing.route_type_type_class">Symfony\Cmf\Bundle\RoutingBundle\Form\Type\RouteTypeType</parameter>
8-
<parameter key="cmf_routing.terms_form_type_class">Symfony\Cmf\Bundle\RoutingBundle\Form\Type\TermsFormType</parameter>
98
</parameters>
109

1110
<services>
12-
13-
<service id="cmf_routing.terms_form_type" class="%cmf_routing.terms_form_type_class%">
14-
<tag name="form.type" alias="cmf_routing_terms_form_type" />
15-
<argument type="service" id="router" />
16-
</service>
17-
1811
<service id="cmf_routing.route_type_form_type" class="%cmf_routing.route_type_type_class%">
1912
<tag name="form.type" alias="cmf_routing_route_type" />
2013
</service>

0 commit comments

Comments
 (0)