created tickets for todo comments, cs fixes

Author: dbu

Admin/RedirectRouteAdmin.php

@@ -38,8 +38,6 @@ protected function configureFormFields(FormMapper $formMapper)
     {
         $formMapper
             ->with('form.group_general')
-                // TODO: show resulting url; strip /cms/routes and prepend eventual route prefix
-                // ->add('path', 'text', array('label' => 'URL', 'attr' => array('readonly' => 'readonly')))
                 ->add('parent', 'doctrine_phpcr_odm_tree', array('choice_list' => array(), 'select_root_node' => true, 'root_node' => $this->routeRoot))
                 ->add('name', 'text')
                 ->add('routeName', 'text', array('required' => false))

Admin/RouteAdmin.php

@@ -86,6 +86,7 @@ protected function configureDatagridFilters(DatagridMapper $datagridMapper)
     public function setRouteRoot($routeRoot)
     {
         // TODO: fix widget to show root node when root is selectable
+        // https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/issues/148
         $this->routeRoot = PathHelper::getParentPath($routeRoot);
     }
 

CmfRoutingBundle.php

@@ -3,7 +3,6 @@
 namespace Symfony\Cmf\Bundle\RoutingBundle;
 
 use Doctrine\Bundle\PHPCRBundle\DependencyInjection\Compiler\DoctrinePhpcrMappingsPass;
-use Symfony\Cmf\Bundle\CoreBundle\DependencyInjection\Compiler\DoctrineOrmMappingsPass;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\HttpKernel\Bundle\Bundle;

Doctrine/Orm/RouteProvider.php

@@ -82,15 +82,14 @@ public function getRouteCollectionForRequest(Request $request)
 
                     $route->setDefault('_format', $matches[1]);
                 }
-                // SYMFONY 2.1 COMPATIBILITY: tweak route name
-                $key = trim(preg_replace('/[^a-z0-9A-Z_.]/', '_', $key), '_');
                 $collection->add($key, $route);
             }
         } catch (RepositoryException $e) {
-            // TODO: how to determine whether this is a relevant exception or not?
-            // for example, getting /my//test (note the double /) is just an invalid path
-            // and means another router might handle this.
-            // but if the PHPCR backend is down for example, we want to alert the user
+            // TODO: this is not an orm exception
+            // https://github.com/symfony-cmf/RoutingBundle/issues/142
+            // also check if there are valid reasons for the orm manager to
+            // throw an exception or if we should just not catch it to not hide
+            // a severe problem.
         }
 
         return $collection;

Doctrine/Phpcr/IdPrefixListener.php

@@ -2,7 +2,6 @@
 
 namespace Symfony\Cmf\Bundle\RoutingBundle\Doctrine\Phpcr;
 
-use Symfony\Cmf\Bundle\RoutingBundle\Doctrine\Phpcr\Route;
 use Doctrine\Common\Persistence\Event\LifecycleEventArgs;
 
 /**

Doctrine/Phpcr/RouteProvider.php

@@ -59,8 +59,6 @@ public function getRouteCollectionForRequest(Request $request)
         try {
             $routes = $this->getObjectManager()->findMany($this->className, $candidates);
             // filter for valid route objects
-            // we can not search for a specific class as PHPCR does not know class inheritance
-            // but optionally we could define a node type
             foreach ($routes as $key => $route) {
                 if ($route instanceof SymfonyRoute) {
                     if (preg_match('/.+\.([a-z]+)$/i', $url, $matches)) {
@@ -75,6 +73,7 @@ public function getRouteCollectionForRequest(Request $request)
             }
         } catch (RepositoryException $e) {
             // TODO: how to determine whether this is a relevant exception or not?
+            // https://github.com/symfony-cmf/RoutingBundle/issues/143
             // for example, getting /my//test (note the double /) is just an invalid path
             // and means another router might handle this.
             // but if the PHPCR backend is down for example, we want to alert the user