fix reference usage in compile pass (#408)

Author: ElectricMaxxx

src/DependencyInjection/Compiler/TemplatingValidatorPass.php

@@ -14,6 +14,7 @@
 use Symfony\Cmf\Bundle\RoutingBundle\Validator\Constraints\RouteDefaultsTemplatingValidator;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Reference;
 
 /**
  * To avoid a BC-Break: If templating component exists, we will use the validator using general templating
@@ -29,10 +30,9 @@ class TemplatingValidatorPass implements CompilerPassInterface
     public function process(ContainerBuilder $container)
     {
         if ($container->has('templating')) {
-            $templatingDefinition = $container->findDefinition('templating');
             $validatorDefinition = $container->getDefinition('cmf_routing.validator.route_defaults');
             $validatorDefinition->setClass(RouteDefaultsTemplatingValidator::class);
-            $validatorDefinition->replaceArgument(1, $templatingDefinition);
+            $validatorDefinition->replaceArgument(1, new Reference('templating'));
         }
     }
 }

tests/Functional/Doctrine/Phpcr/RouteProviderTest.php

@@ -95,7 +95,7 @@ public function testGetRouteCollectionForRequestFormat()
         $this->assertEquals('html', $testroute->getDefault('_format'));
         list($key, $root) = each($routes);
         $this->assertEquals(self::ROUTE_ROOT, $key);
-        $this->assertEquals(null, $root->getDefault('_format'));
+        $this->assertNull($root->getDefault('_format'));
     }
 
     /**