Refactored compiler test

Author: wouterj

DependencyInjection/Compiler/SetRouterPass.php

@@ -25,7 +25,7 @@ public function process(ContainerBuilder $container)
     {
 
         // only replace the default router by overwriting the 'router' alias if config tells us to
-        if (true === $container->getParameter('cmf_routing.replace_symfony_router')) {
+        if ($container->hasParameter('cmf_routing.replace_symfony_router') && true === $container->getParameter('cmf_routing.replace_symfony_router')) {
             $container->setAlias('router', 'cmf_routing.router');
         }
 

Tests/Unit/DependencyInjection/Compiler/SetRouterPassTest.php

@@ -14,37 +14,30 @@
 
 use Symfony\Cmf\Bundle\RoutingBundle\DependencyInjection\Compiler\SetRouterPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractCompilerPassTestCase;
 
-class SetRouterPassTest extends \PHPUnit_Framework_TestCase
+class SetRouterPassTest extends AbstractCompilerPassTestCase
 {
+    protected function registerCompilerPass(ContainerBuilder $container)
+    {
+        $container->addCompilerPass(new SetRouterPass());
+    }
+
     public function testMapperPassReplacesRouterAlias()
     {
-        $pass = new SetRouterPass();
-
-        $builder = $this->getMock('Symfony\Component\DependencyInjection\ContainerBuilder');
-        $builder->expects($this->once())
-            ->method('getParameter')
-            ->with('cmf_routing.replace_symfony_router')
-            ->will($this->returnValue(true));
-        $builder->expects($this->once())
-            ->method('setAlias')
-            ->with('router', 'cmf_routing.router');
-
-        $pass->process($builder);
+        $this->container->setParameter('cmf_routing.replace_symfony_router', true);
+
+        $this->compile();
+
+        $this->assertContainerBuilderHasAlias('router', 'cmf_routing.router');
     }
 
-    public function testMapperPassDoesntReplaceRouterAlias()
+    public function testMapperPassDoesNotReplaceRouterAlias()
     {
-        $pass = new SetRouterPass();
+        $this->container->setParameter('cmf_routing.replace_symfony_router', false);
 
-        $builder = $this->getMock('Symfony\Component\DependencyInjection\ContainerBuilder');
-        $builder->expects($this->once())
-            ->method('getParameter')
-            ->with('cmf_routing.replace_symfony_router')
-            ->will($this->returnValue(false));
-        $builder->expects($this->never())
-            ->method('setAlias');
+        $this->compile();
 
-        $pass->process($builder);
+        $this->assertFalse($this->container->hasAlias('router'));
     }
 }