bug #148 If there is a comment on a closed issue, then dont remove "stalled" label (Nyholm)

This PR was merged into the master branch.

Discussion
----------

If there is a comment on a closed issue, then dont remove "stalled" label

This is just nice to have

Example: symfony/symfony#32597

Commits
-------

ffb058b If there is a comment on a closed issue, then dont remove "stalled" label

Author: weaverryan

src/Subscriber/RemoveStalledLabelOnCommentSubscriber.php

@@ -34,6 +34,11 @@ public function onIssueComment(GitHubEvent $event)
             return;
         }
 
+        // If not open, then do nothing
+        if ('open' !== $data['issue']['state']) {
+            return;
+        }
+
         $removed = false;
         $issueNumber = $data['issue']['number'];
         foreach ($data['issue']['labels'] as $label) {

tests/Subscriber/RemoveStalledLabelOnCommentSubscriberTest.php

@@ -35,7 +35,7 @@ protected function setUp()
     public function testOnComment()
     {
         $event = new GitHubEvent([
-            'issue' => ['number' => 1234, 'labels' => []], 'comment' => ['user' => ['login' => 'nyholm']],
+            'issue' => ['number' => 1234, 'state' => 'open', 'labels' => []], 'comment' => ['user' => ['login' => 'nyholm']],
         ], $this->repository);
 
         $this->dispatcher->dispatch($event, GitHubEvents::ISSUE_COMMENT);
@@ -47,7 +47,7 @@ public function testOnComment()
     public function testOnCommentOnStale()
     {
         $event = new GitHubEvent([
-            'issue' => ['number' => 1234, 'labels' => [['name' => 'Foo'], ['name' => 'Stalled']]], 'comment' => ['user' => ['login' => 'nyholm']],
+            'issue' => ['number' => 1234, 'state' => 'open', 'labels' => [['name' => 'Foo'], ['name' => 'Stalled']]], 'comment' => ['user' => ['login' => 'nyholm']],
         ], $this->repository);
 
         $this->dispatcher->dispatch($event, GitHubEvents::ISSUE_COMMENT);
@@ -61,7 +61,19 @@ public function testOnCommentOnStale()
     public function testOnBotCommentOnStale()
     {
         $event = new GitHubEvent([
-            'issue' => ['number' => 1234, 'labels' => [['name' => 'Foo'], ['name' => 'Stalled']]], 'comment' => ['user' => ['login' => 'carsonbot']],
+            'issue' => ['number' => 1234, 'state' => 'open', 'labels' => [['name' => 'Foo'], ['name' => 'Stalled']]], 'comment' => ['user' => ['login' => 'carsonbot']],
+        ], $this->repository);
+
+        $this->dispatcher->dispatch($event, GitHubEvents::ISSUE_COMMENT);
+
+        $responseData = $event->getResponseData();
+        $this->assertEmpty($responseData);
+    }
+
+    public function testCommentOnClosed()
+    {
+        $event = new GitHubEvent([
+            'issue' => ['number' => 1234, 'state' => 'closed', 'labels' => [['name' => 'Foo'], ['name' => 'Stalled']]], 'comment' => ['user' => ['login' => 'nyholm']],
         ], $this->repository);
 
         $this->dispatcher->dispatch($event, GitHubEvents::ISSUE_COMMENT);