bug #164 Fix space in auto title (Nyholm)

This PR was squashed before being merged into the master branch.

Discussion
----------

Fix space in auto title

This will fix #161.

@wouterj, this was interesting.

What happen is:
1. PR is posted it as `[RateLimiter][Security] ...`
2. Carson parses the title and adds label "RateLimiter", then "Security"
3. Github sends a "label was updated ping" about RateLimiter
4. Carson correctly title to `[RateLimiter] [Security] ...` because " Security was not marked as a label yet.
5. Github sends a "label was updated ping" about Security
6. Carson will update the title again, and correctly set it to `[RateLimiter][Security] ...`

However, It is a race condition... if 3 and 5 is reversed, then you experience the wrong title.

The easy fix is to update the two labels at the same time, which is what I do in this PR.

Commits
-------

0eeb6cb Fix space in auto title

Author: weaverryan

src/Api/Label/GithubLabelApi.php

@@ -76,19 +76,7 @@ public function getIssueLabels($issueNumber, Repository $repository): array
 
     public function addIssueLabel($issueNumber, string $label, Repository $repository)
     {
-        $key = $this->getCacheKey($issueNumber, $repository);
-
-        if (isset($this->labelCache[$key][$label])) {
-            return;
-        }
-
-        $this->logger->debug('Adding label "{label}" for {repo}#{issue}', ['label' => $label, 'repo' => $repository->getFullName(), 'issue' => $issueNumber]);
-        $this->labelsApi->add($repository->getVendor(), $repository->getName(), $issueNumber, $label);
-
-        // Update cache if already loaded
-        if (isset($this->labelCache[$key])) {
-            $this->labelCache[$key][$label] = true;
-        }
+        $this->addIssueLabels($issueNumber, [$label], $repository);
     }
 
     public function removeIssueLabel($issueNumber, string $label, Repository $repository)
@@ -115,8 +103,24 @@ public function removeIssueLabel($issueNumber, string $label, Repository $reposi
 
     public function addIssueLabels($issueNumber, array $labels, Repository $repository)
     {
+        $key = $this->getCacheKey($issueNumber, $repository);
+        $labelsToAdd = [];
+
         foreach ($labels as $label) {
-            $this->addIssueLabel($issueNumber, $label, $repository);
+            if (!isset($this->labelCache[$key][$label])) {
+                $labelsToAdd[] = $label;
+            }
+        }
+
+        if ([] !== $labelsToAdd) {
+            $this->labelsApi->add($repository->getVendor(), $repository->getName(), $issueNumber, $labelsToAdd);
+        }
+
+        // Update cache if already loaded
+        foreach ($labels as $label) {
+            if (isset($this->labelCache[$key])) {
+                $this->labelCache[$key][$label] = true;
+            }
         }
     }
 

tests/Api/Label/GithubLabelApiTest.php

@@ -78,7 +78,7 @@ public function testAddIssueLabel()
 
         $this->backendApi->expects($this->once())
             ->method('add')
-            ->with(self::USER_NAME, self::REPO_NAME, 1234, 'a');
+            ->with(self::USER_NAME, self::REPO_NAME, 1234, ['a']);
 
         $this->api->addIssueLabel(1234, 'a', $this->repository);
     }
@@ -96,7 +96,7 @@ public function testAddIssueLabelUpdatesCache()
 
         $this->backendApi->expects($this->once())
             ->method('add')
-            ->with(self::USER_NAME, self::REPO_NAME, 1234, 'd');
+            ->with(self::USER_NAME, self::REPO_NAME, 1234, ['d']);
 
         $this->assertSame(['a', 'b', 'c'], $this->api->getIssueLabels(1234, $this->repository));