Skip to content

Commit 3759847

Browse files
committed
fix auth
1 parent 678d40f commit 3759847

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

.env

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,8 @@ APP_SECRET=5dd8ffca252d95e8b4fb5b2d15310e92
2727
#TRUSTED_HOSTS='^(localhost|example\.com)$'
2828
###< symfony/framework-bundle ###
2929

30-
GITHUB_TOKEN=XXX
3130
SYMFONY_DOCS_SECRET=XX
3231

3332
###> knplabs/github-api ###
34-
GITHUB_AUTH_METHOD=http_password
35-
GITHUB_USERNAME=username
36-
GITHUB_SECRET=password_or_token
33+
GITHUB_TOKEN=XXX
3734
###< knplabs/github-api ###

config/packages/github_api.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ services:
33
arguments:
44
- '@Github\HttpClient\Builder'
55
calls:
6-
- ['authenticate', ['%env(GITHUB_USERNAME)%', '%env(GITHUB_SECRET)%', '%env(GITHUB_AUTH_METHOD)%']]
6+
- ['authenticate', ['%env(GITHUB_TOKEN)%', 'http_token']]
77

88
Github\HttpClient\Builder:
99
arguments:

config/services.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
# Put parameters here that don't need to change on each machine where the app is deployed
55
# https://symfony.com/doc/current/best_practices/configuration.html#application-related-configuration
66
parameters:
7-
github_token: '%env(GITHUB_TOKEN)%'
87
symfony_docs_secret: '%env(SYMFONY_DOCS_SECRET)%'
98

109
imports:

0 commit comments

Comments
 (0)