Skip to content

Commit 51981dc

Browse files
committed
Bugfix
1 parent c3756d5 commit 51981dc

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

src/Api/Issue/GithubIssueApi.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function open(Repository $repository, string $title, string $body, array
4242

4343
$issueNumber = null;
4444
$existingIssues = $this->resultPager->fetchAllLazy($this->searchApi, 'issues', [sprintf('repo:%s "%s" is:open author:%s', $repository->getFullName(), $title, $this->botUsername), 'updated', 'desc']);
45-
foreach ($existingIssues['items'] ?? [] as $issue) {
45+
foreach ($existingIssues as $issue) {
4646
$issueNumber = $issue['number'];
4747
}
4848

@@ -110,11 +110,9 @@ public function commentOnIssue(Repository $repository, $issueNumber, string $com
110110
);
111111
}
112112

113-
public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUpdateAfter): array
113+
public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUpdateAfter): iterable
114114
{
115-
$issues = $this->resultPager->fetchAll($this->searchApi, 'issues', [sprintf('repo:%s is:issue -label:"Keep open" is:open updated:<%s', $repository->getFullName(), $noUpdateAfter->format('Y-m-d')), 'updated', 'desc']);
116-
117-
return $issues['items'] ?? [];
115+
return $this->resultPager->fetchAllLazy($this->searchApi, 'issues', [sprintf('repo:%s is:issue -label:"Keep open" is:open updated:<%s', $repository->getFullName(), $noUpdateAfter->format('Y-m-d')), 'updated', 'desc']);
118116
}
119117

120118
public function getUsers(Repository $repository, $issueNumber): array

src/Api/Issue/IssueApi.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public function hasActivity(Repository $repository, $number): bool;
2525

2626
public function lastCommentWasMadeByBot(Repository $repository, $number): bool;
2727

28-
public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUpdateAfter): array;
28+
public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUpdateAfter): iterable;
2929

3030
/**
3131
* Close an issue or a pull request.

src/Api/Issue/NullIssueApi.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function lastCommentWasMadeByBot(Repository $repository, $number): bool
2929
return false;
3030
}
3131

32-
public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUpdateAfter): array
32+
public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUpdateAfter): iterable
3333
{
3434
return [];
3535
}

0 commit comments

Comments
 (0)