Skip to content

Commit 9f6a984

Browse files
committed
bug #180 Use per_page: 100 when applicable (Nyholm)
This PR was squashed before being merged into the master branch. Discussion ---------- Use `per_page: 100` when applicable If we ever get more than 30 milestones.. This is a fix. Commits ------- f11c817 Use `per_page: 100` when applicable
2 parents 2515ee0 + f11c817 commit 9f6a984

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/Api/Issue/GithubIssueApi.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public function hasActivity(Repository $repository, $number): bool
7171
$author = $issue['user']['login'] ?? null;
7272

7373
try {
74-
$reviewComments = $this->reviewApi->all($repository->getVendor(), $repository->getName(), $number);
74+
$reviewComments = $this->reviewApi->all($repository->getVendor(), $repository->getName(), $number, ['per_page' => 100]);
7575
} catch (RuntimeException $e) {
7676
// This was not a PR =)
7777
$reviewComments = [];

src/Api/Milestone/GithubMilestoneApi.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ private function getMilestones(Repository $repository): array
3838
if (!isset($this->cache[$key])) {
3939
$this->cache[$key] = [];
4040

41-
$milestones = $this->milestonesApi->all($repository->getVendor(), $repository->getName());
41+
$milestones = $this->milestonesApi->all($repository->getVendor(), $repository->getName(), ['per_page' => 100]);
4242

4343
foreach ($milestones as $milestone) {
4444
$this->cache[$key][] = $milestone;

0 commit comments

Comments
 (0)