feature #215 Removing suggest contributor feature (weaverryan)

This PR was squashed before being merged into the master branch.

Discussion
----------

Removing suggest contributor feature

Fixes #214

Commits
-------

afe12c4 Removing suggest contributor feature

Author: weaverryan

.github/workflows/find-reviewer.yml

@@ -84,16 +84,6 @@ Carson will look for old inactive issues and start a process with them.
 The process can be interrupted with anyone making a comment on the issue or the
 "Keep open" label is added.
 
-### Suggest reviewers
-
-Carson can look at the PR to figure out who will be a good candidate to review the
-changes. This can be triggered by someone can make a comment in a PR to say
-`@carsonbot find me a reviewer please` (or really anything with `@carsonbot` and
-`review` on the same line).
-
-Carson will also try to find a reviewer if there is no activity on a new PR within
-the first 20 hours.
-
 ### Add a warning if pull request target unsupported branch
 
 If a PR is opened towards a branch that is not maintained anymore, Carson will

README.md

@@ -50,18 +50,10 @@ services:
     Github\Api\Issue\Milestones:
         factory: ['@Github\Api\Issue', milestones]
 
-    Github\Api\Issue\Timeline:
-        factory: ['@Github\Api\Issue', timeline]
-        calls:
-            - [configure]
-
     Github\Api\PullRequest:
         factory: ['@Github\Client', api]
         arguments: [pullRequest]
 
-    Github\Api\PullRequest\Review:
-        factory: ['@Github\Api\PullRequest', reviews]
-
     Github\Api\Repo:
         factory: ['@Github\Client', api]
         arguments: [repo]

config/packages/github_api.yaml

@@ -7,7 +7,6 @@ parameters:
                 - 'App\Subscriber\StatusChangeByReviewSubscriber'
                 - 'App\Subscriber\NeedsReviewNewPRSubscriber'
                 - 'App\Subscriber\BugLabelNewIssueSubscriber'
-                - 'App\Subscriber\FindReviewerSubscriber'
                 - 'App\Subscriber\AutoLabelFromContentSubscriber'
                 - 'App\Subscriber\MilestoneNewPRSubscriber'
                 - 'App\Subscriber\MilestoneMergedPRSubscriber'
@@ -49,7 +48,6 @@ parameters:
                 - 'App\Subscriber\StatusChangeByReviewSubscriber'
                 - 'App\Subscriber\NeedsReviewNewPRSubscriber'
                 - 'App\Subscriber\BugLabelNewIssueSubscriber'
-                - 'App\Subscriber\FindReviewerSubscriber'
                 - 'App\Subscriber\AutoLabelFromContentSubscriber'
                 - 'App\Subscriber\MilestoneNewPRSubscriber'
                 - 'App\Subscriber\MilestoneMergedPRSubscriber'

config/services.yaml

@@ -5,30 +5,23 @@
 use App\Model\Repository;
 use Github\Api\Issue;
 use Github\Api\Issue\Comments;
-use Github\Api\Issue\Timeline;
-use Github\Api\PullRequest\Review;
 use Github\Api\Search;
-use Github\Exception\RuntimeException;
 use Github\ResultPager;
 
 class GithubIssueApi implements IssueApi
 {
     private $resultPager;
     private $issueCommentApi;
-    private $reviewApi;
     private $issueApi;
     private $searchApi;
-    private $timelineApi;
     private $botUsername;
 
-    public function __construct(ResultPager $resultPager, Comments $issueCommentApi, Review $reviewApi, Issue $issueApi, Search $searchApi, Timeline $timelineApi, string $botUsername)
+    public function __construct(ResultPager $resultPager, Comments $issueCommentApi, Issue $issueApi, Search $searchApi, string $botUsername)
     {
         $this->resultPager = $resultPager;
         $this->issueCommentApi = $issueCommentApi;
-        $this->reviewApi = $reviewApi;
         $this->issueApi = $issueApi;
         $this->searchApi = $searchApi;
-        $this->timelineApi = $timelineApi;
         $this->botUsername = $botUsername;
     }
 
@@ -62,31 +55,6 @@ public function lastCommentWasMadeByBot(Repository $repository, $number): bool
         return $this->botUsername === ($lastComment['user']['login'] ?? null);
     }
 
-    /**
-     * Has this PR or issue comments/reviews from others than the author?
-     */
-    public function hasActivity(Repository $repository, $number): bool
-    {
-        $issue = $this->issueApi->show($repository->getVendor(), $repository->getName(), $number);
-        $author = $issue['user']['login'] ?? null;
-
-        try {
-            $reviewComments = $this->reviewApi->all($repository->getVendor(), $repository->getName(), $number, ['per_page' => 100]);
-        } catch (RuntimeException $e) {
-            // This was not a PR =)
-            $reviewComments = [];
-        }
-
-        $all = array_merge($reviewComments, $this->issueCommentApi->all($repository->getVendor(), $repository->getName(), $number, ['per_page' => 100]));
-        foreach ($all as $comment) {
-            if (!in_array($comment['user']['login'], [$author, $this->botUsername])) {
-                return true;
-            }
-        }
-
-        return false;
-    }
-
     public function show(Repository $repository, $issueNumber): array
     {
         return $this->issueApi->show($repository->getVendor(), $repository->getName(), $issueNumber);
@@ -114,23 +82,4 @@ public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUp
     {
         return $this->resultPager->fetchAllLazy($this->searchApi, 'issues', [sprintf('repo:%s is:issue -label:"Keep open" -label:"Missing translations" is:open updated:<%s', $repository->getFullName(), $noUpdateAfter->format('Y-m-d')), 'updated', 'desc']);
     }
-
-    public function getUsers(Repository $repository, $issueNumber): array
-    {
-        $timeline = $this->timelineApi->all($repository->getVendor(), $repository->getName(), $issueNumber);
-        $users = [];
-        foreach ($timeline as $event) {
-            $users[] = $event['actor']['login'] ?? $event['user']['login'] ?? $event['author']['email'] ?? '';
-            if (isset($event['body'])) {
-                // Parse body for user reference
-                if (preg_match_all('|@([a-zA-z_\-0-9]+)|', $event['body'], $matches)) {
-                    foreach ($matches[1] as $match) {
-                        $users[] = $match;
-                    }
-                }
-            }
-        }
-
-        return array_map(function ($a) { return strtolower($a); }, array_unique($users));
-    }
 }

src/Api/Issue/GithubIssueApi.php

@@ -21,8 +21,6 @@ public function show(Repository $repository, $issueNumber): array;
 
     public function commentOnIssue(Repository $repository, $issueNumber, string $commentBody);
 
-    public function hasActivity(Repository $repository, $number): bool;
-
     public function lastCommentWasMadeByBot(Repository $repository, $number): bool;
 
     public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUpdateAfter): iterable;
@@ -31,9 +29,4 @@ public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUp
      * Close an issue or a pull request.
      */
     public function close(Repository $repository, $issueNumber);
-
-    /**
-     * Get users active or mentioned in this issue/pull request.
-     */
-    public function getUsers(Repository $repository, $issueNumber): array;
 }

src/Api/Issue/IssueApi.php

@@ -19,11 +19,6 @@ public function commentOnIssue(Repository $repository, $issueNumber, string $com
     {
     }
 
-    public function hasActivity(Repository $repository, $number): bool
-    {
-        return false;
-    }
-
     public function lastCommentWasMadeByBot(Repository $repository, $number): bool
     {
         return false;
@@ -37,9 +32,4 @@ public function findStaleIssues(Repository $repository, \DateTimeImmutable $noUp
     public function close(Repository $repository, $issueNumber)
     {
     }
-
-    public function getUsers(Repository $repository, $issueNumber): array
-    {
-        return [];
-    }
 }

src/Api/Issue/NullIssueApi.php

@@ -4,25 +4,20 @@
 
 use App\Model\Repository;
 use Github\Api\PullRequest;
-use Github\Api\Repo;
 use Github\Api\Search;
 
 /**
  * @author Tobias Nyholm <[email protected]>
  */
 class GithubPullRequestApi implements PullRequestApi
 {
-    private $github;
     private $pullRequest;
     private $search;
-    private $botUsername;
 
-    public function __construct(Repo $github, PullRequest $pullRequest, Search $search, string $botUsername)
+    public function __construct(PullRequest $pullRequest, Search $search)
     {
-        $this->github = $github;
         $this->pullRequest = $pullRequest;
         $this->search = $search;
-        $this->botUsername = $botUsername;
     }
 
     public function show(Repository $repository, $number): array
@@ -41,18 +36,6 @@ public function updateTitle(Repository $repository, $number, string $title, stri
         $this->pullRequest->update($repository->getVendor(), $repository->getName(), $number, $params);
     }
 
-    /**
-     * Trigger start of a "find reviewer" job. The job runs on github actions and will comment on the PR.
-     */
-    public function findReviewer(Repository $repository, $number, string $type)
-    {
-        $this->github->dispatch($this->botUsername, 'carsonbot', 'find-reviewer', [
-            'repository' => $repository->getFullName(),
-            'pull_request_number' => $number,
-            'type' => $type,
-        ]);
-    }
-
     public function getAuthorCount(Repository $repository, string $author): int
     {
         $result = $this->search->issues(sprintf('is:pr repo:%s author:%s', $repository->getFullName(), $author));

src/Api/Issue/StdErrIssueApi.php

@@ -20,10 +20,6 @@ public function updateTitle(Repository $repository, $number, string $title, stri
     {
     }
 
-    public function findReviewer(Repository $repository, $number, string $type)
-    {
-    }
-
     public function getAuthorCount(Repository $repository, string $author): int
     {
         return 1;