CS fixes

Author: Nyholm

src/Issues/GitHub/CachedLabelsApi.php

@@ -18,7 +18,8 @@ class CachedLabelsApi
     private $labelsApi;
 
     /**
-     * In memory cache for specific issues
+     * In memory cache for specific issues.
+     *
      * @var array<array-key, array<array-key, bool>>
      */
     private $labelCache = [];
@@ -103,13 +104,13 @@ public function addIssueLabels($issueNumber, array $labels, Repository $reposito
         }
     }
 
-
     /**
      * @return string[]
      */
     public function getAllLabelsForRepository(Repository $repository): array
     {
         $key = 'labels'.sha1($repository->getFullName());
+
         return $this->cache->get($key, function (ItemInterface $item) use ($repository) {
             $labels = $this->labelsApi->all($repository->getVendor(), $repository->getName());
             $item->expiresAfter(36000);

src/Subscriber/AutoLabelFromContentSubscriber.php

@@ -70,9 +70,6 @@ public function onPullRequest(GitHubEvent $event)
         ]);
     }
 
-    /**
-     * @param GitHubEvent $event
-     */
     public function onIssue(GitHubEvent $event)
     {
         $data = $event->getData();
@@ -83,7 +80,7 @@ public function onIssue(GitHubEvent $event)
 
         $issueNumber = $data['issue']['number'];
         $prTitle = $data['issue']['title'];
-        $labels = array();
+        $labels = [];
 
         // the issue title usually contains one or more labels
         foreach ($this->extractLabels($prTitle, $repository) as $label) {
@@ -92,10 +89,10 @@ public function onIssue(GitHubEvent $event)
 
         $this->labelsApi->addIssueLabels($issueNumber, $labels, $repository);
 
-        $event->setResponseData(array(
+        $event->setResponseData([
             'issue' => $issueNumber,
             'issue_labels' => $labels,
-        ));
+        ]);
     }
 
     private function extractLabels($title, Repository $repository)

tests/Service/Issues/Github/FakedCachedLabelApi.php

@@ -11,7 +11,7 @@ class FakedCachedLabelApi extends CachedLabelsApi
 {
     public function getAllLabelsForRepository(Repository $repository): array
     {
-        return array(
+        return [
             'Asset', 'BC Break', 'BrowserKit', 'Bug', 'Cache', 'Config', 'Console',
             'Contracts', 'Critical', 'CssSelector', 'Debug', 'DebugBundle', 'DependencyInjection',
             'Deprecation', 'Doctrine', 'DoctrineBridge', 'DomCrawler', 'Dotenv',
@@ -25,6 +25,6 @@ public function getAllLabelsForRepository(Repository $repository): array
             'Translator', 'TwigBridge', 'TwigBundle', 'Uid', 'Validator', 'VarDumper',
             'VarExporter', 'WebLink', 'WebProfilerBundle', 'WebServerBundle', 'Workflow',
             'Yaml',
-        );
+        ];
     }
 }

tests/Subscriber/AutoLabelFromContentSubscriberTest.php

@@ -4,7 +4,6 @@
 
 use App\Event\GitHubEvent;
 use App\GitHubEvents;
-use App\Issues\GitHub\CachedLabelsApi;
 use App\Repository\Repository;
 use App\Subscriber\AutoLabelFromContentSubscriber;
 use App\Tests\Service\Issues\Github\FakedCachedLabelApi;