Fixed off-by-one error when getting last line of code block (#26)

Nyholm · web-flow · commit 0c450ba8f88b · 2021-04-21T12:01:50.000+02:00
diff --git a/src/Service/CodeNodeRunner.php b/src/Service/CodeNodeRunner.php
@@ -62,7 +62,7 @@ private function warmupCache(CodeNode $node, IssueCollection $issues, string $ap
             }
         }
 
-        $issues->addIssue(new Issue($node, trim($error), 'Cache Warmup', $node->getEnvironment()->getCurrentFileName(), count(explode(PHP_EOL, $node->getValue()))));
+        $issues->addIssue(new Issue($node, trim($error), 'Cache Warmup', $node->getEnvironment()->getCurrentFileName(), count(explode(PHP_EOL, $node->getValue())) - 1));
     }
 
     private function getFile(CodeNode $node): string

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ private function warmupCache(CodeNode $node, IssueCollection $issues, string $ap`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
`65`		`- $issues->addIssue(new Issue($node, trim($error), 'Cache Warmup', $node->getEnvironment()->getCurrentFileName(), count(explode(PHP_EOL, $node->getValue()))));`
	`65`	`+ $issues->addIssue(new Issue($node, trim($error), 'Cache Warmup', $node->getEnvironment()->getCurrentFileName(), count(explode(PHP_EOL, $node->getValue())) - 1));`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`private function getFile(CodeNode $node): string`