Load token from .env

Author: nikophil

.env.dist

@@ -0,0 +1 @@
+GITHUB_API_TOKEN=

.gitignore

@@ -3,3 +3,4 @@
 /tests/_cache
 /var/
 /docs.phar
+/.env

composer.json

@@ -20,7 +20,8 @@
         "symfony/css-selector": "^4.1",
         "symfony/console": "^4.1",
         "twig/twig": "^2.7.3",
-        "symfony/http-client": "^4.3"
+        "symfony/http-client": "^4.3",
+        "symfony/dotenv": "^4.3"
     },
     "require-dev": {
         "gajus/dindent": "^2.0",

composer.lock

@@ -8,6 +8,7 @@
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
+use Symfony\Component\Dotenv\Dotenv;
 use Symfony\Component\HttpClient\Exception\ClientException;
 use Symfony\Component\HttpClient\HttpClient;
 use Symfony\Component\Process\Exception\ProcessFailedException;
@@ -16,6 +17,10 @@
 
 class GithubReleaseCommand extends Command
 {
+    // todo change repo
+    private const GITHUB_USER = 'nikophil';
+    private const GITHUB_REPO = 'test';
+
     protected static $defaultName = 'github:release';
 
     /** @var SymfonyStyle */
@@ -35,24 +40,30 @@ public function __construct()
     protected function configure()
     {
         $this->setDescription('Create a release on github with a .phar as attachment.');
-        // todo valid with regex
         $this->addArgument('tag', InputArgument::REQUIRED, 'Release\'s tag.');
         $this->addArgument('name', InputArgument::OPTIONAL, 'Release name', 'Symfony docs builder %s');
         $this->addArgument('description', InputArgument::OPTIONAL, 'Symfony docs builder %s');
     }
 
     protected function initialize(InputInterface $input, OutputInterface $output)
     {
-        $this->io = new SymfonyStyle($input, $output);
-        $this->client = $this->createHttpClient();
+        $dotenv = new Dotenv();
+        $dotenv->load(__DIR__.'/../../.env');
+
+        if (empty($_ENV['GITHUB_API_TOKEN'])) {
+            throw new RuntimeException('Please fill "GITHUB_API_TOKEN" in file "[PROJECT_DIR]/.env"');
+        }
+
+        $this->io     = new SymfonyStyle($input, $output);
+        $this->client = $this->createHttpClient($_ENV['GITHUB_API_TOKEN']);
 
         $tag = $input->getArgument('tag');
-        if (!preg_match('/v\d+\.\d+\.\d+/', $tag)) {
+        if (!preg_match('/^v\d+\.\d+\.\d+$/', $tag)) {
             throw new RuntimeException(sprintf('"%s" is not a valid tag.', $tag));
         }
 
-        $this->tag = $tag;
-        $this->name = sprintf($input->getArgument('name'), $tag);
+        $this->tag         = $tag;
+        $this->name        = sprintf($input->getArgument('name'), $tag);
         $this->description = sprintf($input->getArgument('description'), $tag);
     }
 
@@ -72,13 +83,12 @@ private function compilePhar(): void
         $process->mustRun();
     }
 
-    private function createHttpClient(): HttpClientInterface
+    private function createHttpClient(string $githubToken): HttpClientInterface
     {
-// TODO token form .env
         $client = HttpClient::create(
             [
                 'headers' => [
-                    'Authorization' => 'token 52a83ae437c06017d72fc9461392f02b39dc8c0f',
+                    'Authorization' => sprintf('token %s', $githubToken),
                 ],
             ]
         );
@@ -91,8 +101,7 @@ private function createRelease(): int
         try {
             $response = $this->client->request(
                 'POST',
-                // todo change repo
-                'https://api.github.com/repos/nikophil/test/releases',
+                sprintf('https://api.github.com/repos/%s/%s/releases', self::GITHUB_USER, self::GITHUB_REPO),
                 [
                     'json' => [
                         'tag_name'         => $this->tag,
@@ -107,7 +116,13 @@ private function createRelease(): int
 
             return (int) $response->toArray()['id'];
         } catch (ClientException $exception) {
-            throw new RuntimeException('Error while trying to create release. Maybe the tag name already exists?', 0, $exception);
+            if (401 === $exception->getCode()) {
+                $message = 'Invalid token';
+            } else {
+                $message = 'Maybe the tag name already exists?';
+            }
+
+            throw new RuntimeException(sprintf('Error while trying to create release: %s.', $message), 0, $exception);
         }
     }
 
@@ -116,15 +131,20 @@ private function addAssetToRelease(int $releaseId): void
         try {
             $this->client->request(
                 'POST',
-                sprintf('https://uploads.github.com/repos/nikophil/test/releases/%s/assets?name=docs.phar', $releaseId),
+                sprintf(
+                    'https://uploads.github.com/repos/%s/%s/releases/%s/assets?name=docs.phar',
+                    self::GITHUB_USER,
+                    self::GITHUB_REPO,
+                    $releaseId
+                ),
                 [
                     'headers' => ['Content-Type' => 'application/octet-stream'],
                     'body'    => file_get_contents(__DIR__.'/../../docs.phar'),
                 ]
             );
         } catch (ClientException $exception) {
             $this->deleteRelease($releaseId);
-            throw new RuntimeException('Error while adding asset to release. Maybe the tag name already exists?', 0, $exception);
+            throw new RuntimeException('Error while adding asset to release.', 0, $exception);
         }
     }
 
@@ -133,7 +153,7 @@ private function deleteRelease(int $releaseId): void
         try {
             $this->client->request(
                 'DELETE',
-                sprintf('https://api.github.com/repos/nikophil/test/releases/%s', $releaseId)
+                sprintf('https://api.github.com/repos/%s/%s/releases/%s', self::GITHUB_USER, self::GITHUB_REPO, $releaseId)
             );
         } catch (ClientException $exception) {
             throw new RuntimeException('Error while deleting release.', 0, $exception);