Skip to content

Commit 7a83d32

Browse files
committed
minor #647 [AI Bundle][Agent][Demo][Platform][Store] Remove Test Coverage Attributes (chr-hertel)
This PR was merged into the main branch. Discussion ---------- [AI Bundle][Agent][Demo][Platform][Store] Remove Test Coverage Attributes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT We're not using it, and Symfony usually also skips those information. And coverage is outdated and nearly impossible to review. Commits ------- 3421070b Remove Test Coverage Attributes
2 parents 1496d52 + 4b6f016 commit 7a83d32

File tree

153 files changed

+0
-1009
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

153 files changed

+0
-1009
lines changed

phpunit.xml.dist

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
cacheDirectory=".phpunit.cache"
66
colors="true"
77
executionOrder="depends,defects"
8-
requireCoverageMetadata="true"
9-
beStrictAboutCoverageMetadata="true"
108
beStrictAboutOutputDuringTests="true"
119
failOnRisky="true"
1210
failOnWarning="true">

tests/Bridge/AiMlApi/Completions/ModelClientTest.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,12 @@
1111

1212
namespace Symfony\AI\Platform\Tests\Bridge\AiMlApi\Completions;
1313

14-
use PHPUnit\Framework\Attributes\CoversClass;
15-
use PHPUnit\Framework\Attributes\Small;
16-
use PHPUnit\Framework\Attributes\UsesClass;
1714
use PHPUnit\Framework\TestCase;
1815
use Symfony\AI\Platform\Bridge\AiMlApi\Completions;
1916
use Symfony\AI\Platform\Bridge\AiMlApi\Completions\ModelClient;
2017
use Symfony\Component\HttpClient\MockHttpClient;
2118
use Symfony\Component\HttpClient\Response\MockResponse;
2219

23-
#[CoversClass(ModelClient::class)]
24-
#[UsesClass(Completions::class)]
25-
#[Small]
2620
class ModelClientTest extends TestCase
2721
{
2822
public function testItIsSupportingTheCorrectModel()

tests/Bridge/AiMlApi/Completions/ResultConverterTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,10 @@
1111

1212
namespace Symfony\AI\Platform\Tests\Bridge\AiMlApi\Completions;
1313

14-
use PHPUnit\Framework\Attributes\CoversClass;
15-
use PHPUnit\Framework\Attributes\Small;
16-
use PHPUnit\Framework\Attributes\UsesClass;
1714
use PHPUnit\Framework\TestCase;
1815
use Symfony\AI\Platform\Bridge\AiMlApi\Completions;
1916
use Symfony\AI\Platform\Bridge\AiMlApi\Completions\ResultConverter;
20-
use Symfony\AI\Platform\Bridge\OpenAi\Gpt\ResultConverter as OpenAiResultConverter;
2117

22-
#[CoversClass(ResultConverter::class)]
23-
#[UsesClass(Completions::class)]
24-
#[UsesClass(OpenAiResultConverter::class)]
25-
#[Small]
2618
class ResultConverterTest extends TestCase
2719
{
2820
public function testItSupportsCompletionsModel()

tests/Bridge/AiMlApi/Embeddings/ModelClientTest.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,12 @@
1111

1212
namespace Symfony\AI\Platform\Tests\Bridge\AiMlApi\Embeddings;
1313

14-
use PHPUnit\Framework\Attributes\CoversClass;
15-
use PHPUnit\Framework\Attributes\Small;
16-
use PHPUnit\Framework\Attributes\UsesClass;
1714
use PHPUnit\Framework\TestCase;
1815
use Symfony\AI\Platform\Bridge\AiMlApi\Embeddings;
1916
use Symfony\AI\Platform\Bridge\AiMlApi\Embeddings\ModelClient;
2017
use Symfony\Component\HttpClient\MockHttpClient;
2118
use Symfony\Component\HttpClient\Response\MockResponse;
2219

23-
#[CoversClass(ModelClient::class)]
24-
#[UsesClass(Embeddings::class)]
25-
#[Small]
2620
class ModelClientTest extends TestCase
2721
{
2822
public function testItIsSupportingTheCorrectModel()

tests/Bridge/AiMlApi/Embeddings/ResultConverterTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,13 @@
1111

1212
namespace Symfony\AI\Platform\Tests\Bridge\AiMlApi\Embeddings;
1313

14-
use PHPUnit\Framework\Attributes\CoversClass;
15-
use PHPUnit\Framework\Attributes\Small;
16-
use PHPUnit\Framework\Attributes\UsesClass;
1714
use PHPUnit\Framework\TestCase;
1815
use Symfony\AI\Platform\Bridge\AiMlApi\Embeddings;
1916
use Symfony\AI\Platform\Bridge\AiMlApi\Embeddings\ResultConverter;
2017
use Symfony\AI\Platform\Exception\RuntimeException;
2118
use Symfony\AI\Platform\Result\RawHttpResult;
22-
use Symfony\AI\Platform\Result\VectorResult;
23-
use Symfony\AI\Platform\Vector\Vector;
2419
use Symfony\Contracts\HttpClient\ResponseInterface;
2520

26-
#[CoversClass(ResultConverter::class)]
27-
#[Small]
28-
#[UsesClass(Vector::class)]
29-
#[UsesClass(VectorResult::class)]
30-
#[UsesClass(Embeddings::class)]
3121
class ResultConverterTest extends TestCase
3222
{
3323
public function testItConvertsAResponseToAVectorResult()

tests/Bridge/Albert/EmbeddingsModelClientTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,14 @@
1111

1212
namespace Symfony\AI\Platform\Tests\Bridge\Albert;
1313

14-
use PHPUnit\Framework\Attributes\CoversClass;
1514
use PHPUnit\Framework\Attributes\DataProvider;
16-
use PHPUnit\Framework\Attributes\Small;
1715
use PHPUnit\Framework\TestCase;
1816
use Symfony\AI\Platform\Bridge\Albert\EmbeddingsModelClient;
1917
use Symfony\AI\Platform\Bridge\OpenAi\Embeddings;
2018
use Symfony\AI\Platform\Bridge\OpenAi\Gpt;
2119
use Symfony\Component\HttpClient\MockHttpClient;
2220
use Symfony\Component\HttpClient\Response\JsonMockResponse;
2321

24-
#[CoversClass(EmbeddingsModelClient::class)]
25-
#[Small]
2622
final class EmbeddingsModelClientTest extends TestCase
2723
{
2824
public function testSupportsEmbeddingsModel()

tests/Bridge/Albert/GptModelClientTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111

1212
namespace Symfony\AI\Platform\Tests\Bridge\Albert;
1313

14-
use PHPUnit\Framework\Attributes\CoversClass;
1514
use PHPUnit\Framework\Attributes\DataProvider;
16-
use PHPUnit\Framework\Attributes\Small;
1715
use PHPUnit\Framework\TestCase;
1816
use Symfony\AI\Platform\Bridge\Albert\GptModelClient;
1917
use Symfony\AI\Platform\Bridge\OpenAi\Embeddings;
@@ -22,8 +20,6 @@
2220
use Symfony\Component\HttpClient\MockHttpClient;
2321
use Symfony\Component\HttpClient\Response\JsonMockResponse;
2422

25-
#[CoversClass(GptModelClient::class)]
26-
#[Small]
2723
final class GptModelClientTest extends TestCase
2824
{
2925
public function testConstructorWrapsHttpClientInEventSourceHttpClient()

tests/Bridge/Albert/PlatformFactoryTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,12 @@
1111

1212
namespace Symfony\AI\Platform\Tests\Bridge\Albert;
1313

14-
use PHPUnit\Framework\Attributes\CoversClass;
1514
use PHPUnit\Framework\Attributes\DataProvider;
16-
use PHPUnit\Framework\Attributes\Small;
1715
use PHPUnit\Framework\TestCase;
1816
use Symfony\AI\Platform\Bridge\Albert\PlatformFactory;
1917
use Symfony\AI\Platform\Exception\InvalidArgumentException;
2018
use Symfony\AI\Platform\Platform;
2119

22-
#[CoversClass(PlatformFactory::class)]
23-
#[Small]
2420
final class PlatformFactoryTest extends TestCase
2521
{
2622
public function testCreatesPlatformWithCorrectBaseUrl()

tests/Bridge/Anthropic/Contract/AssistantMessageNormalizerTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,14 @@
1111

1212
namespace Symfony\AI\Platform\Tests\Bridge\Anthropic\Contract;
1313

14-
use PHPUnit\Framework\Attributes\CoversClass;
1514
use PHPUnit\Framework\Attributes\DataProvider;
16-
use PHPUnit\Framework\Attributes\Small;
17-
use PHPUnit\Framework\Attributes\UsesClass;
1815
use PHPUnit\Framework\TestCase;
1916
use Symfony\AI\Platform\Bridge\Anthropic\Claude;
2017
use Symfony\AI\Platform\Bridge\Anthropic\Contract\AssistantMessageNormalizer;
2118
use Symfony\AI\Platform\Contract;
2219
use Symfony\AI\Platform\Message\AssistantMessage;
23-
use Symfony\AI\Platform\Model;
2420
use Symfony\AI\Platform\Result\ToolCall;
2521

26-
#[Small]
27-
#[CoversClass(AssistantMessageNormalizer::class)]
28-
#[UsesClass(Claude::class)]
29-
#[UsesClass(AssistantMessage::class)]
30-
#[UsesClass(Model::class)]
31-
#[UsesClass(ToolCall::class)]
3222
final class AssistantMessageNormalizerTest extends TestCase
3323
{
3424
public function testSupportsNormalization()

tests/Bridge/Anthropic/ModelClientTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,12 @@
1111

1212
namespace Symfony\AI\Platform\Bridge\Anthropic\Tests;
1313

14-
use PHPUnit\Framework\Attributes\CoversClass;
1514
use PHPUnit\Framework\TestCase;
1615
use Symfony\AI\Platform\Bridge\Anthropic\Claude;
1716
use Symfony\AI\Platform\Bridge\Anthropic\ModelClient;
1817
use Symfony\Component\HttpClient\MockHttpClient;
1918
use Symfony\Component\HttpClient\Response\JsonMockResponse;
2019

21-
#[CoversClass(ModelClient::class)]
2220
class ModelClientTest extends TestCase
2321
{
2422
private MockHttpClient $httpClient;

0 commit comments

Comments
 (0)