Commit 07701c5
committed
bug #963 [AI Bundle][VertexAI] factory get called with wrong arguments (franzwilding)
This PR was squashed before being merged into the main branch.
Discussion
----------
[AI Bundle][VertexAI] factory get called with wrong arguments
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| Docs? | no
| License | MIT
The vertex ai factory `create´method get called with one wrong "null" parameter. This removes the eventDispatcher, because it would be the 5th argument. Since method signature still is valid with null as 4th parameter, my `AiBundleTest::testExtensionLoadDoesNotThrow` test did not catch it.
Commits
-------
2e9a9b7 [AI Bundle][VertexAI] factory get called with wrong argumentsFile tree
2 files changed
+9
-2
lines changed- src/ai-bundle
- src
- tests/DependencyInjection
2 files changed
+9
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
507 | 507 | | |
508 | 508 | | |
509 | 509 | | |
510 | | - | |
511 | 510 | | |
512 | 511 | | |
513 | 512 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | 50 | | |
52 | 51 | | |
53 | 52 | | |
| |||
59 | 58 | | |
60 | 59 | | |
61 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
62 | 70 | | |
63 | 71 | | |
64 | 72 | | |
| |||
0 commit comments