Skip to content

Commit 2decdd0

Browse files
OskarStarkOskarStark
committed
minor #412 [Agent][Demo][Platform] Replace self::assert* with $this->assert* in test files (OskarStark)
This PR was squashed before being merged into the main branch. Discussion ---------- [Agent][Demo][Platform] Replace `self::assert*` with `$this->assert*` in test files | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | -- | License | MIT Following the codebase convention to use $this->assert* instead of self::assert* for better consistency across all test files Commits ------- 20f3d0c [Agent][Demo][Platform] Replace `self::assert*` with `$this->assert*` in test files
2 parents 56f51eb + 20f3d0c commit 2decdd0

File tree

7 files changed

+26
-26
lines changed

7 files changed

+26
-26
lines changed

‎demo/tests/SmokeTest.php‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ public function testIndex()
2626
$client = static::createClient();
2727
$client->request('GET', '/');
2828

29-
self::assertResponseIsSuccessful();
30-
self::assertSelectorTextSame('h1', 'Welcome to the LLM Chain Demo');
31-
self::assertSelectorCount(5, '.card');
29+
$this->assertResponseIsSuccessful();
30+
$this->assertSelectorTextSame('h1', 'Welcome to the LLM Chain Demo');
31+
$this->assertSelectorCount(5, '.card');
3232
}
3333

3434
#[DataProvider('provideChats')]
@@ -37,9 +37,9 @@ public function testChats(string $path, string $expectedHeadline)
3737
$client = static::createClient();
3838
$client->request('GET', $path);
3939

40-
self::assertResponseIsSuccessful();
41-
self::assertSelectorTextSame('h4', $expectedHeadline);
42-
self::assertSelectorCount(1, '#chat-submit');
40+
$this->assertResponseIsSuccessful();
41+
$this->assertSelectorTextSame('h4', $expectedHeadline);
42+
$this->assertSelectorCount(1, '#chat-submit');
4343
}
4444

4545
/**

‎src/agent/tests/Toolbox/MetadataFactory/ReflectionFactoryTest.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public function testGetDefinition()
6464
/** @var Tool[] $metadatas */
6565
$metadatas = iterator_to_array($this->factory->getTool(ToolRequiredParams::class));
6666

67-
self::assertToolConfiguration(
67+
$this->assertToolConfiguration(
6868
metadata: $metadatas[0],
6969
className: ToolRequiredParams::class,
7070
name: 'tool_required_params',
@@ -96,7 +96,7 @@ public function testGetDefinitionWithMultiple()
9696

9797
[$first, $second] = $metadatas;
9898

99-
self::assertToolConfiguration(
99+
$this->assertToolConfiguration(
100100
metadata: $first,
101101
className: ToolMultiple::class,
102102
name: 'tool_hello_world',
@@ -115,7 +115,7 @@ className: ToolMultiple::class,
115115
],
116116
);
117117

118-
self::assertToolConfiguration(
118+
$this->assertToolConfiguration(
119119
metadata: $second,
120120
className: ToolMultiple::class,
121121
name: 'tool_required_params',

‎src/platform/tests/Bridge/VertexAi/Gemini/ModelClientTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public function testItPassesServerToolsFromOptions()
6767
];
6868
$httpClient = new MockHttpClient(
6969
function ($method, $url, $options) {
70-
self::assertJsonStringEqualsJsonString(
70+
$this->assertJsonStringEqualsJsonString(
7171
<<<'JSON'
7272
{
7373
"tools": [

‎src/platform/tests/Message/AssistantMessageTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ public function testDifferentMessagesHaveDifferentUids()
6868
$message2 = new AssistantMessage('bar');
6969

7070
$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
71-
self::assertIsUuidV7($message1->getId()->toRfc4122());
72-
self::assertIsUuidV7($message2->getId()->toRfc4122());
71+
$this->assertIsUuidV7($message1->getId()->toRfc4122());
72+
$this->assertIsUuidV7($message2->getId()->toRfc4122());
7373
}
7474

7575
public function testSameMessagesHaveDifferentUids()
@@ -78,8 +78,8 @@ public function testSameMessagesHaveDifferentUids()
7878
$message2 = new AssistantMessage('foo');
7979

8080
$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
81-
self::assertIsUuidV7($message1->getId()->toRfc4122());
82-
self::assertIsUuidV7($message2->getId()->toRfc4122());
81+
$this->assertIsUuidV7($message1->getId()->toRfc4122());
82+
$this->assertIsUuidV7($message2->getId()->toRfc4122());
8383
}
8484

8585
public function testMessageIdImplementsRequiredInterfaces()

‎src/platform/tests/Message/SystemMessageTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ public function testDifferentMessagesHaveDifferentUids()
5050
$message2 = new SystemMessage('bar');
5151

5252
$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
53-
self::assertIsUuidV7($message1->getId()->toRfc4122());
54-
self::assertIsUuidV7($message2->getId()->toRfc4122());
53+
$this->assertIsUuidV7($message1->getId()->toRfc4122());
54+
$this->assertIsUuidV7($message2->getId()->toRfc4122());
5555
}
5656

5757
public function testSameMessagesHaveDifferentUids()
@@ -60,8 +60,8 @@ public function testSameMessagesHaveDifferentUids()
6060
$message2 = new SystemMessage('foo');
6161

6262
$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
63-
self::assertIsUuidV7($message1->getId()->toRfc4122());
64-
self::assertIsUuidV7($message2->getId()->toRfc4122());
63+
$this->assertIsUuidV7($message1->getId()->toRfc4122());
64+
$this->assertIsUuidV7($message2->getId()->toRfc4122());
6565
}
6666

6767
public function testMessageIdImplementsRequiredInterfaces()

‎src/platform/tests/Message/ToolCallMessageTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ public function testDifferentMessagesHaveDifferentUids()
5555
$message2 = new ToolCallMessage($toolCall, 'baz');
5656

5757
$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
58-
self::assertIsUuidV7($message1->getId()->toRfc4122());
59-
self::assertIsUuidV7($message2->getId()->toRfc4122());
58+
$this->assertIsUuidV7($message1->getId()->toRfc4122());
59+
$this->assertIsUuidV7($message2->getId()->toRfc4122());
6060
}
6161

6262
public function testSameMessagesHaveDifferentUids()
@@ -66,8 +66,8 @@ public function testSameMessagesHaveDifferentUids()
6666
$message2 = new ToolCallMessage($toolCall, 'bar');
6767

6868
$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
69-
self::assertIsUuidV7($message1->getId()->toRfc4122());
70-
self::assertIsUuidV7($message2->getId()->toRfc4122());
69+
$this->assertIsUuidV7($message1->getId()->toRfc4122());
70+
$this->assertIsUuidV7($message2->getId()->toRfc4122());
7171
}
7272

7373
public function testMessageIdImplementsRequiredInterfaces()

‎src/platform/tests/Message/UserMessageTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ public function testDifferentMessagesHaveDifferentUids()
9595
$message2 = new UserMessage(new Text('bar'));
9696

9797
$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
98-
self::assertIsUuidV7($message1->getId()->toRfc4122());
99-
self::assertIsUuidV7($message2->getId()->toRfc4122());
98+
$this->assertIsUuidV7($message1->getId()->toRfc4122());
99+
$this->assertIsUuidV7($message2->getId()->toRfc4122());
100100
}
101101

102102
public function testSameMessagesHaveDifferentUids()
@@ -105,8 +105,8 @@ public function testSameMessagesHaveDifferentUids()
105105
$message2 = new UserMessage(new Text('foo'));
106106

107107
$this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122());
108-
self::assertIsUuidV7($message1->getId()->toRfc4122());
109-
self::assertIsUuidV7($message2->getId()->toRfc4122());
108+
$this->assertIsUuidV7($message1->getId()->toRfc4122());
109+
$this->assertIsUuidV7($message2->getId()->toRfc4122());
110110
}
111111

112112
public function testMessageIdImplementsRequiredInterfaces()

0 commit comments

Comments
 (0)