Skip to content

Commit 337371a

Browse files
committed
feature #1172 [Chat][HttpFoundation] Rename SessionStore to MessageStore (OskarStark)
This PR was merged into the main branch. Discussion ---------- [Chat][HttpFoundation] Rename `SessionStore` to `MessageStore` | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | -- | License | MIT Renamed HttpFoundation\SessionStore to HttpFoundation\MessageStore for consistency with other message store bridges in the chat component. Commits ------- 149d2fd [Chat] Rename SessionStore to MessageStore
2 parents 611b83c + 149d2fd commit 337371a

File tree

5 files changed

+17
-17
lines changed

5 files changed

+17
-17
lines changed

examples/chat/persistent-chat-session.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*/
1111

1212
use Symfony\AI\Agent\Agent;
13-
use Symfony\AI\Chat\Bridge\HttpFoundation\SessionStore;
13+
use Symfony\AI\Chat\Bridge\HttpFoundation\MessageStore;
1414
use Symfony\AI\Chat\Chat;
1515
use Symfony\AI\Platform\Bridge\OpenAi\PlatformFactory;
1616
use Symfony\AI\Platform\Message\Message;
@@ -30,7 +30,7 @@
3030
$requestStack = new RequestStack();
3131
$requestStack->push($request);
3232

33-
$store = new SessionStore($requestStack, 'chat');
33+
$store = new MessageStore($requestStack, 'chat');
3434
$store->setup();
3535

3636
$agent = new Agent($platform, 'gpt-4o-mini');

examples/commands/message-stores.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
use MongoDB\Client as MongoDbClient;
1616
use Symfony\AI\Chat\Bridge\Cache\Store as CacheStore;
1717
use Symfony\AI\Chat\Bridge\Doctrine\DoctrineDbalMessageStore;
18-
use Symfony\AI\Chat\Bridge\HttpFoundation\SessionStore;
18+
use Symfony\AI\Chat\Bridge\HttpFoundation\MessageStore as SessionMessageStore;
1919
use Symfony\AI\Chat\Bridge\Meilisearch\MessageStore as MeilisearchMessageStore;
2020
use Symfony\AI\Chat\Bridge\MongoDb\MessageStore as MongoDbMessageStore;
2121
use Symfony\AI\Chat\Bridge\Pogocache\MessageStore as PogocacheMessageStore;
@@ -73,14 +73,14 @@
7373
], [
7474
new JsonEncoder(),
7575
])),
76-
'session' => static function (): SessionStore {
76+
'session' => static function (): SessionMessageStore {
7777
$request = Request::create('/');
7878
$request->setSession(new Session(new MockArraySessionStorage()));
7979

8080
$requestStack = new RequestStack();
8181
$requestStack->push($request);
8282

83-
return new SessionStore($requestStack, 'symfony');
83+
return new SessionMessageStore($requestStack, 'symfony');
8484
},
8585
'surrealdb' => static fn (): SurrealDbMessageStore => new SurrealDbMessageStore(
8686
httpClient: http_client(),

src/ai-bundle/src/AiBundle.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
use Symfony\AI\Chat\Bridge\Cache\Store as CacheMessageStore;
4040
use Symfony\AI\Chat\Bridge\Cloudflare\MessageStore as CloudflareMessageStore;
4141
use Symfony\AI\Chat\Bridge\Doctrine\DoctrineDbalMessageStore;
42-
use Symfony\AI\Chat\Bridge\HttpFoundation\SessionStore;
42+
use Symfony\AI\Chat\Bridge\HttpFoundation\MessageStore as SessionMessageStore;
4343
use Symfony\AI\Chat\Bridge\Meilisearch\MessageStore as MeilisearchMessageStore;
4444
use Symfony\AI\Chat\Bridge\MongoDb\MessageStore as MongoDbMessageStore;
4545
use Symfony\AI\Chat\Bridge\Pogocache\MessageStore as PogocacheMessageStore;
@@ -1961,7 +1961,7 @@ private function processMessageStoreConfig(string $type, array $messageStores, C
19611961

19621962
if ('session' === $type) {
19631963
foreach ($messageStores as $name => $messageStore) {
1964-
$definition = new Definition(SessionStore::class);
1964+
$definition = new Definition(SessionMessageStore::class);
19651965
$definition
19661966
->setLazy(true)
19671967
->setArguments([

src/chat/src/Bridge/HttpFoundation/SessionStore.php renamed to src/chat/src/Bridge/HttpFoundation/MessageStore.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
/**
2222
* @author Christopher Hertel <[email protected]>
2323
*/
24-
final class SessionStore implements ManagedStoreInterface, MessageStoreInterface
24+
final class MessageStore implements ManagedStoreInterface, MessageStoreInterface
2525
{
2626
private readonly SessionInterface $session;
2727

@@ -30,7 +30,7 @@ public function __construct(
3030
private readonly string $sessionKey = 'messages',
3131
) {
3232
if (!class_exists(RequestStack::class)) {
33-
throw new RuntimeException('For using the SessionStore as message store, the symfony/http-foundation package is required. Try running "composer require symfony/http-foundation".');
33+
throw new RuntimeException('For using the MessageStore as message store, the symfony/http-foundation package is required. Try running "composer require symfony/http-foundation".');
3434
}
3535

3636
$this->session = $requestStack->getSession();

src/chat/tests/Bridge/HttpFoundation/SessionStoreTest.php renamed to src/chat/tests/Bridge/HttpFoundation/MessageStoreTest.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
namespace Symfony\AI\Chat\Tests\Bridge\HttpFoundation;
1313

1414
use PHPUnit\Framework\TestCase;
15-
use Symfony\AI\Chat\Bridge\HttpFoundation\SessionStore;
15+
use Symfony\AI\Chat\Bridge\HttpFoundation\MessageStore;
1616
use Symfony\AI\Platform\Message\Message;
1717
use Symfony\AI\Platform\Message\MessageBag;
1818
use Symfony\Component\HttpFoundation\RequestStack;
1919
use Symfony\Component\HttpFoundation\Session\SessionInterface;
2020

21-
final class SessionStoreTest extends TestCase
21+
final class MessageStoreTest extends TestCase
2222
{
2323
public function testSetupStoresEmptyMessageBag()
2424
{
@@ -33,7 +33,7 @@ public function testSetupStoresEmptyMessageBag()
3333
->method('set')
3434
->with('messages', $this->isInstanceOf(MessageBag::class));
3535

36-
$store = new SessionStore($requestStack, 'messages');
36+
$store = new MessageStore($requestStack, 'messages');
3737
$store->setup();
3838
}
3939

@@ -50,7 +50,7 @@ public function testSetupWithCustomSessionKey()
5050
->method('set')
5151
->with('custom_key', $this->isInstanceOf(MessageBag::class));
5252

53-
$store = new SessionStore($requestStack, 'custom_key');
53+
$store = new MessageStore($requestStack, 'custom_key');
5454
$store->setup();
5555
}
5656

@@ -70,7 +70,7 @@ public function testSaveStoresMessageBag()
7070
->method('set')
7171
->with('messages', $messageBag);
7272

73-
$store = new SessionStore($requestStack, 'messages');
73+
$store = new MessageStore($requestStack, 'messages');
7474
$store->save($messageBag);
7575
}
7676

@@ -91,7 +91,7 @@ public function testLoadReturnsStoredMessages()
9191
->with('messages', $this->isInstanceOf(MessageBag::class))
9292
->willReturn($messageBag);
9393

94-
$store = new SessionStore($requestStack, 'messages');
94+
$store = new MessageStore($requestStack, 'messages');
9595
$result = $store->load();
9696

9797
$this->assertSame($messageBag, $result);
@@ -112,7 +112,7 @@ public function testLoadReturnsEmptyMessageBagWhenNotSet()
112112
->with('messages', $this->isInstanceOf(MessageBag::class))
113113
->willReturn(new MessageBag());
114114

115-
$store = new SessionStore($requestStack, 'messages');
115+
$store = new MessageStore($requestStack, 'messages');
116116
$result = $store->load();
117117

118118
$this->assertInstanceOf(MessageBag::class, $result);
@@ -132,7 +132,7 @@ public function testDropRemovesSessionKey()
132132
->method('remove')
133133
->with('messages');
134134

135-
$store = new SessionStore($requestStack, 'messages');
135+
$store = new MessageStore($requestStack, 'messages');
136136
$store->drop();
137137
}
138138
}

0 commit comments

Comments
 (0)